Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings around errors #596

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

abergmeier
Copy link
Contributor

Use correct function and remove ending exclamation mark.

Use correct function and remove ending exclamation mark.
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 26, 2020

CLA assistant check
All committers have signed the CLA.

@paddycarver
Copy link
Contributor

Hey @abergmeier, does this fix a behavior or does something not work without this merged that works with it merged?

@abergmeier
Copy link
Contributor Author

abergmeier commented Sep 28, 2020

It fixes warning you get from Go. So reducing the noise when coding. Wonder though, why, I assume, your CI doesn't flag that.

@paddycarver
Copy link
Contributor

Hmm, as far as I know, Go doesn't issue warnings. Do you mean golint? Or go vet? What command are you running that's producing the warning?

@abergmeier
Copy link
Contributor Author

It is actually both. IIRC exclamation mark is golint, formatting function is go vet.

@paddycarver paddycarver merged commit 15e006f into hashicorp:master Dec 17, 2020
@ghost
Copy link

ghost commented Jan 17, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants