Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable checkpoint during tests. #663

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

paddycarver
Copy link
Contributor

We don't need to reach out to checkpoint when running tests, so disable
that information. Fixes #640.

Also remove our logging override, as we've updated to a version of
go-plugin that doesn't require that anymore. See also #661.

We don't need to reach out to checkpoint when running tests, so disable
that information. Fixes #640.

Also remove our logging override, as we've updated to a version of
go-plugin that doesn't require that anymore. See also #661.
@paddycarver paddycarver requested a review from kmoe December 18, 2020 02:35
@paddycarver paddycarver changed the title Disable checkpoint. Disable checkpoint during tests. Dec 18, 2020
@paddycarver paddycarver added the subsystem/tests Issues and feature requests related to the testing framework. label Dec 18, 2020
Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether the SDK needs to reach out to Checkpoint during tests depends on the following environment variables:

  • TF_ACC_TERRAFORM_VERSION
  • TF_ACC_TERRAFORM_PATH

If neither of these is set, and if there is no version of terraform on the system $PATH, plugintest will fall back to installing the latest available version of Terraform via tfinstall.LatestVersion, with forceCheckpoint set to true (see https://github.com/hashicorp/terraform-plugin-sdk/blob/master/internal/plugintest/config.go#L42). This means the value of CHECKPOINT_DISABLE is ignored, so the latest version of Terraform can always be found.

@paddycarver paddycarver merged commit ef2ccc5 into master Dec 18, 2020
@paddycarver paddycarver deleted the paddy_acctest_checkpoint branch December 18, 2020 20:44
paddycarver added a commit that referenced this pull request Dec 18, 2020
Missed a logging override in #663. This should fix the last of the race
condition where logging can get written to stderr unexpectedly during
tests. We no longer need to do this because go-plugin was fixed and we
upgraded in #639. We don't want to overwrite that fix in tests.
paddycarver added a commit that referenced this pull request Dec 18, 2020
Missed a logging override in #663. This should fix the last of the race
condition where logging can get written to stderr unexpectedly during
tests. We no longer need to do this because go-plugin was fixed and we
upgraded in #639. We don't want to overwrite that fix in tests.
@ghost
Copy link

ghost commented Jan 18, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
subsystem/tests Issues and feature requests related to the testing framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHECKPOINT_DISABLE should be set for integration test runs
2 participants