helper/schema: Add validation to prevent write-only attributes in set nested blocks #1427
+28
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SBGoods
force-pushed
the
SBGoods/write-only-set-validation
branch
from
75f6c6e to
cca1351
Compare
austinvalle
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
I don't think we have to repeat this changelog, but I'm not expressly against it 😆
| @@ -5303,7 +5303,7 @@ func TestSchemaMap_InternalValidate(t *testing.T) { | |||
| }, | |||
| true, | |||
| }, | |||
| "Set configuration block nested attribute with WriteOnly set returns no errors": { | |||
| "Set configuration block nested attribute with WriteOnly set returns error": { | |||
There was a problem hiding this comment.
Nice that we already had tests for it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write-only attributes when used with ephemeral data cannot be used within any set and set-based data due to limitations in Terraform Core. This PR adds validation to block write-only attributes from being used within set nested blocks.