Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ephemeral_block_device isn't getting set in aws_instance resource #10031

Closed
ryndaniels opened this issue Sep 6, 2019 · 2 comments
Closed

ephemeral_block_device isn't getting set in aws_instance resource #10031

ryndaniels opened this issue Sep 6, 2019 · 2 comments
Assignees
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.

Comments

@ryndaniels
Copy link
Contributor

As part of fixing #7198, we discovered that ephemeral_block_device doesn't actually get set in the aws_instance resource. We'll want to actually do that, as this is likely the cause of several existing issues and bug reports related to ephemeral_block_devices.

@ryndaniels ryndaniels added bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. labels Sep 6, 2019
@ryndaniels ryndaniels self-assigned this Sep 6, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Sep 6, 2019
@ryndaniels ryndaniels removed the needs-triage Waiting for first response or review from a maintainer. label Sep 6, 2019
@ryndaniels
Copy link
Contributor Author

After digging further, it seems like neither BlockDeviceMappings nor DescribeVolumes surfaces ephemeral block device information. Ephemeral block device info for running instances can be found by querying instance metadata but that feels a bit hacky.

The BlockDeviceMapping struct does have a VirtualName field for ephemeral devices, but in our acceptance testing, that field was nil for all devices returned this way, even though there was an ephemeral device configured in the test setup - ephemeral devices seem to be an input-only sort of thing.

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Development

No branches or pull requests

1 participant