Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKS Windows Node Group #11065

Closed
gibsonje opened this issue Nov 29, 2019 · 5 comments
Closed

EKS Windows Node Group #11065

gibsonje opened this issue Nov 29, 2019 · 5 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. upstream Addresses functionality related to the cloud provider.

Comments

@gibsonje
Copy link

gibsonje commented Nov 29, 2019

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

I'd like to be able to create Windows node groups for EKS.

The EKS docs show that with eksctl you can create windows node groups but the terraform eks node group module doesn't allow it.

https://docs.aws.amazon.com/eks/latest/userguide/launch-windows-workers.html

eksctl create nodegroup \
--region us-west-2 \
--cluster windows \
--name windows-ng \
--node-type t2.large \
--nodes 3 \
--nodes-min 1 \
--nodes-max 4 \
--node-ami-family WindowsServer2019FullContainer

I see a list of amis here:
https://github.com/weaveworks/eksctl/blob/ef183767fa7a19205d02e63375aacb889b55b732/pkg/ami/static_resolver_ami.go

Docs show this:
https://eksctl.io/usage/custom-ami-support/

With 4 AMI families, Amazon Linux, Ubuntu, Windows Server Full, Windows Server Core.

New or Affected Resource(s)

  • aws_eks_node_group

Potential Terraform Configuration

resource "aws_eks_node_group" "windows_nodes" {
  cluster_name    = "foo"
  node_group_name = "foo-windows"
  node_role_arn   = "${data.aws_iam_role.node.arn}"
  subnet_ids      = ["${data.aws_subnet_ids.eks_private.ids}"]

  ami_type        = "WindowsServer2019FullContainer"

  scaling_config {
    desired_size = "1"
    max_size     = "5"
    min_size     = "1"
  }
}

References

  • #0000
@gibsonje gibsonje added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 29, 2019
@ghost ghost added the service/eks Issues and PRs that pertain to the eks service. label Nov 29, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Nov 29, 2019
@ewbankkit
Copy link
Contributor

@ewbankkit
Copy link
Contributor

@gibsonje The eksctl command you showed does not create an EKS managed nodegroup, instead creating a standard unmanaged nodegroup.
I think there need to be enhancements from Amazon to enabled managed Windows nodegroups.

@bflad bflad added upstream Addresses functionality related to the cloud provider. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 2, 2019
@bflad
Copy link
Contributor

bflad commented Dec 2, 2019

Hi @gibsonje 👋 Thank you for submitting this. As mentioned above, this functionality is not directly available via the EKS API at the moment. This support can be tracked at aws/containers-roadmap#584. When the API support becomes available we will support this directly in the Terraform AWS Provider, but for now we will opt to close this feature request until that time comes. 👍

@bflad bflad closed this as completed Dec 2, 2019
@gibsonje
Copy link
Author

gibsonje commented Dec 2, 2019

Sounds good, thanks!

@ghost
Copy link

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/eks Issues and PRs that pertain to the eks service. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

No branches or pull requests

3 participants