Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: AWS Network Manager for Transit Gateways #11132

Closed
chrisdewar opened this issue Dec 4, 2019 · 8 comments · Fixed by #13251
Closed

New Feature: AWS Network Manager for Transit Gateways #11132

chrisdewar opened this issue Dec 4, 2019 · 8 comments · Fixed by #13251
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. new-resource Introduces a new resource. service/networkmanager Issues and PRs that pertain to the networkmanager service.
Milestone

Comments

@chrisdewar
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

A new "global network" product has been released by AWS (see references), I would like to be able to use it in terraform.

New or Affected Resource(s)

Suggested resource names (not wedded to any of them):

  • aws_networkmanager_global_network
  • aws_networkmanager_site
  • aws_networkmanager_link
  • aws_networkmanager_device
  • aws_networkmanager_transit_gateway_registration

Potential Terraform Configuration

resource "aws_global_network" "network" {
  description = "this is a test network"
  tags = {
    Name = "test-network"
  }
}

resource "aws_globalnetwork_transit_gateway_registration" "transit_gateway" {
  network = "${aws_networkmanager_global_network.network}"
  transit_gateway = "${aws_ec2_transit_gateway.gateway.id}"
}

References

@chrisdewar chrisdewar added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 4, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 4, 2019
@Omarimcblack
Copy link
Contributor

I will be working on this along with @j-nix, we propose the following updated resource list:

  • aws_networkmanager_global_network
  • aws_networkmanager_site
  • aws_networkmanager_link
  • aws_networkmanager_device
  • aws_networkmanager_transit_gateway_registration
  • aws_networkmanager_customer_gateway_association
  • aws_networkmanager_link_association

@reegnz
Copy link

reegnz commented Jul 20, 2020

@Omarimcblack any progress on the new proposed resources? I am really excited about your work!

@Fuuzetsu
Copy link

Fuuzetsu commented Oct 1, 2020

I believe the work is on-going at #13251

@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@Omarimcblack
Copy link
Contributor

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

Thanks @ewbankkit for jumping in on my PR #13251 help has been much appreciated

@ewbankkit
Copy link
Contributor

Renamed this issue to AWS Network Manager for Transit Gateways from Global Network as only the transit gateway functionality of AWS Network Manager will be implemented, NOT the currently in-preview Cloud WAN functionality.

@ewbankkit ewbankkit changed the title New Feature: Global Network New Feature: AWS Network Manager for Transit Gateways Mar 12, 2022
@ewbankkit ewbankkit added the new-data-source Introduces a new data source. label Mar 12, 2022
@github-actions github-actions bot added this to the v4.6.0 milestone Mar 14, 2022
@github-actions
Copy link

This functionality has been released in v4.6.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 7, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-data-source Introduces a new data source. new-resource Introduces a new resource. service/networkmanager Issues and PRs that pertain to the networkmanager service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants