Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement data source for EKS Manage Node Groups #13442

Closed
zot24 opened this issue May 20, 2020 · 10 comments · Fixed by #13564
Closed

Feature: Implement data source for EKS Manage Node Groups #13442

zot24 opened this issue May 20, 2020 · 10 comments · Fixed by #13564
Labels
new-data-source Introduces a new data source. service/eks Issues and PRs that pertain to the eks service.
Milestone

Comments

@zot24
Copy link
Contributor

zot24 commented May 20, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

At the minute there is no data source for EKS Manage Node Groups https://www.terraform.io/docs/providers/aws/r/eks_node_group.html only the resource, will be interesting to have the information from that created resource for different scenarios.

For example when building the aws-auth from a different plan than the one creating the node groups https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/aws_auth.tf#L62 you can gather all the information from https://docs.aws.amazon.com/cli/latest/reference/eks/describe-nodegroup.html to build the map_role using the specific role_arn from nodeRole set to your node group

New or Affected Resource(s)

  • data.aws_eks_node_group
  • data.aws_eks_node_group_names

Potential Terraform Configuration

data "aws_eks_node_group_names" "example" {
  cluster_name = "example"
}

data "aws_eks_node_group" "example" {
  for_each = data.aws_eks_node_group_names.example.names
  cluster_name    = "example"
  node_group_name = each.value
}

References

@zot24 zot24 added the enhancement Requests to existing resources that expand the functionality or scope. label May 20, 2020
@ghost ghost added the service/eks Issues and PRs that pertain to the eks service. label May 20, 2020
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 20, 2020
@zot24
Copy link
Contributor Author

zot24 commented May 20, 2020

I'm willing to work on this as it's something we need at the minute, some feedback and thoughts will be appreciated

@bflad bflad added new-data-source Introduces a new data source. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Jul 1, 2020
@DonBower
Copy link

DonBower commented Apr 5, 2021

nearly a year old, and the PR is still open?

@zot24
Copy link
Contributor Author

zot24 commented Apr 6, 2021

Hey @DonBower! I'm the individual contributor for the PR related to this issue, I believe I have pending to do some modifications they are recommending us to do on this comment #13564 (comment)

Maybe that's why it's being stuck in that state, will try to find some time to address those and see if that move things forward as well as upgrade from master

@zot24
Copy link
Contributor Author

zot24 commented May 5, 2021

Done @DonBower I have updated the PR with the requested changes 👍🏽 cc @bflad

@DonBower
Copy link

Thanks, @zot24 Can't wait to use it!

@DonBower
Copy link

@blflad do you know when the PR for this will be merged?

@DonBower
Copy link

@zot24 @bflad Still looking forward to this feature...

@ankitjhingan
Copy link

+1 for having data-source of aws_eks_node_group....

@breathingdust breathingdust added this to the v3.59.0 milestone Sep 16, 2021
@github-actions
Copy link

This functionality has been released in v3.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new-data-source Introduces a new data source. service/eks Issues and PRs that pertain to the eks service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants