Add resource aws_iot_ca_certificate and data aws_iot_registration_code #15098
Conversation
ghost
added
size/XL
anGie44
added
new-data-source
|
There seems to be a small conflict in this PR. @funnybirdman @brandon-bird-yolabs do you have time to fix this? |
|
Any chance to see this included? |
|
@funnybirdman I see you merged master into the repo but there still seems to be some missing parts:
|
|
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
github-actions
bot
added
pre-service-packages
% make testacc TESTARGS='-run=TestAccIoTRegistrationCodeDataSource_' PKG=iot ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run=TestAccIoTRegistrationCodeDataSource_ -timeout 360m === RUN TestAccIoTRegistrationCodeDataSource_basic === PAUSE TestAccIoTRegistrationCodeDataSource_basic === CONT TestAccIoTRegistrationCodeDataSource_basic --- PASS: TestAccIoTRegistrationCodeDataSource_basic (16.37s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 21.673s
# Conflicts: # aws/provider.go
% make testacc TESTARGS='-run=TestAccIoTCACertificate_basic' PKG=iot ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run=TestAccIoTCACertificate_basic -timeout 360m === RUN TestAccIoTCACertificate_basic --- PASS: TestAccIoTCACertificate_basic (19.53s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 24.760s
% make testacc TESTARGS='-run=TestAccIoTCACertificate_' PKG=iot ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTCACertificate_ -timeout 360m === RUN TestAccIoTCACertificate_basic === PAUSE TestAccIoTCACertificate_basic === RUN TestAccIoTCACertificate_disappears === PAUSE TestAccIoTCACertificate_disappears === RUN TestAccIoTCACertificate_tags === PAUSE TestAccIoTCACertificate_tags === RUN TestAccIoTCACertificate_defaultMode === PAUSE TestAccIoTCACertificate_defaultMode === CONT TestAccIoTCACertificate_basic === CONT TestAccIoTCACertificate_tags --- PASS: TestAccIoTCACertificate_basic (21.54s) === CONT TestAccIoTCACertificate_defaultMode --- PASS: TestAccIoTCACertificate_tags (54.91s) === CONT TestAccIoTCACertificate_disappears --- PASS: TestAccIoTCACertificate_defaultMode (45.12s) --- PASS: TestAccIoTCACertificate_disappears (17.64s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 78.487s
% make testacc TESTARGS='-run=TestAccIoTCertificate_' PKG=iot ACCTEST_PARALLELISM=2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTCertificate_ -timeout 360m === RUN TestAccIoTCertificate_csr === PAUSE TestAccIoTCertificate_csr === RUN TestAccIoTCertificate_Keys_certificate === PAUSE TestAccIoTCertificate_Keys_certificate === RUN TestAccIoTCertificate_Keys_existingCertificate === PAUSE TestAccIoTCertificate_Keys_existingCertificate === CONT TestAccIoTCertificate_csr === CONT TestAccIoTCertificate_Keys_existingCertificate --- PASS: TestAccIoTCertificate_csr (24.53s) === CONT TestAccIoTCertificate_Keys_certificate --- PASS: TestAccIoTCertificate_Keys_existingCertificate (40.24s) --- PASS: TestAccIoTCertificate_Keys_certificate (19.25s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 49.638s
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccIoTRegistrationCodeDataSource_' PKG=iot
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 20 -run=TestAccIoTRegistrationCodeDataSource_ -timeout 360m
=== RUN TestAccIoTRegistrationCodeDataSource_basic
=== PAUSE TestAccIoTRegistrationCodeDataSource_basic
=== CONT TestAccIoTRegistrationCodeDataSource_basic
--- PASS: TestAccIoTRegistrationCodeDataSource_basic (16.37s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 21.673s% make testacc TESTARGS='-run=TestAccIoTCACertificate_' PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTCACertificate_ -timeout 360m
=== RUN TestAccIoTCACertificate_basic
=== PAUSE TestAccIoTCACertificate_basic
=== RUN TestAccIoTCACertificate_disappears
=== PAUSE TestAccIoTCACertificate_disappears
=== RUN TestAccIoTCACertificate_tags
=== PAUSE TestAccIoTCACertificate_tags
=== RUN TestAccIoTCACertificate_defaultMode
=== PAUSE TestAccIoTCACertificate_defaultMode
=== CONT TestAccIoTCACertificate_basic
=== CONT TestAccIoTCACertificate_tags
--- PASS: TestAccIoTCACertificate_basic (21.54s)
=== CONT TestAccIoTCACertificate_defaultMode
--- PASS: TestAccIoTCACertificate_tags (54.91s)
=== CONT TestAccIoTCACertificate_disappears
--- PASS: TestAccIoTCACertificate_defaultMode (45.12s)
--- PASS: TestAccIoTCACertificate_disappears (17.64s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 78.487s% make testacc TESTARGS='-run=TestAccIoTCertificate_' PKG=iot ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/iot/... -v -count 1 -parallel 2 -run=TestAccIoTCertificate_ -timeout 360m
=== RUN TestAccIoTCertificate_csr
=== PAUSE TestAccIoTCertificate_csr
=== RUN TestAccIoTCertificate_Keys_certificate
=== PAUSE TestAccIoTCertificate_Keys_certificate
=== RUN TestAccIoTCertificate_Keys_existingCertificate
=== PAUSE TestAccIoTCertificate_Keys_existingCertificate
=== CONT TestAccIoTCertificate_csr
=== CONT TestAccIoTCertificate_Keys_existingCertificate
--- PASS: TestAccIoTCertificate_csr (24.53s)
=== CONT TestAccIoTCertificate_Keys_certificate
--- PASS: TestAccIoTCertificate_Keys_existingCertificate (40.24s)
--- PASS: TestAccIoTCertificate_Keys_certificate (19.25s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/iot 49.638s
|
@funnybirdman Thanks for the contribution 🎉 👏. |
|
This functionality has been released in v5.26.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #14949.
Closes #15840.
Closes #33057.
Release note for CHANGELOG:
Output from acceptance testing: