Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/resource/aws_emr_cluster: TestAccAWSEMRCluster_instance_fleet* tests broken (GovCloud) #15607

Closed
YakDriver opened this issue Oct 12, 2020 · 2 comments
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/emr Issues and PRs that pertain to the emr service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Comments

@YakDriver
Copy link
Member

YakDriver commented Oct 12, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

After attempting to create a PreCheck for this, I've discovered the problem is not simple. Various pieces of infrastructure have to be in place before it is possible to create the fleet and it is not practical to create so much infrastructure for a PreCheck. This would be an excellent place to use SkipOnError as described in hashicorp/terraform-plugin-sdk#592.

These tests fail on GovCloud:

=== RUN   TestAccAWSEMRCluster_instance_fleet
    TestAccAWSEMRCluster_instance_fleet: resource_aws_emr_cluster_test.go:1366: Step 1/1 error: Error running apply: 2020/10/09 23:38:10 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
        
        Error: error running EMR Job Flow: ValidationException: Instance fleets are not available for the account: (GovCloud account #).
        	status code: 400, request id: a3a1c773-0782-4af4-9e25-958d2cd027de
        
--- FAIL: TestAccAWSEMRCluster_instance_fleet (25.11s)
=== RUN   TestAccAWSEMRCluster_instance_fleet_master_only
    TestAccAWSEMRCluster_instance_fleet_master_only: resource_aws_emr_cluster_test.go:1388: Step 1/1 error: Error running apply: 2020/10/09 23:38:12 [DEBUG] Using modified User-Agent: Terraform/0.12.29 HashiCorp-terraform-exec/0.10.0
        
        Error: error running EMR Job Flow: ValidationException: Instance fleets are not available for the account: (GovCloud account #).
        	status code: 400, request id: cc63f890-54e6-4371-bbc7-e3b59dadb5f2
        
--- FAIL: TestAccAWSEMRCluster_instance_fleet_master_only (25.00s)

Affected Resource

  • aws_emr_cluster

References

@YakDriver YakDriver added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/emr Issues and PRs that pertain to the emr service. partition/aws-us-gov Pertains to the aws-us-gov partition. labels Oct 12, 2020
@github-actions
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Oct 11, 2022
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 12, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
partition/aws-us-gov Pertains to the aws-us-gov partition. service/emr Issues and PRs that pertain to the emr service. stale Old or inactive issues managed by automation, if no further action taken these will get closed. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

No branches or pull requests

1 participant