-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/glue_catalog_database - Add sweeper + use catalog_id when deleting #17489
r/glue_catalog_database - Add sweeper + use catalog_id when deleting #17489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 120m
=== RUN TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN TestAccAWSGlueCatalogDatabase_disappears
=== PAUSE TestAccAWSGlueCatalogDatabase_disappears
=== CONT TestAccAWSGlueCatalogDatabase_full
=== CONT TestAccAWSGlueCatalogDatabase_disappears
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (10.09s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (33.13s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 33.221s
LGTM 🚀 Thanks @DrFaust92! Verified Acceptance Tests in Commercial (us-west-2) make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueCatalogDatabase_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogDatabase_ -timeout 120m
go: downloading github.com/hashicorp/go-cleanhttp v0.5.2
=== RUN TestAccAWSGlueCatalogDatabase_full
=== PAUSE TestAccAWSGlueCatalogDatabase_full
=== RUN TestAccAWSGlueCatalogDatabase_disappears
=== PAUSE TestAccAWSGlueCatalogDatabase_disappears
=== CONT TestAccAWSGlueCatalogDatabase_full
=== CONT TestAccAWSGlueCatalogDatabase_disappears
--- PASS: TestAccAWSGlueCatalogDatabase_disappears (9.92s)
--- PASS: TestAccAWSGlueCatalogDatabase_full (31.36s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 33.181s |
This has been released in version 3.28.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Output from acceptance testing: