Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase route_table Create timeout #21531

Merged
merged 3 commits into from
Dec 16, 2021
Merged

Conversation

huguesalary
Copy link
Contributor

From 2 minutes to 5 minutes to address #21032

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #21032

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@github-actions github-actions bot added service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. labels Oct 28, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @huguesalary 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@justinretzolk justinretzolk added the timeouts Pertains to timeout increases. label Oct 28, 2021
Copy link

@KartikVelede KartikVelede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@anGie44
Copy link
Contributor

anGie44 commented Nov 9, 2021

Hi @huguesalary , thank you for raising this PR! Since the github issue in reference describes the timeout coming from the aws_route resource, do you mind opening a new PR that adjusts the timeout in that resource as well?

@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 9, 2021
@anGie44 anGie44 self-assigned this Nov 9, 2021
@anGie44 anGie44 added the waiting-response Maintainers are waiting on response from community or contributor. label Nov 11, 2021
Copy link

@i-engy i-engy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a must to have a working aws environment. please merge this change to use 5 mins.

@huguesalary
Copy link
Contributor Author

Hi @huguesalary , thank you for raising this PR! Since the github issue in reference describes the timeout coming from the aws_route resource, do you mind opening a new PR that adjusts the timeout in that resource as well?

Hi sorry for the (long) delay here. I'll look into adding this timeout right away

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 15, 2021
From 2 minutes to 5 minutes to address hashicorp#21032
@huguesalary huguesalary marked this pull request as ready for review December 15, 2021 18:58
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Dec 16, 2021
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this enhancement @huguesalary ! LGTM 🚀

@anGie44 anGie44 added this to the v3.70.0 milestone Dec 16, 2021
@anGie44 anGie44 merged commit 5427777 into hashicorp:main Dec 16, 2021
@github-actions
Copy link

This functionality has been released in v3.70.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR. timeouts Pertains to timeout increases.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource/aws_route: route is not saved in the state when it fails to be available (in 2m) on creation
5 participants