Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_wafv2_web_acl: managed-rule-group-statement is missing Version option #21546

Closed
davy-oo opened this issue Oct 29, 2021 · 5 comments · Fixed by #21732
Closed

aws_wafv2_web_acl: managed-rule-group-statement is missing Version option #21546

davy-oo opened this issue Oct 29, 2021 · 5 comments · Fixed by #21732
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Milestone

Comments

@davy-oo
Copy link

davy-oo commented Oct 29, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS WAF offers an optional "Version" to stick to a static version for ManagedRuleGroupStatement. See AWS APIReference.

The AWS provider does not seem to support it according to the latest 3.60 doc.

The version option is useful to test new set of coming rules. AWS released this new option on Aug 9, 2021: https://aws.amazon.com/about-aws/whats-new/2021/08/aws-waf-offers-managed-rule-group-versioning/

Use case: AWS sent recommendation like this one by email:
"On October 27, 2021, we published a new version of the Core Rule Set, currently available as a static version, named Version_1.2, in the console. On November 3, 2021. the Default version for this rule group will be updated to the same configuration as Version_1.2. If you are using the Default version, Version_1.2 can be tested prior to November 3, 2021 by switching to the static version.If you require more time to test the new version we recommend staying on or moving to Version_1.1(previous version) before November 3, 2021. "

New or Affected Resource(s)

  • aws_wafv2_web_acl, managed-rule-group-statement

Potential Terraform Configuration

See potential new "version" option below.

resource "aws_wafv2_web_acl" "example" {
...
statement {
      managed_rule_group_statement {
        name             = "AWSManagedRulesCommonRuleSet"
        version          = "Version_1.1"
        vendor_name      = "AWS"
        excluded_rule {
          name = "SizeRestrictions_BODY"
        }
      }
    }
...
}

References

@davy-oo davy-oo added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 29, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/wafv2 Issues and PRs that pertain to the wafv2 service. labels Oct 29, 2021
@davy-oo davy-oo changed the title wafv2_web_acl: managed-rule-group-statement is missing Version option aws_wafv2_web_acl: managed-rule-group-statement is missing Version option Oct 29, 2021
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 29, 2021
@galoitsu
Copy link
Contributor

I have worked on this issue here.

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@YakDriver YakDriver self-assigned this Feb 8, 2022
@YakDriver
Copy link
Member

Closed by #21732

@YakDriver YakDriver added this to the v4.0.0 milestone Feb 8, 2022
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/wafv2 Issues and PRs that pertain to the wafv2 service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants