New Data Source: aws_ec2_instance_types

[rrangith]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21849

This pr uses code based on the existing instance_type_offerings code:
https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/ec2/instance_type_offerings_data_source.go
https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/ec2/instance_type_offerings_data_source_test.go

Output from acceptance testing:

$ make testacc TESTS=TestAccEC2InstanceTypesDataSource PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceTypesDataSource' -timeout 180m
=== RUN   TestAccEC2InstanceTypesDataSource_filter
=== PAUSE TestAccEC2InstanceTypesDataSource_filter
=== CONT  TestAccEC2InstanceTypesDataSource_filter
--- PASS: TestAccEC2InstanceTypesDataSource_filter (31.66s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        33.793s
...

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TESTS=TestAccEC2InstanceTypesDataSource_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceTypesDataSource_' -timeout 180m
=== RUN   TestAccEC2InstanceTypesDataSource_basic
=== PAUSE TestAccEC2InstanceTypesDataSource_basic
=== RUN   TestAccEC2InstanceTypesDataSource_filter
=== PAUSE TestAccEC2InstanceTypesDataSource_filter
=== CONT  TestAccEC2InstanceTypesDataSource_basic
=== CONT  TestAccEC2InstanceTypesDataSource_filter
--- PASS: TestAccEC2InstanceTypesDataSource_filter (21.10s)
--- PASS: TestAccEC2InstanceTypesDataSource_basic (21.80s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	25.337s

GovCloud

% make testacc TESTS=TestAccEC2InstanceTypesDataSource_ PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2InstanceTypesDataSource_' -timeout 180m
=== RUN   TestAccEC2InstanceTypesDataSource_basic
=== PAUSE TestAccEC2InstanceTypesDataSource_basic
=== RUN   TestAccEC2InstanceTypesDataSource_filter
=== PAUSE TestAccEC2InstanceTypesDataSource_filter
=== CONT  TestAccEC2InstanceTypesDataSource_basic
=== CONT  TestAccEC2InstanceTypesDataSource_filter
--- PASS: TestAccEC2InstanceTypesDataSource_filter (22.18s)
--- PASS: TestAccEC2InstanceTypesDataSource_basic (22.24s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	25.698s

[ewbankkit]

@rrangith Thanks for the contribution 🎉 👏.

I tweaked the acceptance test a bit to

1. Add a test with no filter
2. Get the test with a filter passing in GovCloud

[github-actions]

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.