Increase rules and destination limits for aws_ecr_replication_configuration

[sjonpaulbrown]

Description

This Pull Request increases the rules and destination limits for the aws_ecr_replication_configuration. The replication configuration can contain up to 10 rules, and each rule can contain up to 25 destinations.

• AWS ECR API Documentation for ReplicationConfig Rule limits
• AWS ECR API Documentation for ReplicationRule Destination Limits

This PR only encompasses resource schema updates to allow us to match the limits that have been declared by the AWS API.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #21898

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccECRReplicationConfiguration_' PKG_NAME=internal/service/ecr
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run=TestAccECRReplicationConfiguration_ -timeout 180m
=== RUN   TestAccECRReplicationConfiguration_basic
=== PAUSE TestAccECRReplicationConfiguration_basic
=== CONT  TestAccECRReplicationConfiguration_basic
--- PASS: TestAccECRReplicationConfiguration_basic (43.27s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ecr        54.523s

Example Usage of Multiple Replication Rules with Multiple Destinations

Terraform Configuration

data "aws_caller_identity" "current" {}

resource "aws_ecr_replication_configuration" "example" {
  replication_configuration {
    rule {
      destination {
        region      = "us-west-1"
        registry_id = data.aws_caller_identity.current.account_id
      }
      destination {
        region      = "us-west-2"
        registry_id = data.aws_caller_identity.current.account_id
      }
    }
    rule {
      destination {
        region      = "eu-west-1"
        registry_id = data.aws_caller_identity.current.account_id
      }
      destination {
        region      = "eu-west-2"
        registry_id = data.aws_caller_identity.current.account_id
      }
    }
  }
}

Apply Output

$ terraform apply

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # aws_ecr_replication_configuration.example will be created
  + resource "aws_ecr_replication_configuration" "example" {
      + id          = (known after apply)
      + registry_id = (known after apply)

      + replication_configuration {
          + rule {
              + destination {
                  + region      = "us-west-1"
                  + registry_id = "562177434340"
                }
              + destination {
                  + region      = "us-west-2"
                  + registry_id = "562177434340"
                }
            }
          + rule {
              + destination {
                  + region      = "eu-west-1"
                  + registry_id = "562177434340"
                }
              + destination {
                  + region      = "eu-west-2"
                  + registry_id = "562177434340"
                }
            }
        }
    }

Plan: 1 to add, 0 to change, 0 to destroy.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

aws_ecr_replication_configuration.example: Creating...
aws_ecr_replication_configuration.example: Creation complete after 1s [id=562177434340]

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

[ewbankkit]

LGTM 🚀.

% make testacc PKG=ecr TESTS=TestAccECRReplicationConfiguration_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ecr/... -v -count 1 -parallel 20 -run='TestAccECRReplicationConfiguration_' -timeout 180m
=== RUN   TestAccECRReplicationConfiguration_serial
=== RUN   TestAccECRReplicationConfiguration_serial/repositoryFilter
=== RUN   TestAccECRReplicationConfiguration_serial/basic
--- PASS: TestAccECRReplicationConfiguration_serial (73.95s)
    --- PASS: TestAccECRReplicationConfiguration_serial/repositoryFilter (38.03s)
    --- PASS: TestAccECRReplicationConfiguration_serial/basic (35.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ecr	77.842s

[ewbankkit]

@sjonpaulbrown Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v3.71.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.