-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add associated resource ARNs to aws_ram_resource_share
data source
#22591
Add associated resource ARNs to aws_ram_resource_share
data source
#22591
Conversation
Based on implementation in resource_share_accepter.go Closes hashicorp#21159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @nicolaei 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
would be great to see this merged |
@nicolaei fix the merge conflicts. It would be great to see this merged in. |
…are-add-data-to-data-source # Conflicts: # internal/service/ram/resource_share_data_source_test.go # website/docs/d/ram_resource_share.html.markdown
The PR should be good to go again now 👌 |
# Conflicts: # internal/service/ram/resource_share_data_source.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccRAMResourceShareDataSource_' PKG=ram ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ram/... -v -count 1 -parallel 2 -run=TestAccRAMResourceShareDataSource_ -timeout 180m
=== RUN TestAccRAMResourceShareDataSource_basic
=== PAUSE TestAccRAMResourceShareDataSource_basic
=== RUN TestAccRAMResourceShareDataSource_tags
=== PAUSE TestAccRAMResourceShareDataSource_tags
=== RUN TestAccRAMResourceShareDataSource_resources
=== PAUSE TestAccRAMResourceShareDataSource_resources
=== RUN TestAccRAMResourceShareDataSource_status
=== PAUSE TestAccRAMResourceShareDataSource_status
=== CONT TestAccRAMResourceShareDataSource_basic
=== CONT TestAccRAMResourceShareDataSource_resources
--- PASS: TestAccRAMResourceShareDataSource_basic (27.87s)
=== CONT TestAccRAMResourceShareDataSource_status
--- PASS: TestAccRAMResourceShareDataSource_resources (38.88s)
=== CONT TestAccRAMResourceShareDataSource_tags
--- PASS: TestAccRAMResourceShareDataSource_status (25.92s)
--- PASS: TestAccRAMResourceShareDataSource_tags (25.30s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ram 69.634s
@nicolaei Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.13.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Acceptance Testing
Output from acceptance testing:
About This Change
This PR implements the change requested in #21159. The attribute name was chosen based on the attribute from
aws_ram_resource_share_accepter
.I'm also quite new to go, so if I'm missing something that is typical for idiomatic go, I'd love to get some feedback on that 😄
Closes #21159.
Closes #29547.
Closes #28927.