Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Route53 Auto Naming #2561

Closed
atsushi-ishibashi opened this issue Dec 6, 2017 · 5 comments
Closed

Support Route53 Auto Naming #2561

atsushi-ishibashi opened this issue Dec 6, 2017 · 5 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource.
Milestone

Comments

@atsushi-ishibashi
Copy link
Contributor

Required: [email protected]
https://aws.amazon.com/about-aws/whats-new/2017/12/amazon-route-53-releases-auto-naming-api-name-service-management/

@apparentlymart
Copy link
Contributor

apparentlymart commented Dec 19, 2017

Hi @atsushi-ishibashi! Thanks for this feature request.

I took a quick look at the documentation for this new feature. It looks like the following new resource types would achieve support for this:

In practice, I suspect that many users will not use Terraform for RegisterInstance and DeregisterInstance because this would instead be done using EC2 autoscaling lifecycle hooks (or equivalent for ECS, etc) to dynamically adapt as instances come and go, but they seem simple enough that it wouldn't hurt to implement them for cases where EC2 instances and other network-accessible services (ELBs, etc) are statically allocated.

Does the above cover the use-cases that people want to achieve with this?

The Terraform team at HashiCorp won't be able to work on this in the near future due to our focus being elsewhere, but we'd be happy to review a pull request if you or someone else has the time and motivation to implement it. Alternatively, if others would also like to see this implemented I'd encourage adding additional 👍 upvote reactions to the original issue comment (not to this comment), which we use as one of the inputs to prioritize work for the Terraform team.

@apparentlymart apparentlymart added enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource. labels Dec 19, 2017
@atsushi-ishibashi
Copy link
Contributor Author

atsushi-ishibashi commented Dec 19, 2017

@apparentlymart I implemented #2569 #2589 which are merged and #2613 is waiting for review👍

@atsushi-ishibashi
Copy link
Contributor Author

atsushi-ishibashi commented Dec 19, 2017

But I applied aws_service_discovery_ to name.

@bflad bflad added this to the v1.7.0 milestone Jan 12, 2018
@ghost
Copy link

ghost commented Apr 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource.
Projects
None yet
Development

No branches or pull requests

3 participants