[Bug]: CognitoUserPoolClient CallbackUrls is marked as computed

[andrewbaxter]

Terraform Core Version

any

AWS Provider Version

master

Affected Resource(s)

CognitoUserPoolClient

Expected Behavior

CallbackUrls (and LogoutUrls actually) should not be computed. These are both user specified during creation and update, and are not provided by AWS.

Actual Behavior

Both are marked as computed.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

None

Steps to Reproduce

None

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

#20065 - set as computed here, but doesn't seem relevant to the PR

Would you like to implement a fix?

No response

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[andrewbaxter]

I couldn't find any reference for why this was changed. I'm happy to undo the change if it would get this out faster.

API docs https://docs.aws.amazon.com/cognito-user-identity-pools/latest/APIReference/API_CreateUserPoolClient.html

I triple checked the documentation on Computed to make sure I wasn't missing anything, but let me know if I misunderstood this field.

[DrFaust92]

they are now also computed, not just computed. you can still set those values. as they are also optional.

[andrewbaxter]

Okay I searched around and I do see specific mentions of optional+computed in various other places, so I think you're right. But I can't find any documentation regarding what it actually means.

This only implicitly allows it, and offers no description of what it might mean.

It's confirmed to be allowed here: hashicorp/terraform-plugin-framework#31

[andrewbaxter]

So I guess

• Required -> Provided by user
• Optional -> Provided by user
• Computed -> provided by upstream
• Computed + optional -> Provided by user, but filled in with non-default/empty value by upstream if not provided by user

It would be nice to see an official enumeration but I think this is resolved. Thanks! I had no idea optional+computed was a special case.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.