-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add asset_id field to ec2_host #32388
Conversation
Community NoteVoting for Prioritization
For Submitters
|
@ewbankkit - any chance you can review this one? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEC2HostDataSource_\|TestAccEC2Host_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccEC2HostDataSource_\|TestAccEC2Host_ -timeout 180m
=== RUN TestAccEC2HostDataSource_basic
=== PAUSE TestAccEC2HostDataSource_basic
=== RUN TestAccEC2HostDataSource_filter
=== PAUSE TestAccEC2HostDataSource_filter
=== RUN TestAccEC2Host_basic
=== PAUSE TestAccEC2Host_basic
=== RUN TestAccEC2Host_disappears
=== PAUSE TestAccEC2Host_disappears
=== RUN TestAccEC2Host_instanceFamily
=== PAUSE TestAccEC2Host_instanceFamily
=== RUN TestAccEC2Host_tags
=== PAUSE TestAccEC2Host_tags
=== RUN TestAccEC2Host_outpostAssetId
=== PAUSE TestAccEC2Host_outpostAssetId
=== RUN TestAccEC2Host_outpost
=== PAUSE TestAccEC2Host_outpost
=== CONT TestAccEC2HostDataSource_basic
=== CONT TestAccEC2Host_outpost
acctest.go:1104: skipping since no Outposts found
--- SKIP: TestAccEC2Host_outpost (1.09s)
=== CONT TestAccEC2Host_outpostAssetId
acctest.go:1104: skipping since no Outposts found
--- SKIP: TestAccEC2Host_outpostAssetId (0.17s)
=== CONT TestAccEC2Host_tags
--- PASS: TestAccEC2HostDataSource_basic (26.02s)
=== CONT TestAccEC2Host_instanceFamily
acctest.go:1418: skipping test for aws/us-west-2: Error running apply: exit status 1
Error: allocating EC2 Host: HostLimitExceeded: The number of Dedicated hosts you've requested (1) would bring your total up to 2 for the specified group of instance types (c5). This exceeds your current limit of 2. If you've recently released Dedicated hosts, it may take some time for them to stop counting towards your limit. Try allocating your hosts again after a few minutes. Please visit http://aws.amazon.com/contact-us/ec2-request to request an adjustment to this limit.
status code: 400, request id: 038f9b85-244d-49ac-8dab-92404cfefe7c
with aws_ec2_host.test,
on terraform_plugin_test.tf line 11, in resource "aws_ec2_host" "test":
11: resource "aws_ec2_host" "test" {
--- SKIP: TestAccEC2Host_instanceFamily (14.00s)
=== CONT TestAccEC2Host_disappears
--- PASS: TestAccEC2Host_tags (536.10s)
=== CONT TestAccEC2Host_basic
--- PASS: TestAccEC2Host_basic (1326.72s)
=== CONT TestAccEC2HostDataSource_filter
--- PASS: TestAccEC2HostDataSource_filter (23.30s)
--- PASS: TestAccEC2Host_disappears (1897.55s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 1943.947s
Failure is unrelated to this change.
@silvaalbert Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.9.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Relations
Closes #32132
References
Output from Acceptance Testing