F aws transfer server structured logging destinations

[calvine]

Description

This PR adds support for the AWS Transfer Server Structured Logging Destinations property.

The AWS transfer module talks about this property here

Relations

Closes #32653

References

Here is some sample terraform that uses the new property and shows that the changes work, assuming that you are overriding the aws provider with the version built with this PRs code.

terraform {
  required_providers {
    aws = {
      source = "hashicorp/aws"
    }
  }
}

resource "aws_cloudwatch_log_group" "test" {
  name_prefix = "transfer_test_"
}

data "aws_iam_policy_document" "test" {
  statement {
    effect = "Allow"

    principals {
      type        = "Service"
      identifiers = ["transfer.amazonaws.com"]
    }

    actions = ["sts:AssumeRole"]
  }
}

resource "aws_iam_role" "test" {
  name_prefix         = "iam_for_transfer_"
  assume_role_policy  = data.aws_iam_policy_document.test.json
  managed_policy_arns = ["arn:aws:iam::aws:policy/service-role/AWSTransferLoggingAccess"]
}

resource "aws_transfer_server" "test" {
  endpoint_type = "PUBLIC"
  logging_role  = aws_iam_role.test.arn
  protocols     = ["SFTP"]
  structured_log_destinations = [
    "${aws_cloudwatch_log_group.test.arn}:*"
  ]
}

Output from Acceptance Testing

The acceptance test is working. Was not sure how to get computed value for testing the value in the structured log destinations, so write a function to test using terraform state. Please let me know if there was a better way to do what I wanted to do.

% make testacc TESTS=TestAccTransfer_serial/Server/StructuredLogDestinations PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20 -run='TestAccTransfer_serial/Server/StructuredLogDestinations'  -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/StructuredLogDestinations
--- PASS: TestAccTransfer_serial (246.13s)
    --- PASS: TestAccTransfer_serial/Server (246.13s)
        --- PASS: TestAccTransfer_serial/Server/StructuredLogDestinations (246.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/transfer   246.333s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[calvine]

Sorry I see I have some lint issues. I will get those resolved and push those changes.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/^basic$$' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server/^basic$ -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/basic
--- PASS: TestAccTransfer_serial (208.81s)
    --- PASS: TestAccTransfer_serial/Server (208.81s)
        --- PASS: TestAccTransfer_serial/Server/basic (208.81s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	214.559s

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/^DataSourceBasic$$' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server/^DataSourceBasic$ -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/DataSourceBasic
--- PASS: TestAccTransfer_serial (186.06s)
    --- PASS: TestAccTransfer_serial/Server (186.06s)
        --- PASS: TestAccTransfer_serial/Server/DataSourceBasic (186.06s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	191.781s

% make testacc TESTARGS='-run=TestAccTransfer_serial/Server/^StructuredLogDestinations$$' PKG=transfer
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/transfer/... -v -count 1 -parallel 20  -run=TestAccTransfer_serial/Server/^StructuredLogDestinations$ -timeout 180m
=== RUN   TestAccTransfer_serial
=== PAUSE TestAccTransfer_serial
=== CONT  TestAccTransfer_serial
=== RUN   TestAccTransfer_serial/Server
=== RUN   TestAccTransfer_serial/Server/StructuredLogDestinations
--- PASS: TestAccTransfer_serial (210.04s)
    --- PASS: TestAccTransfer_serial/Server (210.04s)
        --- PASS: TestAccTransfer_serial/Server/StructuredLogDestinations (210.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/transfer	215.460s

[ewbankkit]

@calvine Thanks for the contribution 🎉 👏.

[calvine]

Happy to help @ewbankkit! I use terraform a lot!

[github-actions]

This functionality has been released in v5.10.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.