-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clean Rooms Configured Table resource #33602
Add Clean Rooms Configured Table resource #33602
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCleanRoomsConfiguredTable_' PKG=cleanrooms ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/cleanrooms/... -v -count 1 -parallel 2 -run=TestAccCleanRoomsConfiguredTable_ -timeout 360m
=== RUN TestAccCleanRoomsConfiguredTable_basic
=== PAUSE TestAccCleanRoomsConfiguredTable_basic
=== RUN TestAccCleanRoomsConfiguredTable_disappears
=== PAUSE TestAccCleanRoomsConfiguredTable_disappears
=== RUN TestAccCleanRoomsConfiguredTable_mutableProperties
=== PAUSE TestAccCleanRoomsConfiguredTable_mutableProperties
=== RUN TestAccCleanRoomsConfiguredTable_updateAllowedColumns
=== PAUSE TestAccCleanRoomsConfiguredTable_updateAllowedColumns
=== RUN TestAccCleanRoomsConfiguredTable_updateTableReference
=== PAUSE TestAccCleanRoomsConfiguredTable_updateTableReference
=== RUN TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase
=== PAUSE TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase
=== RUN TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable
=== PAUSE TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable
=== CONT TestAccCleanRoomsConfiguredTable_basic
=== CONT TestAccCleanRoomsConfiguredTable_updateTableReference
--- PASS: TestAccCleanRoomsConfiguredTable_basic (29.91s)
=== CONT TestAccCleanRoomsConfiguredTable_mutableProperties
--- PASS: TestAccCleanRoomsConfiguredTable_updateTableReference (52.21s)
=== CONT TestAccCleanRoomsConfiguredTable_updateAllowedColumns
--- PASS: TestAccCleanRoomsConfiguredTable_mutableProperties (49.59s)
=== CONT TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable
--- PASS: TestAccCleanRoomsConfiguredTable_updateAllowedColumns (51.56s)
=== CONT TestAccCleanRoomsConfiguredTable_disappears
--- PASS: TestAccCleanRoomsConfiguredTable_updateTableReference_onlyTable (50.18s)
=== CONT TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase
--- PASS: TestAccCleanRoomsConfiguredTable_disappears (27.68s)
--- PASS: TestAccCleanRoomsConfiguredTable_updateTableReference_onlyDatabase (49.42s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms 184.668s
@Jolcik Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.19.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
This pull request adds a new resource for AWS Clean Rooms service which is not currently fully supported by the plugin. The change adds Configured Table resource, which is used by the Collaboration to reference AWS Glue tables.
Relations
Relates #30024
References
https://docs.aws.amazon.com/clean-rooms/latest/apireference/API_ConfiguredTable.html
Output from Acceptance Testing