r/aws_verifiedaccess_instance - fips_enabled

[GlennChia]

Description

Adds the fips_enabled (optional, forces new) argument to aws_verifiedaccess_instance

Relations

Relates #29689
Closes #33886

References

Announcement: AWS Verified Access supports FIPS 140-2 compliant endpoints in US and Canada Regions

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccVerifiedAccessInstance_' PKG=ec2 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5  -run=TestAccVerifiedAccessInstance_ -timeout 360m
=== RUN   TestAccVerifiedAccessInstance_basic
=== PAUSE TestAccVerifiedAccessInstance_basic
=== RUN   TestAccVerifiedAccessInstance_description
=== PAUSE TestAccVerifiedAccessInstance_description
=== RUN   TestAccVerifiedAccessInstance_fipsEnabled
=== PAUSE TestAccVerifiedAccessInstance_fipsEnabled
=== RUN   TestAccVerifiedAccessInstance_disappears
=== PAUSE TestAccVerifiedAccessInstance_disappears
=== RUN   TestAccVerifiedAccessInstance_tags
=== PAUSE TestAccVerifiedAccessInstance_tags
=== CONT  TestAccVerifiedAccessInstance_basic
=== CONT  TestAccVerifiedAccessInstance_fipsEnabled
=== CONT  TestAccVerifiedAccessInstance_disappears
=== CONT  TestAccVerifiedAccessInstance_description
=== CONT  TestAccVerifiedAccessInstance_tags
--- PASS: TestAccVerifiedAccessInstance_disappears (38.37s)
--- PASS: TestAccVerifiedAccessInstance_basic (49.18s)
--- PASS: TestAccVerifiedAccessInstance_fipsEnabled (74.65s)
--- PASS: TestAccVerifiedAccessInstance_description (74.82s)
--- PASS: TestAccVerifiedAccessInstance_tags (96.15s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        96.269s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVerifiedAccessInstance_' PKG=ec2 ACCTEST_PARALELLISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVerifiedAccessInstance_ -timeout 360m
=== RUN   TestAccVerifiedAccessInstance_basic
=== PAUSE TestAccVerifiedAccessInstance_basic
=== RUN   TestAccVerifiedAccessInstance_description
=== PAUSE TestAccVerifiedAccessInstance_description
=== RUN   TestAccVerifiedAccessInstance_fipsEnabled
=== PAUSE TestAccVerifiedAccessInstance_fipsEnabled
=== RUN   TestAccVerifiedAccessInstance_disappears
=== PAUSE TestAccVerifiedAccessInstance_disappears
=== RUN   TestAccVerifiedAccessInstance_tags
=== PAUSE TestAccVerifiedAccessInstance_tags
=== CONT  TestAccVerifiedAccessInstance_basic
=== CONT  TestAccVerifiedAccessInstance_disappears
=== CONT  TestAccVerifiedAccessInstance_tags
=== CONT  TestAccVerifiedAccessInstance_description
=== CONT  TestAccVerifiedAccessInstance_fipsEnabled
--- PASS: TestAccVerifiedAccessInstance_disappears (17.76s)
--- PASS: TestAccVerifiedAccessInstance_basic (38.14s)
--- PASS: TestAccVerifiedAccessInstance_description (58.39s)
--- PASS: TestAccVerifiedAccessInstance_fipsEnabled (58.78s)
--- PASS: TestAccVerifiedAccessInstance_tags (74.17s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	79.655s

[ewbankkit]

@GlennChia Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v5.21.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.