-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add KMS Support to Verified Access Group #34055
Feature: Add KMS Support to Verified Access Group #34055
Conversation
Community NoteVoting for Prioritization
For Submitters
|
# Conflicts: # website/docs/r/verifiedaccess_group.html.markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccVerifiedAccessGroup_' PKG=ec2 ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 2 -run=TestAccVerifiedAccessGroup_ -timeout 360m
=== RUN TestAccVerifiedAccessGroup_basic
=== PAUSE TestAccVerifiedAccessGroup_basic
=== RUN TestAccVerifiedAccessGroup_kms
=== PAUSE TestAccVerifiedAccessGroup_kms
=== RUN TestAccVerifiedAccessGroup_updateKMS
=== PAUSE TestAccVerifiedAccessGroup_updateKMS
=== RUN TestAccVerifiedAccessGroup_disappears
=== PAUSE TestAccVerifiedAccessGroup_disappears
=== RUN TestAccVerifiedAccessGroup_tags
=== PAUSE TestAccVerifiedAccessGroup_tags
=== RUN TestAccVerifiedAccessGroup_policy
=== PAUSE TestAccVerifiedAccessGroup_policy
=== RUN TestAccVerifiedAccessGroup_updatePolicy
=== PAUSE TestAccVerifiedAccessGroup_updatePolicy
=== RUN TestAccVerifiedAccessGroup_setPolicy
=== PAUSE TestAccVerifiedAccessGroup_setPolicy
=== CONT TestAccVerifiedAccessGroup_basic
=== CONT TestAccVerifiedAccessGroup_tags
--- PASS: TestAccVerifiedAccessGroup_basic (26.87s)
=== CONT TestAccVerifiedAccessGroup_updatePolicy
--- PASS: TestAccVerifiedAccessGroup_tags (57.49s)
=== CONT TestAccVerifiedAccessGroup_setPolicy
--- PASS: TestAccVerifiedAccessGroup_updatePolicy (45.60s)
=== CONT TestAccVerifiedAccessGroup_updateKMS
--- PASS: TestAccVerifiedAccessGroup_setPolicy (45.75s)
=== CONT TestAccVerifiedAccessGroup_disappears
--- PASS: TestAccVerifiedAccessGroup_updateKMS (48.00s)
=== CONT TestAccVerifiedAccessGroup_policy
--- PASS: TestAccVerifiedAccessGroup_disappears (22.74s)
=== CONT TestAccVerifiedAccessGroup_kms
--- PASS: TestAccVerifiedAccessGroup_policy (26.57s)
--- PASS: TestAccVerifiedAccessGroup_kms (25.87s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 163.080s
@sQu4rks Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds support for customer-managed keys via KMS to the
aws_verifiedaccess_group
resource.Relations
Relates #33297.
Relates #29689.
References
Output from Acceptance Testing