-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[aws_route53_record]: Allow importing with empty record name #34212
Conversation
Community NoteVoting for Prioritization
For Submitters
|
b63e214
to
e708305
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=route53 TESTS=TestAccRoute53Record_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53/... -v -count 1 -parallel 20 -run='TestAccRoute53Record_' -timeout 360m
--- PASS: TestAccRoute53Record_basic (284.28s)
=== CONT TestAccRoute53Record_Allow_overwrite
--- PASS: TestAccRoute53Record_Support_txt (340.69s)
=== CONT TestAccRoute53Record_Allow_doNotOverwrite
--- PASS: TestAccRoute53Record_Support_ds (352.87s)
=== CONT TestAccRoute53Record_MultiValueAnswer_basic
--- PASS: TestAccRoute53Record_Support_caa (354.70s)
=== CONT TestAccRoute53Record_longTXTrecord
--- PASS: TestAccRoute53Record_Support_spf (359.86s)
=== CONT TestAccRoute53Record_empty
--- PASS: TestAccRoute53Record_generatesSuffix (385.51s)
=== CONT TestAccRoute53Record_Alias_changeDualstack
--- PASS: TestAccRoute53Record_Latency_basic (410.73s)
=== CONT TestAccRoute53Record_Alias_change
--- PASS: TestAccRoute53Record_Geolocation_basic (440.53s)
=== CONT TestAccRoute53Record_SetIdentifierRename_weighted
--- PASS: TestAccRoute53Record_setIdentifierChangeBasicToWeighted (473.76s)
=== CONT TestAccRoute53Record_SetIdentifierRename_multiValueAnswer
--- PASS: TestAccRoute53Record_typeChange (488.55s)
=== CONT TestAccRoute53Record_WeightedToSimple_basic
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySpecified (490.14s)
=== CONT TestAccRoute53Record_Alias_s3
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationContinent (492.16s)
=== CONT TestAccRoute53Record_Alias_elb
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountrySubdivision (495.23s)
=== CONT TestAccRoute53Record_Weighted_basic
--- PASS: TestAccRoute53Record_SetIdentifierRename_latency (503.35s)
=== CONT TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault
--- PASS: TestAccRoute53Record_nameChange (534.33s)
=== CONT TestAccRoute53Record_Weighted_alias
--- PASS: TestAccRoute53Record_Allow_doNotOverwrite (197.67s)
=== CONT TestAccRoute53Record_cidr
--- PASS: TestAccRoute53Record_wildcard (553.38s)
=== CONT TestAccRoute53Record_failover
--- PASS: TestAccRoute53Record_HealthCheckID_setIdentifierChange (573.93s)
=== CONT TestAccRoute53Record_disappears
--- PASS: TestAccRoute53Record_SetIdentifierRename_failover (576.40s)
=== CONT TestAccRoute53Record_Alias_uppercase
--- PASS: TestAccRoute53Record_longTXTrecord (253.29s)
=== CONT TestAccRoute53Record_fqdn
--- PASS: TestAccRoute53Record_HealthCheckID_typeChange (619.57s)
=== CONT TestAccRoute53Record_trailingPeriodAndZoneID
--- PASS: TestAccRoute53Record_empty (280.39s)
=== CONT TestAccRoute53Record_underscored
--- PASS: TestAccRoute53Record_MultiValueAnswer_basic (306.82s)
=== CONT TestAccRoute53Record_Disappears_multipleRecords
--- PASS: TestAccRoute53Record_Allow_overwrite (408.68s)
--- PASS: TestAccRoute53Record_Weighted_basic (327.92s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_weighted (410.80s)
--- PASS: TestAccRoute53Record_disappears (291.35s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_multiValueAnswer (442.89s)
--- PASS: TestAccRoute53Record_trailingPeriodAndZoneID (300.15s)
--- PASS: TestAccRoute53Record_WeightedToSimple_basic (434.43s)
--- PASS: TestAccRoute53Record_Alias_elb (431.80s)
--- PASS: TestAccRoute53Record_failover (375.34s)
--- PASS: TestAccRoute53Record_Alias_s3 (440.57s)
--- PASS: TestAccRoute53Record_underscored (299.50s)
--- PASS: TestAccRoute53Record_SetIdentifierRename_geolocationCountryDefault (438.32s)
--- PASS: TestAccRoute53Record_Alias_change (548.03s)
--- PASS: TestAccRoute53Record_Alias_uppercase (405.91s)
--- PASS: TestAccRoute53Record_fqdn (391.95s)
--- PASS: TestAccRoute53Record_Alias_changeDualstack (620.19s)
--- PASS: TestAccRoute53Record_Disappears_multipleRecords (353.39s)
--- PASS: TestAccRoute53Record_Alias_vpcEndpoint (1139.41s)
--- PASS: TestAccRoute53Record_cidr (637.89s)
--- PASS: TestAccRoute53Record_Weighted_alias (737.28s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/route53 1274.976s
Thanks for your contribution, @tmccombs! 👍 |
This functionality has been released in v5.25.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Fixes: #4792