Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lexv2models/intent: New resource #34891

Merged
merged 37 commits into from
Jan 17, 2024
Merged

lexv2models/intent: New resource #34891

merged 37 commits into from
Jan 17, 2024

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 12, 2023

Description

Relations

Relates #21375

References

Output from Acceptance Testing

% make t T=TestAccLexV2ModelsIntent_ K=lexv2models 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lexv2models/... -v -count 1 -parallel 20 -run='TestAccLexV2ModelsIntent_'  -timeout 360m
=== RUN   TestAccLexV2ModelsIntent_basic
=== PAUSE TestAccLexV2ModelsIntent_basic
=== RUN   TestAccLexV2ModelsIntent_disappears
=== PAUSE TestAccLexV2ModelsIntent_disappears
=== RUN   TestAccLexV2ModelsIntent_updateConfirmationSetting
=== PAUSE TestAccLexV2ModelsIntent_updateConfirmationSetting
=== RUN   TestAccLexV2ModelsIntent_updateClosingSetting
=== PAUSE TestAccLexV2ModelsIntent_updateClosingSetting
=== RUN   TestAccLexV2ModelsIntent_updateInputContext
=== PAUSE TestAccLexV2ModelsIntent_updateInputContext
=== RUN   TestAccLexV2ModelsIntent_updateInitialResponseSetting
=== PAUSE TestAccLexV2ModelsIntent_updateInitialResponseSetting
=== RUN   TestAccLexV2ModelsIntent_updateFulfillmentCodeHook
=== PAUSE TestAccLexV2ModelsIntent_updateFulfillmentCodeHook
=== RUN   TestAccLexV2ModelsIntent_updateDialogCodeHook
=== PAUSE TestAccLexV2ModelsIntent_updateDialogCodeHook
=== RUN   TestAccLexV2ModelsIntent_updateOutputContext
=== PAUSE TestAccLexV2ModelsIntent_updateOutputContext
=== RUN   TestAccLexV2ModelsIntent_updateSampleUtterance
=== PAUSE TestAccLexV2ModelsIntent_updateSampleUtterance
=== CONT  TestAccLexV2ModelsIntent_basic
=== CONT  TestAccLexV2ModelsIntent_updateOutputContext
=== CONT  TestAccLexV2ModelsIntent_updateInputContext
=== CONT  TestAccLexV2ModelsIntent_updateSampleUtterance
=== CONT  TestAccLexV2ModelsIntent_updateFulfillmentCodeHook
=== CONT  TestAccLexV2ModelsIntent_updateDialogCodeHook
=== CONT  TestAccLexV2ModelsIntent_updateInitialResponseSetting
=== CONT  TestAccLexV2ModelsIntent_disappears
=== CONT  TestAccLexV2ModelsIntent_updateConfirmationSetting
=== CONT  TestAccLexV2ModelsIntent_updateClosingSetting
--- PASS: TestAccLexV2ModelsIntent_disappears (53.08s)
--- PASS: TestAccLexV2ModelsIntent_basic (58.27s)
--- PASS: TestAccLexV2ModelsIntent_updateOutputContext (73.59s)
--- PASS: TestAccLexV2ModelsIntent_updateInputContext (75.23s)
--- PASS: TestAccLexV2ModelsIntent_updateDialogCodeHook (75.35s)
--- PASS: TestAccLexV2ModelsIntent_updateSampleUtterance (76.19s)
--- PASS: TestAccLexV2ModelsIntent_updateClosingSetting (76.88s)
--- PASS: TestAccLexV2ModelsIntent_updateConfirmationSetting (80.56s)
--- PASS: TestAccLexV2ModelsIntent_updateInitialResponseSetting (81.90s)
--- PASS: TestAccLexV2ModelsIntent_updateFulfillmentCodeHook (82.12s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/lexv2models	84.175s

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. generators Relates to code generators. service/lexv2models Issues and PRs that pertain to the lexv2models service. labels Dec 12, 2023
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 12, 2023
@YakDriver YakDriver changed the title lexv2models/intent: New resource [WIP] lexv2models/intent: New resource Dec 13, 2023
@YakDriver YakDriver force-pushed the f-lexv2-intent branch 2 times, most recently from 86097e2 to 22b978a Compare December 20, 2023 19:16
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

@YakDriver YakDriver changed the title [WIP] lexv2models/intent: New resource lexv2models/intent: New resource Jan 17, 2024
GNUmakefile Outdated Show resolved Hide resolved
@ewbankkit
Copy link
Contributor

Needs a CHANGELOG entry.

@YakDriver YakDriver merged commit bd2b577 into main Jan 17, 2024
44 checks passed
@YakDriver YakDriver deleted the f-lexv2-intent branch January 17, 2024 17:05
@github-actions github-actions bot added this to the v5.33.0 milestone Jan 17, 2024
github-actions bot pushed a commit that referenced this pull request Jan 17, 2024
Copy link

This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/lexv2models Issues and PRs that pertain to the lexv2models service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants