[Enhancement]: Add RotateImmediately to aws_secretsmanager_secret_rotation

[sakojun]

Description

aws_secretsmanager_secret_rotation must accept the RotateImmediately parameter.
If this parameter is not specified, immediate rotation will be performed.
The SDK supports this parameter, but Terraform does not.

Affected Resource(s) and/or Data Source(s)

aws_secretsmanager_secret_rotation

Potential Terraform Configuration

resource "aws_secretsmanager_secret_rotation" "example" {
  secret_id           = aws_secretsmanager_secret.example.id
  rotation_lambda_arn = aws_lambda_function.example.arn

  rotate_immediately = false

  rotation_rules {
    automatically_after_days = 30
  }
}

References

https://docs.aws.amazon.com/secretsmanager/latest/apireference/API_RotateSecret.html
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/secretsmanager#Client.RotateSecret
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/secretsmanager#RotateSecretInput

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[galiceau]

Hello

I add my issue because I think that it could be the same topic : disable the password rotation (in AWS secret ) of RDS in terraform. It is only possible from console or API.
In this answer it was precised that "As noted in the aws_secretsmanager_secret resource rotation example, adding rotation_lambda_arn will enable rotation. Removing that argument will disable rotation."
=> It doesn't work.

module "difa-rds" {
  source  = "terraform-aws-modules/rds/aws"
  version = "6.1.0"

}

resource "aws_secretsmanager_secret_rotation" "db_instance_master_user_secret_rotation" {
  secret_id               = module.difa-rds.db_instance_master_user_secret_arn
  rotation_rules {
    automatically_after_days = 30
  } 
}```


regards

[cbhoffman]

I wouldn't mind having a look at this and see if I can get something in to fix.

[github-actions]

This functionality has been released in v5.33.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.