-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protection
attribute to aws_efs_file_system
resource & data resource
#35029
Conversation
Signed-off-by: Yaron Yarimi <[email protected]>
Signed-off-by: Yaron Yarimi <[email protected]>
Signed-off-by: Yaron Yarimi <[email protected]>
Signed-off-by: Yaron Yarimi <[email protected]>
Signed-off-by: Yaron Yarimi <[email protected]>
Signed-off-by: Yaron Yarimi <[email protected]>
Signed-off-by: Yaron Yarimi <[email protected]>
Signed-off-by: Yaron Yarimi <[email protected]>
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccEFSFileSystem_protection\|TestAccEFSFileSystem_basic\|TestAccEFSFileSystemDataSource_id' PKG=efs ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/efs/... -v -count 1 -parallel 2 -run=TestAccEFSFileSystem_protection\|TestAccEFSFileSystem_basic\|TestAccEFSFileSystemDataSource_id -timeout 360m
=== RUN TestAccEFSFileSystemDataSource_id
=== PAUSE TestAccEFSFileSystemDataSource_id
=== RUN TestAccEFSFileSystem_basic
=== PAUSE TestAccEFSFileSystem_basic
=== RUN TestAccEFSFileSystem_protection
=== PAUSE TestAccEFSFileSystem_protection
=== CONT TestAccEFSFileSystemDataSource_id
=== CONT TestAccEFSFileSystem_protection
--- PASS: TestAccEFSFileSystemDataSource_id (25.51s)
=== CONT TestAccEFSFileSystem_basic
--- PASS: TestAccEFSFileSystem_protection (40.61s)
--- PASS: TestAccEFSFileSystem_basic (26.26s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/efs 57.594s
@yaronya Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.32.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
AWS had recently added a new capability to EFS called "replication overwrite protection".
In the API, there' a new FileSytemProtection attribute.
This PR is required in order to complete #34955
Relations
Relates #34863
References
Output from Acceptance Testing