-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for optional KMS key ID in repository resource #35095
Conversation
Community NoteVoting for Prioritization
For Submitters
|
% make testacc TESTARGS='-run=TestAccCodeCommitRepository_kmsKey' PKG=codecommit ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/codecommit/... -v -count 1 -parallel 20 -run=TestAccCodeCommitRepository_kmsKey -timeout 360m === RUN TestAccCodeCommitRepository_kmsKey === PAUSE TestAccCodeCommitRepository_kmsKey === CONT TestAccCodeCommitRepository_kmsKey --- PASS: TestAccCodeCommitRepository_kmsKey (33.42s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/codecommit 44.236s `
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
…dException: Repository trigger branch name list cannot be null' error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCodeCommit' PKG=codecommit ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codecommit/... -v -count 1 -parallel 3 -run=TestAccCodeCommit -timeout 360m
=== RUN TestAccCodeCommitApprovalRuleTemplateAssociation_basic
=== PAUSE TestAccCodeCommitApprovalRuleTemplateAssociation_basic
=== RUN TestAccCodeCommitApprovalRuleTemplateAssociation_disappears
=== PAUSE TestAccCodeCommitApprovalRuleTemplateAssociation_disappears
=== RUN TestAccCodeCommitApprovalRuleTemplateAssociation_Disappears_repository
=== PAUSE TestAccCodeCommitApprovalRuleTemplateAssociation_Disappears_repository
=== RUN TestAccCodeCommitApprovalRuleTemplateDataSource_basic
=== PAUSE TestAccCodeCommitApprovalRuleTemplateDataSource_basic
=== RUN TestAccCodeCommitApprovalRuleTemplate_basic
=== PAUSE TestAccCodeCommitApprovalRuleTemplate_basic
=== RUN TestAccCodeCommitApprovalRuleTemplate_disappears
=== PAUSE TestAccCodeCommitApprovalRuleTemplate_disappears
=== RUN TestAccCodeCommitApprovalRuleTemplate_updateContentAndDescription
=== PAUSE TestAccCodeCommitApprovalRuleTemplate_updateContentAndDescription
=== RUN TestAccCodeCommitApprovalRuleTemplate_updateName
=== PAUSE TestAccCodeCommitApprovalRuleTemplate_updateName
=== RUN TestAccCodeCommitRepositoryDataSource_basic
=== PAUSE TestAccCodeCommitRepositoryDataSource_basic
=== RUN TestAccCodeCommitRepository_basic
=== PAUSE TestAccCodeCommitRepository_basic
=== RUN TestAccCodeCommitRepository_withChanges
=== PAUSE TestAccCodeCommitRepository_withChanges
=== RUN TestAccCodeCommitRepository_CreateDefault_branch
=== PAUSE TestAccCodeCommitRepository_CreateDefault_branch
=== RUN TestAccCodeCommitRepository_CreateAndUpdateDefault_branch
=== PAUSE TestAccCodeCommitRepository_CreateAndUpdateDefault_branch
=== RUN TestAccCodeCommitRepository_tags
=== PAUSE TestAccCodeCommitRepository_tags
=== RUN TestAccCodeCommitRepository_UpdateNameAndTags
=== PAUSE TestAccCodeCommitRepository_UpdateNameAndTags
=== RUN TestAccCodeCommitRepository_kmsKey
=== PAUSE TestAccCodeCommitRepository_kmsKey
=== RUN TestAccCodeCommitTrigger_basic
=== PAUSE TestAccCodeCommitTrigger_basic
=== CONT TestAccCodeCommitApprovalRuleTemplateAssociation_basic
=== CONT TestAccCodeCommitRepository_basic
=== CONT TestAccCodeCommitApprovalRuleTemplate_disappears
--- PASS: TestAccCodeCommitApprovalRuleTemplate_disappears (20.44s)
=== CONT TestAccCodeCommitRepositoryDataSource_basic
--- PASS: TestAccCodeCommitRepository_basic (24.04s)
=== CONT TestAccCodeCommitApprovalRuleTemplate_updateName
--- PASS: TestAccCodeCommitApprovalRuleTemplateAssociation_basic (24.86s)
=== CONT TestAccCodeCommitApprovalRuleTemplate_updateContentAndDescription
--- PASS: TestAccCodeCommitRepositoryDataSource_basic (19.80s)
=== CONT TestAccCodeCommitApprovalRuleTemplateDataSource_basic
--- PASS: TestAccCodeCommitApprovalRuleTemplateDataSource_basic (18.61s)
=== CONT TestAccCodeCommitApprovalRuleTemplateAssociation_Disappears_repository
--- PASS: TestAccCodeCommitApprovalRuleTemplate_updateName (38.35s)
=== CONT TestAccCodeCommitApprovalRuleTemplate_basic
--- PASS: TestAccCodeCommitApprovalRuleTemplate_updateContentAndDescription (37.79s)
=== CONT TestAccCodeCommitRepository_tags
--- PASS: TestAccCodeCommitApprovalRuleTemplateAssociation_Disappears_repository (20.87s)
=== CONT TestAccCodeCommitTrigger_basic
--- PASS: TestAccCodeCommitApprovalRuleTemplate_basic (23.94s)
=== CONT TestAccCodeCommitRepository_kmsKey
--- PASS: TestAccCodeCommitTrigger_basic (21.11s)
=== CONT TestAccCodeCommitRepository_UpdateNameAndTags
--- PASS: TestAccCodeCommitRepository_tags (64.50s)
=== CONT TestAccCodeCommitRepository_CreateDefault_branch
--- PASS: TestAccCodeCommitRepository_kmsKey (44.22s)
=== CONT TestAccCodeCommitApprovalRuleTemplateAssociation_disappears
--- PASS: TestAccCodeCommitRepository_UpdateNameAndTags (45.29s)
=== CONT TestAccCodeCommitRepository_CreateAndUpdateDefault_branch
--- PASS: TestAccCodeCommitRepository_CreateDefault_branch (24.85s)
=== CONT TestAccCodeCommitRepository_withChanges
--- PASS: TestAccCodeCommitApprovalRuleTemplateAssociation_disappears (21.93s)
--- PASS: TestAccCodeCommitRepository_CreateAndUpdateDefault_branch (35.18s)
--- PASS: TestAccCodeCommitRepository_withChanges (32.60s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/codecommit 195.312s
@obounaim Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.34.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add support for optional KMS key ID in repository resource
Relations
Closes #35040
References
Announcing Customer Managed Key (CMK) support in AWS CodeCommit
Go SDK CreateRepository
Go SDK UpdateRepositoryEncryptionKey
AWS Key Management Service and encryption for AWS CodeCommit repositories