[Bug]: RDS PITR support for a new instance passwords

[kolvin]

Terraform Core Version

1.5.5

AWS Provider Version

5.34.0

Affected Resource(s)

aws_db_instance

nested block: restore_to_point_in_time

Expected Behavior

When restoring an instance via var.point_in_time_recovery. I expect the new instance to respect the value defined in var.password.

Note: This behavior already exists for instance restores via var.snapshot_identifier.

Actual Behavior

Instances restored via var.point_in_time_recovery are only accessible when using the original password from the source database regardless of the value defined in var.password.

Relevant Error/Panic Output Snippet

The instance restore completes fine, so no errors to share

Terraform Configuration Files

Terraform configuration for creating a postgres instance - https://github.com/terraform-aws-modules/terraform-aws-rds/blob/master/examples/complete-postgres/main.tf

Steps to Reproduce

1. Create a source postgres database via terraform-aws-rds community module
2. Validate instance is online and has a LatestRestorableTime available

  aws rds describe-db-instances \
  --db-instance-identifier $INSTANCE_IDENTIFIER \
  --query 'DBInstances[0].LatestRestorableTime' \
  --output text
}

4. Instantiate a new module call for our restored instance.
5. Reference our source database identifier and restore timestamp as input variables
6. Change the password for the new instance. var.password
7. Deploy new instance via plan+apply
8. Attempt to connect to the new restored instance

Debug Output

No response

Panic Output

No response

Important Factoids

• I am using aws_db_instance indirectly via the community module
  • https://github.com/terraform-aws-modules/terraform-aws-rds/tree/master/modules/db_instance
• I am using terragrunt to generate boilerplate terraform configuration(provider, backend etc) for multi-account setups

References

Inspecting the source code of this repo validated the behavior I'm experiencing

• Snapshot restore operations DO pass through the value of var.password to the API call
• Point-in-time recovery operations DO NOT pass through the value var.password to the API call

---

The official docs listed here validate

1. Point-in-time recovery operations creates a new instance
2. The AWS RDS API for creating Instances accepts a password value.

• AWS Docs on PITR
• RDS API CreateDBInstance - Available settings

Screenshots

• 
• 

Would you like to implement a fix?

Yes

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[github-actions]

This functionality has been released in v5.36.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.