Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_devopsguru_notification_channel: new resource #36557

Merged
merged 2 commits into from
Mar 25, 2024
Merged

r/aws_devopsguru_notification_channel: new resource #36557

merged 2 commits into from
Mar 25, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Mar 25, 2024

Description

This resource will allow practitioners to manage AWS DevOps Guru notification channels with Terraform.

Thing change also adds AutoFlex support for "list of enum" fields.

Relations

Relates #17919
Closes #36334

Closes #36556

References

Output from Acceptance Testing

% make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/NotificationChannel
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/NotificationChannel'  -timeout 360m

--- PASS: TestAccDevOpsGuru_serial (38.51s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannel (38.51s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/basic (14.01s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/disappears (11.41s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/filters (13.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 43.970s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/devopsguru Issues and PRs that pertain to the devopsguru service. labels Mar 25, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 25, 2024
johnsonaj
johnsonaj approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/NotificationChannel
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/NotificationChannel'  -timeout 360m
=== RUN   TestAccDevOpsGuru_serial
=== PAUSE TestAccDevOpsGuru_serial
=== CONT  TestAccDevOpsGuru_serial
=== RUN   TestAccDevOpsGuru_serial/NotificationChannel
=== RUN   TestAccDevOpsGuru_serial/NotificationChannel/basic
=== RUN   TestAccDevOpsGuru_serial/NotificationChannel/disappears
=== RUN   TestAccDevOpsGuru_serial/NotificationChannel/filters
--- PASS: TestAccDevOpsGuru_serial (37.17s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannel (37.17s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/basic (13.80s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/disappears (10.90s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/filters (12.47s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru	43.431s

johnsonaj
johnsonaj reviewed Mar 25, 2024
View reviewed changes
internal/framework/flex/auto_expand.go
vTo.Set(reflect.ValueOf(to))
// Copy elements individually to enable expansion of lists of
// custom string types (AWS enums)
vals := reflect.MakeSlice(vTo.Type(), len(to), len(to))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@johnsonaj
Copy link
Contributor

needs CHANGELOG entry

@jar-b
internal/framework/flex: support list of enums
7b6a69c 
This change to the auto expander logic allows for the underlying type to be preserved when the target is a list of custom string types (ie. AWS enums).
@jar-b jar-b force-pushed the f-devopsguru_notification_channel branch from bd4aac0 to 60a449b Compare March 25, 2024 17:17
@jar-b
r/aws_devopsguru_notification_channel: new resource
385142f 
This resource will allow practitioners to manage AWS DevOps Guru notification channels with Terraform.

```console
% make testacc PKG=devopsguru TESTS=TestAccDevOpsGuru_serial/NotificationChannel
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/devopsguru/... -v -count 1 -parallel 20 -run='TestAccDevOpsGuru_serial/NotificationChannel'  -timeout 360m

--- PASS: TestAccDevOpsGuru_serial (38.51s)
    --- PASS: TestAccDevOpsGuru_serial/NotificationChannel (38.51s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/basic (14.01s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/disappears (11.41s)
        --- PASS: TestAccDevOpsGuru_serial/NotificationChannel/filters (13.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/devopsguru 43.970s
```
@jar-b jar-b force-pushed the f-devopsguru_notification_channel branch from 60a449b to 385142f Compare March 25, 2024 17:51
@jar-b jar-b merged commit f9f2e6b into main Mar 25, 2024
44 checks passed
@jar-b jar-b deleted the f-devopsguru_notification_channel branch March 25, 2024 18:40
@github-actions github-actions bot added this to the v5.43.0 milestone Mar 25, 2024
github-actions bot pushed a commit that referenced this pull request Mar 25, 2024
Update CHANGELOG.md for #36557
7845a0b
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Mar 28, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.43.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@jar-b jar-b restored the f-devopsguru_notification_channel branch March 29, 2024 18:09
@jar-b jar-b deleted the f-devopsguru_notification_channel branch April 8, 2024 20:37
@jar-b jar-b mentioned this pull request Apr 8, 2024
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. service/devopsguru Issues and PRs that pertain to the devopsguru service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.43.0
Development

Successfully merging this pull request may close these issues.

[TechDebt]: Add AutoFlex support for lists of enum types [New Resource]: aws_devopsguru_notification_channel
2 participants
@jar-b @johnsonaj