[Enhancement]: rename aws_cloudfrontkeyvaluestore_key

[camilbinas]

Description

The aws_cloudfrontkeyvaluestore_key resource currently doesn't align with the naming convention of other Cloudfront resources. It should be named "aws_cloudfront_key_value_store_key". Also the resource is located in a separate navigation group in the documentation: "CloudFront KeyValueStore" instead of "CloudFront" which makes it harder to find the example.

Affected Resource(s) and/or Data Source(s)

aws_cloudfrontkeyvaluestore_key

Potential Terraform Configuration

resource "aws_cloudfront_key_value_store" "example" {
  name    = "ExampleKeyValueStore"
  comment = "This is an example key value store"
}

resource "aws_cloudfront_key_value_store_key" "example" {
  key_value_store_arn = aws_cloudfront_key_value_store.example.arn
  key                 = "Test Key"
  value               = "Test Value"
}

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[justinretzolk]

Hey @camilbinas 👋 Thank you for taking the time to raise this! While we acknowledge that one might initially expect this resource to be named aws_cloudfront_key_value_store_key, naming it aws_cloudfrontkeyvaluestore_key more closely matches the SDK and underlying API:

• aws_cloudfront_* resources use the cloudfront package (related API documentation)
• aws_cloudfrontkeyvaluestore_* use the cloudfrontkeyvaluestore package (related API documentation)

Following the API/SDK as closely as possible is one of the provider design principles, and something we try to do where possible (for another example, see aws_servicecatalogappregistry_application). With that in mind, I'm going to close this issue.

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.