Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Tagging support for aws_iot_authorizer #36834

Closed
PeterBurner opened this issue Apr 10, 2024 · 6 comments · Fixed by #37152
Closed

[Enhancement]: Tagging support for aws_iot_authorizer #36834

PeterBurner opened this issue Apr 10, 2024 · 6 comments · Fixed by #37152
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service.
Milestone

Comments

@PeterBurner
Copy link

PeterBurner commented Apr 10, 2024

Terraform Core Version

1.7.5

AWS Provider Version

5.44.0

Affected Resource(s)

  • aws_iot_authorizer

Expected Behavior

Resource block should accept tags property.

Actual Behavior

Resource block does not accept tags property.

Relevant Error/Panic Output Snippet

│ Error: Unsupported argument
│ 
│   on main.tf line 115, in resource "aws_iot_authorizer" "this":
│  115:   tags = {
│ 
│ An argument named "tags" is not expected here.

Terraform Configuration Files

resource "aws_iot_authorizer" "this" {
  authorizer_function_arn = module.custom_authorizer.lambda_function_arn
  enable_caching_for_http = true
  name                    = "authorizer"
  signing_disabled        = true
  status                  = "ACTIVE"

  tags = { test = "blaaa" }
}

Steps to Reproduce

  1. Add tags property to resource block
  2. Run terraform plan

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

Would you like to implement a fix?

No

@PeterBurner PeterBurner added the bug Addresses a defect in current functionality. label Apr 10, 2024
@github-actions github-actions bot added the service/iot Issues and PRs that pertain to the iot service. label Apr 10, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 10, 2024
@justinretzolk
Copy link
Member

Hey @PeterBurner 👋 Thanks for taking the time to raise this! We consider additions to existing resources to be an enhancement, rather than a bug. With that in mind, I'm going to update a few things about this issue. There's no further action needed from you at this point, I just like to let people know before making these kinds of modifications.

@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. needs-triage Waiting for first response or review from a maintainer. labels Apr 15, 2024
@justinretzolk justinretzolk changed the title [Bug]: IoT Authorizer Can Not Be Tagged [Enhancement]: Tagging support for aws_iot_authorizer Apr 15, 2024
@DanielRieske
Copy link
Contributor

DanielRieske commented Apr 29, 2024

👋 I'll gladly pick this up as part of the IoT SDKv2 migration.

Copy link

github-actions bot commented Jul 2, 2024

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

Copy link

github-actions bot commented Jul 5, 2024

This functionality has been released in v5.57.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Aug 7, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/iot Issues and PRs that pertain to the iot service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants