-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Alarm Specification feature to auto scaling groups instance refresh preferences #36954
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @sidyashwanth 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
@ewbankkit Hey sorry, I think I overwrote your changes just now. Please re-push. I'll keep off from now on unless you need me to do something. |
# Conflicts: # internal/service/autoscaling/group.go # internal/service/autoscaling/group_test.go # website/docs/r/autoscaling_group.html.markdown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccAutoScalingGroup_InstanceRefresh_\|TestAccAutoScalingGroup_basic' PKG=autoscaling ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/autoscaling/... -v -count 1 -parallel 3 -run=TestAccAutoScalingGroup_InstanceRefresh_\|TestAccAutoScalingGroup_basic -timeout 360m
=== RUN TestAccAutoScalingGroup_basic
=== PAUSE TestAccAutoScalingGroup_basic
=== RUN TestAccAutoScalingGroup_InstanceRefresh_basic
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_basic
=== RUN TestAccAutoScalingGroup_InstanceRefresh_start
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_start
=== RUN TestAccAutoScalingGroup_InstanceRefresh_triggers
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_triggers
=== RUN TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_autoRollback
=== RUN TestAccAutoScalingGroup_InstanceRefresh_alarmSpecification
=== PAUSE TestAccAutoScalingGroup_InstanceRefresh_alarmSpecification
=== CONT TestAccAutoScalingGroup_basic
=== CONT TestAccAutoScalingGroup_InstanceRefresh_triggers
=== CONT TestAccAutoScalingGroup_InstanceRefresh_alarmSpecification
--- PASS: TestAccAutoScalingGroup_basic (66.46s)
=== CONT TestAccAutoScalingGroup_InstanceRefresh_autoRollback
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_triggers (217.55s)
=== CONT TestAccAutoScalingGroup_InstanceRefresh_start
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_alarmSpecification (220.59s)
=== CONT TestAccAutoScalingGroup_InstanceRefresh_basic
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_autoRollback (193.95s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_start (214.80s)
--- PASS: TestAccAutoScalingGroup_InstanceRefresh_basic (351.22s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/autoscaling 586.479s
@sidyashwanth Thanks for the contribution 🎉 👏. |
@ewbankkit thanks for prioritising and approving. Hope to see it in the next version soon. |
This functionality has been released in v5.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Add AlarmSpecification feature to auto scaling groups instance refresh preferences.
References
https://docs.aws.amazon.com/autoscaling/ec2/userguide/instance-refresh-rollback.html#instance-refresh-using-auto-rollback
Closes #34662.