-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_rds_cluster: Wait for no pending modified values on Update if apply_immediately
is true
#38437
Conversation
…apply_immediately' is true.
% make testacc TESTARGS='-run=TestAccRDSCluster_allowMajorVersionUpgrade' PKG=rds make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.5 test ./internal/service/rds/... -v -count 1 -parallel 20 -run=TestAccRDSCluster_allowMajorVersionUpgrade -timeout 360m === RUN TestAccRDSCluster_allowMajorVersionUpgrade === PAUSE TestAccRDSCluster_allowMajorVersionUpgrade === RUN TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately === PAUSE TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately === RUN TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm === PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm === RUN TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters === PAUSE TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters === CONT TestAccRDSCluster_allowMajorVersionUpgrade === CONT TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm === CONT TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters === CONT TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately --- PASS: TestAccRDSCluster_allowMajorVersionUpgradeNoApplyImmediately (1283.81s) --- PASS: TestAccRDSCluster_allowMajorVersionUpgrade (1924.24s) --- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParametersApplyImm (2250.30s) --- PASS: TestAccRDSCluster_allowMajorVersionUpgradeWithCustomParameters (2315.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/rds 2320.945s
Community NoteVoting for Prioritization
For Submitters
|
Thank you for your contribution! 🚀 Please note that typically Go dependency changes are handled in this repository by dependabot or the maintainers. This is to prevent pull request merge conflicts and further delay reviews of contributions. Remove any changes to the Additional details:
|
Thank you for your contribution! 🚀 A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored. For additional information refer to the AWS SDK for Go Versions page in the contributor guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
apply_immediately
is true
apply_immediately
is true
This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
When waiting for
aws_rds_cluster
to update andapply_immediately
istrue
, ensure that there are no pending modified values if the cluster's status isavailable
.I think we will need to do the same for
aws_rds_cluster_instance
andaws_db_instance
to resolve e.g. #31529.Relations
Closes #28339.
Output from Acceptance Testing