Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: aws_vpc_ipam_pool_cidr_allocation cannot be imported with description argument without replacement #38613

Closed
GlennChia opened this issue Jul 31, 2024 · 4 comments · Fixed by #38618
Labels
bug Addresses a defect in current functionality. service/ipam Issues and PRs that pertain to the ipam service.
Milestone

Comments

@GlennChia
Copy link
Collaborator

GlennChia commented Jul 31, 2024

Terraform Core Version

1.9.1

AWS Provider Version

5.60.0

Affected Resource(s)

aws_vpc_ipam_pool_cidr_allocation

Expected Behavior

When importing an IPAM Allocation that has been created with a description we expect that the resource will be imported without replacement

Actual Behavior

Terraform is not able to import with the description without replacement. When a description is specified, Terraform shows 1 to import, 1 to add, 0 to change, 1 to destroy. This is because the resource does not write computed description to state and as a result, a specified description has a value that differs from null in state. Since description is a force_new argument, Terraform attempts to delete the IPAM allocation and recreate it.

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

terraform {
  required_providers {
    aws = {
      source  = "hashicorp/aws"
      version = "5.60.0"
    }
  }
}

provider "aws" {
  region = "ap-southeast-1"
}

import {
  to = aws_vpc_ipam_pool_cidr_allocation.this
  id = "ipam-pool-alloc-id_ipam-pool-id"
}

resource "aws_vpc_ipam_pool_cidr_allocation" "this" {
  ipam_pool_id = "ipam-pool-id"
  cidr         = "10.0.0.0/23"
  description  = "example description"
}

Steps to Reproduce

Step 1: Create an IPAM allocation in the AWS Console. At a high-level, create an IPAM -> Create an IPAM Pool in the default scope -> Create an IPAM Allocation in the IPAM pool. Create this IPAM with a description

Step 2: Import the IPAM Allocation in Terraform with the code above

Terraform displays the following

Terraform will perform the following actions:

  # aws_vpc_ipam_pool_cidr_allocation.this must be replaced
  # (imported from "ipam-pool-alloc-id_ipam-pool-id")
  # Warning: this will destroy the imported resource
-/+ resource "aws_vpc_ipam_pool_cidr_allocation" "this" {
        cidr                    = "10.0.0.0/23"
      + description             = "example description" # forces replacement
      ~ id                      = "ipam-pool-alloc-id_ipam-pool-id" -> (known after apply)
      ~ ipam_pool_allocation_id = "ipam-pool-alloc-id" -> (known after apply)
        ipam_pool_id            = "ipam-pool-id"
      + resource_id             = (known after apply)
      ~ resource_owner          = "111122223333" -> (known after apply)
      ~ resource_type           = "custom" -> (known after apply)
    }

Plan: 1 to import, 1 to add, 0 to change, 1 to destroy.

Reason: The provider does not read the description, as a result, it shows as a null in the state

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

Would you like to implement a fix?

Yes

@GlennChia GlennChia added the bug Addresses a defect in current functionality. label Jul 31, 2024
@github-actions github-actions bot added the service/ipam Issues and PRs that pertain to the ipam service. label Jul 31, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 31, 2024
@GlennChia GlennChia changed the title [Bug]: aws_vpc_ipam_pool_cidr_allocation cannot be imported with description argument [Bug]: aws_vpc_ipam_pool_cidr_allocation cannot be imported with description argument without replacement Jul 31, 2024
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jul 31, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.61.0 milestone Jul 31, 2024
Copy link

github-actions bot commented Aug 2, 2024

This functionality has been released in v5.61.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Sep 1, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ipam Issues and PRs that pertain to the ipam service.
Projects
None yet
2 participants