Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support for new direct to Iceberg streaming destination for aws_kinesis_firehose_delivery_stream #38753

Closed
paulcichonski opened this issue Aug 7, 2024 · 5 comments · Fixed by #38098
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Milestone

Comments

@paulcichonski
Copy link

paulcichonski commented Aug 7, 2024

Description

AWS released a new feature of Data Firehose in July 2024 (in Preview) to support writing directly to Iceberg tables.

This issue is to request that the aws_kinesis_firehose_delivery_stream resource be updated to support this new destination configuration.

Affected Resource(s) and/or Data Source(s)

aws_kinesis_firehose_delivery_stream

Potential Terraform Configuration

resource "aws_kinesis_firehose_delivery_stream" "example_iceberg_destination" {
  name        = "example_iceberg_destination"
  destination = "iceberg"

  iceberg_destination_configuration {
    glue_catalog_arn = "string"
    role_arn   = "string"

    buffering_size     = 10
    buffering_interval = 300

    processing_configuration {
      enabled = "true"

      processors {
        type = "Lambda"

        parameters {
          parameter_name  = "LambdaArn"
          parameter_value = "${aws_lambda_function.lambda_processor.arn}:$LATEST"
        }
      }
    }

    destination_table_configuration {
      destination_tables = [
        {
          destination_database_name = "string"
          destination_table_name = "string"
          s3_error_output_prefix = "string"
          unique_keys = ["string"]
        }
      ]
    }

    retry_options {
      duration_in_seconds = 100
    }

    s3_backup_mode = "FailedDataOnly"
    s3_configuration {
      role_arn            = "string"
      bucket_arn          = "string"
      prefix              = "string"
      error_output_prefix = "string"
      buffering_hints {
        size_in_mbs         = 10
        interval_in_seconds = 300
      }
      compression_format = "UNCOMPRESSED"
      encryption_configuration {
        no_encryption_config = "NoEncryption"
        kms_encryption_config {
          aws_kms_key_arn = "string"
        }
      }
      cloud_watch_logging_options {
        enabled         = true
        log_group_name  = "string"
        log_stream_name = "string"
      }
    }

  }
}

References

Preview Docs: https://docs.aws.amazon.com/firehose/latest/dev/apache-iceberg-destination.html

I haven't found an official blog post yet.

Would you like to implement a fix?

No

@paulcichonski paulcichonski added the enhancement Requests to existing resources that expand the functionality or scope. label Aug 7, 2024
Copy link

github-actions bot commented Aug 7, 2024

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added the service/firehose Issues and PRs that pertain to the firehose service. label Aug 7, 2024
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Aug 7, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Aug 12, 2024
@tgorton617
Copy link

This Data Firehose feature is now GA - product announcement

Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.73.0 milestone Oct 23, 2024
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/firehose Issues and PRs that pertain to the firehose service.
Projects
None yet
3 participants