-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/aws_cloudformation_stack_set_instance: fix crash during ID construction #38969
Conversation
The create method incorrectly assumed that when `deployment_targets` are provided, organizational unit IDs must be provided in that block, and attempted to use those values in the multi-part key stored for the `id`. This is not the case for self-managed stack sets, which allow `deployment_targets` to be configured with an empty list of organzation unit IDs. The provider will now fall back to `account_id` for this section of the identifier instead.
Previously this error was wrapped by `errs.Must` triggering a crash when a non-nil error is returned. This error is now correctly wrapped in a diagnostic. ```console % make testacc PKG=cloudformation TESTS=TestAccCloudFormationStackSetInstance_ make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... TF_ACC=1 go1.22.6 test ./internal/service/cloudformation/... -v -count 1 -parallel 20 -run='TestAccCloudFormationStackSetInstance_' -timeout 360m === CONT TestAccCloudFormationStackSetInstance_delegatedAdministrator stack_set_instance_test.go:375: skipping test because at least one environment variable of [AWS_ALTERNATE_PROFILE AWS_ALTERNATE_ACCESS_KEY_ID] must be set. Usage: credentials for running acceptance testing in alternate AWS account. --- SKIP: TestAccCloudFormationStackSetInstance_delegatedAdministrator (0.91s) === NAME TestAccCloudFormationStackSetInstance_concurrencyMode stack_set_instance_test.go:339: this AWS account must be the management account of an AWS Organization --- SKIP: TestAccCloudFormationStackSetInstance_concurrencyMode (1.27s) === NAME TestAccCloudFormationStackSetInstance_operationPreferences stack_set_instance_test.go:304: this AWS account must be the management account of an AWS Organization --- SKIP: TestAccCloudFormationStackSetInstance_operationPreferences (5.82s) === NAME TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU stack_set_instance_test.go:258: this AWS account must be the management account of an AWS Organization --- SKIP: TestAccCloudFormationStackSetInstance_DeploymentTargets_emptyOU (6.21s) === NAME TestAccCloudFormationStackSetInstance_deploymentTargets stack_set_instance_test.go:209: this AWS account must be the management account of an AWS Organization --- SKIP: TestAccCloudFormationStackSetInstance_deploymentTargets (14.76s) --- PASS: TestAccCloudFormationStackSetInstance_Disappears_stackSet (67.25s) --- PASS: TestAccCloudFormationStackSetInstance_basic (71.28s) --- PASS: TestAccCloudFormationStackSetInstance_disappears (72.69s) --- PASS: TestAccCloudFormationStackSetInstance_parameterOverrides (123.31s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudformation 132.610s ```
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
This functionality has been released in v5.64.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Fixes a crash caused by incorrect logic used to construct the multi-part key for
id
and improper handling of the error returned from the resource ID constructor helper.Relations
Closes #38846
References
Output from Acceptance Testing