Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for alternative semantic and hierarchical chunking configurations #39138

Merged
merged 7 commits into from
Sep 4, 2024

Conversation

drewtul
Copy link
Contributor

@drewtul drewtul commented Sep 4, 2024

Description

Add support for semantic and hierarchical chunking configurations

Relations

Closes #38670

Output from Acceptance Testing

%  make testacc TESTS=TestAccBedrockAgent_serial/DataSource PKG=bedrockagent
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgent_serial/DataSource'  -timeout 360m
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/DataSource
=== RUN   TestAccBedrockAgent_serial/DataSource/basic
=== RUN   TestAccBedrockAgent_serial/DataSource/disappears
=== RUN   TestAccBedrockAgent_serial/DataSource/full
=== RUN   TestAccBedrockAgent_serial/DataSource/update
=== RUN   TestAccBedrockAgent_serial/DataSource/semantic
=== RUN   TestAccBedrockAgent_serial/DataSource/hierarchical
--- PASS: TestAccBedrockAgent_serial (9596.81s)
    --- PASS: TestAccBedrockAgent_serial/DataSource (9596.81s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/basic (1723.57s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/disappears (1563.96s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/full (1429.06s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/update (1586.57s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/semantic (1541.56s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/hierarchical (1752.08s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       9601.764s

Copy link

github-actions bot commented Sep 4, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Sep 4, 2024
@jar-b jar-b removed the needs-triage Waiting for first response or review from a maintainer. label Sep 4, 2024
@drewtul drewtul marked this pull request as ready for review September 4, 2024 14:59
@drewtul drewtul requested a review from a team as a code owner September 4, 2024 14:59
@jar-b jar-b self-assigned this Sep 4, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 4, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=bedrockagent TESTS=TestAccBedrockAgent_serial/DataSource
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/bedrockagent/... -v -count 1 -parallel 20 -run='TestAccBedrockAgent_serial/DataSource'  -timeout 360m
=== RUN   TestAccBedrockAgent_serial
=== PAUSE TestAccBedrockAgent_serial
=== CONT  TestAccBedrockAgent_serial
=== RUN   TestAccBedrockAgent_serial/DataSource
=== RUN   TestAccBedrockAgent_serial/DataSource/disappears
=== RUN   TestAccBedrockAgent_serial/DataSource/full
=== RUN   TestAccBedrockAgent_serial/DataSource/update
=== RUN   TestAccBedrockAgent_serial/DataSource/semantic
=== RUN   TestAccBedrockAgent_serial/DataSource/hierarchical
=== RUN   TestAccBedrockAgent_serial/DataSource/basic
--- PASS: TestAccBedrockAgent_serial (9496.56s)
    --- PASS: TestAccBedrockAgent_serial/DataSource (9496.56s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/disappears (1474.26s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/full (1478.13s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/update (1570.55s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/semantic (1621.81s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/hierarchical (1630.42s)
        --- PASS: TestAccBedrockAgent_serial/DataSource/basic (1721.37s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/bedrockagent       9502.922s

@jar-b
Copy link
Member

jar-b commented Sep 4, 2024

Thanks for your contribution, @drewtul! 👍

@jar-b jar-b merged commit 0e7f8a7 into hashicorp:main Sep 4, 2024
40 checks passed
@github-actions github-actions bot added this to the v5.66.0 milestone Sep 4, 2024
@drewtul drewtul deleted the f-add-advanced-rag branch September 4, 2024 21:09
Copy link

github-actions bot commented Sep 5, 2024

This functionality has been released in v5.66.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Sep 5, 2024
Copy link

github-actions bot commented Oct 7, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. partner Contribution from a partner. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Update aws_bedrockagent_data_source to support advanced RAG capabilities.
2 participants