Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_lb_listener: Add support for TCP idle timeout for NLB, GWLB listeners #39585

Merged
merged 15 commits into from
Oct 23, 2024
Merged

r/aws_lb_listener: Add support for TCP idle timeout for NLB, GWLB listeners #39585

merged 15 commits into from
Oct 23, 2024

Conversation

ddericco
Copy link
Contributor

@ddericco ddericco commented Oct 3, 2024 •
edited by ewbankkit
Loading

Description

Adds support for TCP idle timeout attribute on aws_lb_listener. This is supported for Network Load Balancer (NLB) listeners using the TCP protocol, and Gateway Load Balancers (GWLB) with the default GENEVE protocol.

Relations

Closes #39149.
Closes #39841.

References

Output from Acceptance Testing

$ make testacc TESTS='TestAccELBV2Listener_attributes_*' PKG=elbv2                                                    
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.7 test ./internal/service/elbv2/... -v -count 1 -parallel 20 -run='TestAccELBV2Listener_attributes_*'  -timeout 360m
=== RUN   TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== PAUSE TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== RUN   TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
=== PAUSE TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
=== CONT  TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== CONT  TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
--- PASS: TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds (187.47s)
--- PASS: TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds (250.42s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/elbv2      256.811s

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/elbv2 Issues and PRs that pertain to the elbv2 service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Oct 3, 2024
@ddericco ddericco marked this pull request as ready for review October 10, 2024 18:49
@ddericco ddericco requested a review from a team as a code owner October 10, 2024 18:49
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 11, 2024
@ewbankkit ewbankkit self-assigned this Oct 22, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 22, 2024
ewbankkit
ewbankkit approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccELBV2Listener_' PKG=elbv2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elbv2/... -v -count 1 -parallel 4  -run=TestAccELBV2Listener_ -timeout 360m
2024/10/22 13:31:15 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2Listener_tags
=== PAUSE TestAccELBV2Listener_tags
=== RUN   TestAccELBV2Listener_tags_null
=== PAUSE TestAccELBV2Listener_tags_null
=== RUN   TestAccELBV2Listener_tags_EmptyMap
=== PAUSE TestAccELBV2Listener_tags_EmptyMap
=== RUN   TestAccELBV2Listener_tags_AddOnUpdate
=== PAUSE TestAccELBV2Listener_tags_AddOnUpdate
=== RUN   TestAccELBV2Listener_tags_EmptyTag_OnCreate
=== PAUSE TestAccELBV2Listener_tags_EmptyTag_OnCreate
=== RUN   TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccELBV2Listener_tags_DefaultTags_providerOnly
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_providerOnly
=== RUN   TestAccELBV2Listener_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_nonOverlapping
=== RUN   TestAccELBV2Listener_tags_DefaultTags_overlapping
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_overlapping
=== RUN   TestAccELBV2Listener_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccELBV2Listener_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccELBV2Listener_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccELBV2Listener_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccELBV2Listener_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccELBV2Listener_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccELBV2Listener_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccELBV2Listener_tags_ComputedTag_OnCreate
=== PAUSE TestAccELBV2Listener_tags_ComputedTag_OnCreate
=== RUN   TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccELBV2Listener_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccELBV2Listener_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccELBV2Listener_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccELBV2Listener_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccELBV2Listener_Application_basic
=== PAUSE TestAccELBV2Listener_Application_basic
=== RUN   TestAccELBV2Listener_Network_basic
=== PAUSE TestAccELBV2Listener_Network_basic
=== RUN   TestAccELBV2Listener_Gateway_basic
=== PAUSE TestAccELBV2Listener_Gateway_basic
=== RUN   TestAccELBV2Listener_disappears
=== PAUSE TestAccELBV2Listener_disappears
=== RUN   TestAccELBV2Listener_Forward_update
=== PAUSE TestAccELBV2Listener_Forward_update
=== RUN   TestAccELBV2Listener_Forward_ingest
=== PAUSE TestAccELBV2Listener_Forward_ingest
=== RUN   TestAccELBV2Listener_Forward_weighted
=== PAUSE TestAccELBV2Listener_Forward_weighted
=== RUN   TestAccELBV2Listener_Forward_tgARNAndForward
=== PAUSE TestAccELBV2Listener_Forward_tgARNAndForward
=== RUN   TestAccELBV2Listener_Forward_TGARNToForward_noChanges
=== PAUSE TestAccELBV2Listener_Forward_TGARNToForward_noChanges
=== RUN   TestAccELBV2Listener_Forward_addStickiness
=== PAUSE TestAccELBV2Listener_Forward_addStickiness
=== RUN   TestAccELBV2Listener_Forward_removeStickiness
=== PAUSE TestAccELBV2Listener_Forward_removeStickiness
=== RUN   TestAccELBV2Listener_Forward_TGARNToForward_weightAndStickiness
=== PAUSE TestAccELBV2Listener_Forward_TGARNToForward_weightAndStickiness
=== RUN   TestAccELBV2Listener_Forward_ToTGARN_noChanges
=== PAUSE TestAccELBV2Listener_Forward_ToTGARN_noChanges
=== RUN   TestAccELBV2Listener_Forward_ToTGARN_weightStickiness
=== PAUSE TestAccELBV2Listener_Forward_ToTGARN_weightStickiness
=== RUN   TestAccELBV2Listener_Forward_addAction
=== PAUSE TestAccELBV2Listener_Forward_addAction
=== RUN   TestAccELBV2Listener_Forward_removeAction
=== PAUSE TestAccELBV2Listener_Forward_removeAction
=== RUN   TestAccELBV2Listener_Forward_ignoreFields
=== PAUSE TestAccELBV2Listener_Forward_ignoreFields
=== RUN   TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== PAUSE TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
=== RUN   TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
=== PAUSE TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
=== RUN   TestAccELBV2Listener_Protocol_upd
=== PAUSE TestAccELBV2Listener_Protocol_upd
=== RUN   TestAccELBV2Listener_backwardsCompatibility
=== PAUSE TestAccELBV2Listener_backwardsCompatibility
=== RUN   TestAccELBV2Listener_Protocol_https
=== PAUSE TestAccELBV2Listener_Protocol_https
=== RUN   TestAccELBV2Listener_mutualAuthentication
=== PAUSE TestAccELBV2Listener_mutualAuthentication
=== RUN   TestAccELBV2Listener_mutualAuthenticationPassthrough
=== PAUSE TestAccELBV2Listener_mutualAuthenticationPassthrough
=== RUN   TestAccELBV2Listener_Gateway_lbARN
=== PAUSE TestAccELBV2Listener_Gateway_lbARN
=== RUN   TestAccELBV2Listener_Protocol_tls
=== PAUSE TestAccELBV2Listener_Protocol_tls
=== RUN   TestAccELBV2Listener_redirect
=== PAUSE TestAccELBV2Listener_redirect
=== RUN   TestAccELBV2Listener_fixedResponse
=== PAUSE TestAccELBV2Listener_fixedResponse
=== RUN   TestAccELBV2Listener_cognito
=== PAUSE TestAccELBV2Listener_cognito
=== RUN   TestAccELBV2Listener_oidc
=== PAUSE TestAccELBV2Listener_oidc
=== RUN   TestAccELBV2Listener_DefaultAction_defaultOrder
=== PAUSE TestAccELBV2Listener_DefaultAction_defaultOrder
=== RUN   TestAccELBV2Listener_DefaultAction_specifyOrder
=== PAUSE TestAccELBV2Listener_DefaultAction_specifyOrder
=== RUN   TestAccELBV2Listener_DefaultAction_actionDisappears
=== PAUSE TestAccELBV2Listener_DefaultAction_actionDisappears
=== RUN   TestAccELBV2Listener_DefaultAction_empty
=== PAUSE TestAccELBV2Listener_DefaultAction_empty
=== RUN   TestAccELBV2Listener_redirectWithTargetGroupARN
=== PAUSE TestAccELBV2Listener_redirectWithTargetGroupARN
=== CONT  TestAccELBV2Listener_tags
=== CONT  TestAccELBV2Listener_Forward_tgARNAndForward
=== CONT  TestAccELBV2Listener_Protocol_https
=== CONT  TestAccELBV2Listener_cognito
--- PASS: TestAccELBV2Listener_Protocol_https (222.78s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccELBV2Listener_Forward_tgARNAndForward (226.97s)
=== CONT  TestAccELBV2Listener_Forward_weighted
--- PASS: TestAccELBV2Listener_cognito (258.22s)
=== CONT  TestAccELBV2Listener_Forward_ingest
--- PASS: TestAccELBV2Listener_tags (281.94s)
=== CONT  TestAccELBV2Listener_Forward_update
--- PASS: TestAccELBV2Listener_tags_DefaultTags_nullOverlappingResourceTag (229.38s)
=== CONT  TestAccELBV2Listener_disappears
--- PASS: TestAccELBV2Listener_Forward_weighted (270.47s)
=== CONT  TestAccELBV2Listener_Gateway_basic
--- PASS: TestAccELBV2Listener_Forward_ingest (262.00s)
=== CONT  TestAccELBV2Listener_Network_basic
--- PASS: TestAccELBV2Listener_Forward_update (253.62s)
=== CONT  TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccELBV2Listener_disappears (234.24s)
=== CONT  TestAccELBV2Listener_tags_ComputedTag_OnCreate
--- PASS: TestAccELBV2Listener_Gateway_basic (190.90s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccELBV2Listener_Network_basic (204.59s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_providerOnly
--- PASS: TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Add (249.41s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccELBV2Listener_tags_ComputedTag_OnCreate (131.74s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccELBV2Listener_tags_DefaultTags_nullNonOverlappingResourceTag (136.83s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccELBV2Listener_tags_DefaultTags_providerOnly (248.85s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccELBV2Listener_tags_DefaultTags_emptyProviderOnlyTag (227.71s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_overlapping
--- PASS: TestAccELBV2Listener_tags_DefaultTags_emptyResourceTag (225.42s)
=== CONT  TestAccELBV2Listener_tags_DefaultTags_nonOverlapping
--- PASS: TestAccELBV2Listener_tags_DefaultTags_updateToResourceOnly (276.39s)
=== CONT  TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccELBV2Listener_tags_DefaultTags_updateToProviderOnly (266.13s)
=== CONT  TestAccELBV2Listener_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccELBV2Listener_tags_DefaultTags_overlapping (318.44s)
=== CONT  TestAccELBV2Listener_Application_basic
--- PASS: TestAccELBV2Listener_tags_ComputedTag_OnUpdate_Replace (247.44s)
=== CONT  TestAccELBV2Listener_tags_EmptyTag_OnCreate
--- PASS: TestAccELBV2Listener_tags_DefaultTags_nonOverlapping (329.68s)
=== CONT  TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccELBV2Listener_tags_IgnoreTags_Overlap_ResourceTag (247.76s)
=== CONT  TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccELBV2Listener_Application_basic (237.34s)
=== CONT  TestAccELBV2Listener_Protocol_tls
--- PASS: TestAccELBV2Listener_tags_EmptyTag_OnCreate (235.74s)
=== CONT  TestAccELBV2Listener_fixedResponse
--- PASS: TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Replace (230.68s)
=== CONT  TestAccELBV2Listener_redirect
--- PASS: TestAccELBV2Listener_tags_EmptyTag_OnUpdate_Add (260.39s)
=== CONT  TestAccELBV2Listener_tags_EmptyMap
--- PASS: TestAccELBV2Listener_fixedResponse (238.42s)
=== CONT  TestAccELBV2Listener_tags_AddOnUpdate
--- PASS: TestAccELBV2Listener_redirect (239.66s)
=== CONT  TestAccELBV2Listener_DefaultAction_defaultOrder
--- PASS: TestAccELBV2Listener_tags_EmptyMap (235.76s)
=== CONT  TestAccELBV2Listener_DefaultAction_specifyOrder
--- PASS: TestAccELBV2Listener_Protocol_tls (479.13s)
=== CONT  TestAccELBV2Listener_tags_null
--- PASS: TestAccELBV2Listener_tags_AddOnUpdate (251.45s)
=== CONT  TestAccELBV2Listener_redirectWithTargetGroupARN
--- PASS: TestAccELBV2Listener_DefaultAction_defaultOrder (240.16s)
=== CONT  TestAccELBV2Listener_mutualAuthenticationPassthrough
--- PASS: TestAccELBV2Listener_DefaultAction_specifyOrder (227.16s)
=== CONT  TestAccELBV2Listener_Gateway_lbARN
--- PASS: TestAccELBV2Listener_tags_null (243.48s)
=== CONT  TestAccELBV2Listener_oidc
--- PASS: TestAccELBV2Listener_mutualAuthenticationPassthrough (226.75s)
=== CONT  TestAccELBV2Listener_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccELBV2Listener_redirectWithTargetGroupARN (268.21s)
=== CONT  TestAccELBV2Listener_DefaultAction_actionDisappears
--- PASS: TestAccELBV2Listener_Gateway_lbARN (182.65s)
=== CONT  TestAccELBV2Listener_mutualAuthentication
--- PASS: TestAccELBV2Listener_oidc (229.21s)
=== CONT  TestAccELBV2Listener_Forward_addAction
--- PASS: TestAccELBV2Listener_tags_IgnoreTags_Overlap_DefaultTag (253.17s)
=== CONT  TestAccELBV2Listener_Forward_TGARNToForward_weightAndStickiness
--- PASS: TestAccELBV2Listener_DefaultAction_actionDisappears (235.41s)
=== CONT  TestAccELBV2Listener_backwardsCompatibility
--- PASS: TestAccELBV2Listener_mutualAuthentication (227.56s)
=== CONT  TestAccELBV2Listener_Forward_ToTGARN_weightStickiness
--- PASS: TestAccELBV2Listener_Forward_addAction (253.14s)
=== CONT  TestAccELBV2Listener_Protocol_upd
--- PASS: TestAccELBV2Listener_backwardsCompatibility (217.64s)
=== CONT  TestAccELBV2Listener_Forward_ToTGARN_noChanges
--- PASS: TestAccELBV2Listener_Forward_TGARNToForward_weightAndStickiness (253.82s)
=== CONT  TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds
--- PASS: TestAccELBV2Listener_Forward_ToTGARN_weightStickiness (263.11s)
=== CONT  TestAccELBV2Listener_Forward_ignoreFields
--- PASS: TestAccELBV2Listener_Protocol_upd (222.45s)
=== CONT  TestAccELBV2Listener_Forward_removeAction
--- PASS: TestAccELBV2Listener_attributes_nlb_TCPIdleTimeoutSeconds (213.44s)
=== CONT  TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds
--- PASS: TestAccELBV2Listener_Forward_ToTGARN_noChanges (235.06s)
=== CONT  TestAccELBV2Listener_Forward_addStickiness
--- PASS: TestAccELBV2Listener_Forward_ignoreFields (218.79s)
=== CONT  TestAccELBV2Listener_Forward_removeStickiness
--- PASS: TestAccELBV2Listener_attributes_gwlb_TCPIdleTimeoutSeconds (100.77s)
=== CONT  TestAccELBV2Listener_Forward_TGARNToForward_noChanges
--- PASS: TestAccELBV2Listener_Forward_removeAction (154.16s)
=== CONT  TestAccELBV2Listener_DefaultAction_empty
=== RUN   TestAccELBV2Listener_DefaultAction_empty/authenticate-oidc
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/authenticate-oidc
=== RUN   TestAccELBV2Listener_DefaultAction_empty/authenticate-cognito
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/authenticate-cognito
=== RUN   TestAccELBV2Listener_DefaultAction_empty/redirect
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/redirect
=== RUN   TestAccELBV2Listener_DefaultAction_empty/fixed-response
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/fixed-response
=== RUN   TestAccELBV2Listener_DefaultAction_empty/forward
=== PAUSE TestAccELBV2Listener_DefaultAction_empty/forward
=== CONT  TestAccELBV2Listener_DefaultAction_empty/authenticate-oidc
=== CONT  TestAccELBV2Listener_DefaultAction_empty/fixed-response
=== CONT  TestAccELBV2Listener_DefaultAction_empty/forward
--- PASS: TestAccELBV2Listener_Forward_addStickiness (123.46s)
=== CONT  TestAccELBV2Listener_DefaultAction_empty/redirect
=== CONT  TestAccELBV2Listener_DefaultAction_empty/authenticate-cognito
--- PASS: TestAccELBV2Listener_DefaultAction_empty (0.00s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/authenticate-oidc (1.69s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/fixed-response (1.58s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/forward (1.61s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/redirect (1.65s)
    --- PASS: TestAccELBV2Listener_DefaultAction_empty/authenticate-cognito (1.66s)
--- PASS: TestAccELBV2Listener_Forward_removeStickiness (242.63s)
--- PASS: TestAccELBV2Listener_Forward_TGARNToForward_noChanges (255.20s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	3393.521s
% make testacc TESTARGS='-run=TestAccELBV2LoadBalancer_\|TestAccELBV2LoadBalancerDataSource_' PKG=elbv2 ACCTEST_PARALLELISM=4
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elbv2/... -v -count 1 -parallel 4  -run=TestAccELBV2LoadBalancer_\|TestAccELBV2LoadBalancerDataSource_ -timeout 360m
2024/10/22 15:23:22 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2LoadBalancerDataSource_tags
=== PAUSE TestAccELBV2LoadBalancerDataSource_tags
=== RUN   TestAccELBV2LoadBalancerDataSource_tags_NullMap
=== PAUSE TestAccELBV2LoadBalancerDataSource_tags_NullMap
=== RUN   TestAccELBV2LoadBalancerDataSource_tags_EmptyMap
=== PAUSE TestAccELBV2LoadBalancerDataSource_tags_EmptyMap
=== RUN   TestAccELBV2LoadBalancerDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccELBV2LoadBalancerDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccELBV2LoadBalancerDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccELBV2LoadBalancerDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccELBV2LoadBalancerDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccELBV2LoadBalancerDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccELBV2LoadBalancerDataSource_basic
=== PAUSE TestAccELBV2LoadBalancerDataSource_basic
=== RUN   TestAccELBV2LoadBalancerDataSource_outpost
=== PAUSE TestAccELBV2LoadBalancerDataSource_outpost
=== RUN   TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== PAUSE TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
=== RUN   TestAccELBV2LoadBalancer_tags
=== PAUSE TestAccELBV2LoadBalancer_tags
=== RUN   TestAccELBV2LoadBalancer_tags_null
=== PAUSE TestAccELBV2LoadBalancer_tags_null
=== RUN   TestAccELBV2LoadBalancer_tags_EmptyMap
=== PAUSE TestAccELBV2LoadBalancer_tags_EmptyMap
=== RUN   TestAccELBV2LoadBalancer_tags_AddOnUpdate
=== PAUSE TestAccELBV2LoadBalancer_tags_AddOnUpdate
=== RUN   TestAccELBV2LoadBalancer_tags_EmptyTag_OnCreate
=== PAUSE TestAccELBV2LoadBalancer_tags_EmptyTag_OnCreate
=== RUN   TestAccELBV2LoadBalancer_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccELBV2LoadBalancer_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccELBV2LoadBalancer_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccELBV2LoadBalancer_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccELBV2LoadBalancer_tags_DefaultTags_providerOnly
=== PAUSE TestAccELBV2LoadBalancer_tags_DefaultTags_providerOnly
=== RUN   TestAccELBV2LoadBalancer_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccELBV2LoadBalancer_tags_DefaultTags_nonOverlapping
=== RUN   TestAccELBV2LoadBalancer_tags_DefaultTags_overlapping
=== PAUSE TestAccELBV2LoadBalancer_tags_DefaultTags_overlapping
=== RUN   TestAccELBV2LoadBalancer_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccELBV2LoadBalancer_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccELBV2LoadBalancer_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccELBV2LoadBalancer_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccELBV2LoadBalancer_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccELBV2LoadBalancer_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccELBV2LoadBalancer_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccELBV2LoadBalancer_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccELBV2LoadBalancer_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccELBV2LoadBalancer_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccELBV2LoadBalancer_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccELBV2LoadBalancer_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccELBV2LoadBalancer_tags_ComputedTag_OnCreate
=== PAUSE TestAccELBV2LoadBalancer_tags_ComputedTag_OnCreate
=== RUN   TestAccELBV2LoadBalancer_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccELBV2LoadBalancer_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccELBV2LoadBalancer_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccELBV2LoadBalancer_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccELBV2LoadBalancer_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccELBV2LoadBalancer_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccELBV2LoadBalancer_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccELBV2LoadBalancer_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccELBV2LoadBalancer_ALB_basic
=== PAUSE TestAccELBV2LoadBalancer_ALB_basic
=== RUN   TestAccELBV2LoadBalancer_NLB_basic
=== PAUSE TestAccELBV2LoadBalancer_NLB_basic
=== RUN   TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== PAUSE TestAccELBV2LoadBalancer_LoadBalancerType_gateway
=== RUN   TestAccELBV2LoadBalancer_disappears
=== PAUSE TestAccELBV2LoadBalancer_disappears
=== RUN   TestAccELBV2LoadBalancer_nameGenerated
=== PAUSE TestAccELBV2LoadBalancer_nameGenerated
=== RUN   TestAccELBV2LoadBalancer_nameGeneratedForZeroValue
=== PAUSE TestAccELBV2LoadBalancer_nameGeneratedForZeroValue
=== RUN   TestAccELBV2LoadBalancer_namePrefix
=== PAUSE TestAccELBV2LoadBalancer_namePrefix
=== RUN   TestAccELBV2LoadBalancer_duplicateName
=== PAUSE TestAccELBV2LoadBalancer_duplicateName
=== RUN   TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== PAUSE TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== RUN   TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
=== PAUSE TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
=== RUN   TestAccELBV2LoadBalancer_ALB_outpost
=== PAUSE TestAccELBV2LoadBalancer_ALB_outpost
=== RUN   TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== PAUSE TestAccELBV2LoadBalancer_networkLoadBalancerEIP
=== RUN   TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== PAUSE TestAccELBV2LoadBalancer_NLB_privateIPv4Address
=== RUN   TestAccELBV2LoadBalancer_backwardsCompatibility
=== PAUSE TestAccELBV2LoadBalancer_backwardsCompatibility
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateZonalShift
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateZonalShift
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_clientKeepAlive
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_clientKeepAlive
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen
=== RUN   TestAccELBV2LoadBalancer_updateIPAddressType
=== PAUSE TestAccELBV2LoadBalancer_updateIPAddressType
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnetMapping
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnetMapping
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnetMapping
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnetMapping
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs
=== RUN   TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogsPrefix
=== PAUSE TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogsPrefix
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnetMapping
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnetMapping
=== RUN   TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnetMapping
=== PAUSE TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnetMapping
=== RUN   TestAccELBV2LoadBalancer_updateDesyncMitigationMode
=== PAUSE TestAccELBV2LoadBalancer_updateDesyncMitigationMode
=== RUN   TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite
=== PAUSE TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite
=== RUN   TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode
=== PAUSE TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode
=== RUN   TestAccELBV2LoadBalancer_ALB_updateXffClientPort
=== PAUSE TestAccELBV2LoadBalancer_ALB_updateXffClientPort
=== CONT  TestAccELBV2LoadBalancerDataSource_tags
=== CONT  TestAccELBV2LoadBalancer_ipv6SubnetMapping
=== CONT  TestAccELBV2LoadBalancer_tags_DefaultTags_updateToProviderOnly
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnetMapping
--- PASS: TestAccELBV2LoadBalancerDataSource_tags (225.73s)
=== CONT  TestAccELBV2LoadBalancer_tags_null
--- PASS: TestAccELBV2LoadBalancer_ipv6SubnetMapping (243.06s)
=== CONT  TestAccELBV2LoadBalancer_tags_DefaultTags_overlapping
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnetMapping (267.12s)
=== CONT  TestAccELBV2LoadBalancer_tags_DefaultTags_nonOverlapping
--- PASS: TestAccELBV2LoadBalancer_tags_DefaultTags_updateToProviderOnly (274.02s)
=== CONT  TestAccELBV2LoadBalancer_tags_DefaultTags_providerOnly
=== CONT  TestAccELBV2LoadBalancer_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccELBV2LoadBalancer_tags_null (242.43s)
--- PASS: TestAccELBV2LoadBalancer_tags_DefaultTags_overlapping (315.16s)
=== CONT  TestAccELBV2LoadBalancer_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccELBV2LoadBalancer_tags_DefaultTags_nonOverlapping (334.41s)
=== CONT  TestAccELBV2LoadBalancer_tags_EmptyTag_OnCreate
--- PASS: TestAccELBV2LoadBalancer_tags_DefaultTags_providerOnly (365.81s)
=== CONT  TestAccELBV2LoadBalancer_tags_AddOnUpdate
--- PASS: TestAccELBV2LoadBalancer_tags_EmptyTag_OnUpdate_Replace (280.39s)
=== CONT  TestAccELBV2LoadBalancer_tags_EmptyMap
--- PASS: TestAccELBV2LoadBalancer_tags_EmptyTag_OnCreate (264.36s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields
--- PASS: TestAccELBV2LoadBalancer_tags_EmptyTag_OnUpdate_Add (320.11s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnetMapping
--- PASS: TestAccELBV2LoadBalancer_tags_AddOnUpdate (252.15s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet
--- PASS: TestAccELBV2LoadBalancer_tags_EmptyMap (213.95s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnetMapping (265.72s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDropInvalidHeaderFields (310.10s)
=== CONT  TestAccELBV2LoadBalancer_updateIPAddressType
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_addSubnet (258.73s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatedSecurityGroups (268.83s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection
--- PASS: TestAccELBV2LoadBalancer_updateIPAddressType (328.33s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateWAFFailOpen (330.70s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateDeletionProtection (318.04s)
=== CONT  TestAccELBV2LoadBalancer_ALB_updateXffClientPort
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updatePreserveHostHeader (319.52s)
=== CONT  TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_enforcePrivateLink (309.83s)
=== CONT  TestAccELBV2LoadBalancerDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccELBV2LoadBalancer_ALB_updateXffClientPort (314.16s)
=== CONT  TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite
--- PASS: TestAccELBV2LoadBalancerDataSource_tags_IgnoreTags_Overlap_ResourceTag (224.43s)
=== CONT  TestAccELBV2LoadBalancer_tags
--- PASS: TestAccELBV2LoadBalancer_ALB_updateXffHeaderProcessingMode (315.42s)
=== CONT  TestAccELBV2LoadBalancer_updateDesyncMitigationMode
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_deleteSubnet (266.09s)
=== CONT  TestAccELBV2LoadBalancerDataSource_backwardsCompatibility
--- PASS: TestAccELBV2LoadBalancer_ALB_updateTLSVersionAndCipherSuite (333.07s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnetMapping
--- PASS: TestAccELBV2LoadBalancer_updateDesyncMitigationMode (305.83s)
=== CONT  TestAccELBV2LoadBalancerDataSource_outpost
    load_balancer_data_source_test.go:102: skipping since no Outposts found
--- SKIP: TestAccELBV2LoadBalancerDataSource_outpost (0.46s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnetMapping
--- PASS: TestAccELBV2LoadBalancer_tags (384.27s)
=== CONT  TestAccELBV2LoadBalancerDataSource_basic
--- PASS: TestAccELBV2LoadBalancerDataSource_backwardsCompatibility (247.11s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet
--- PASS: TestAccELBV2LoadBalancerDataSource_basic (226.10s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnetMapping (303.78s)
=== CONT  TestAccELBV2LoadBalancerDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnetMapping (409.92s)
=== CONT  TestAccELBV2LoadBalancerDataSource_tags_EmptyMap
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_deleteSubnet (410.10s)
=== CONT  TestAccELBV2LoadBalancerDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccELBV2LoadBalancerDataSource_tags_DefaultTags_nonOverlapping (234.96s)
=== CONT  TestAccELBV2LoadBalancer_backwardsCompatibility
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_addSubnet (323.33s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_clientKeepAlive
--- PASS: TestAccELBV2LoadBalancerDataSource_tags_EmptyMap (233.83s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2
--- PASS: TestAccELBV2LoadBalancerDataSource_tags_IgnoreTags_Overlap_DefaultTag (216.48s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateZonalShift
--- PASS: TestAccELBV2LoadBalancer_backwardsCompatibility (223.13s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_clientKeepAlive (319.53s)
=== CONT  TestAccELBV2LoadBalancerDataSource_tags_NullMap
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_updateHTTP2 (317.77s)
=== CONT  TestAccELBV2LoadBalancer_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateZonalShift (271.75s)
=== CONT  TestAccELBV2LoadBalancer_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateCrossZone (262.07s)
=== CONT  TestAccELBV2LoadBalancer_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccELBV2LoadBalancer_tags_DefaultTags_nullNonOverlappingResourceTag (213.86s)
=== CONT  TestAccELBV2LoadBalancer_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccELBV2LoadBalancerDataSource_tags_NullMap (223.75s)
=== CONT  TestAccELBV2LoadBalancer_tags_ComputedTag_OnCreate
--- PASS: TestAccELBV2LoadBalancer_tags_ComputedTag_OnUpdate_Add (298.18s)
=== CONT  TestAccELBV2LoadBalancer_namePrefix
--- PASS: TestAccELBV2LoadBalancer_tags_ComputedTag_OnCreate (109.56s)
=== CONT  TestAccELBV2LoadBalancer_duplicateName
--- PASS: TestAccELBV2LoadBalancer_tags_ComputedTag_OnUpdate_Replace (229.05s)
=== CONT  TestAccELBV2LoadBalancer_nameGeneratedForZeroValue
--- PASS: TestAccELBV2LoadBalancer_tags_IgnoreTags_Overlap_DefaultTag (243.44s)
=== CONT  TestAccELBV2LoadBalancer_networkLoadBalancerEIP
--- PASS: TestAccELBV2LoadBalancer_namePrefix (173.84s)
=== CONT  TestAccELBV2LoadBalancer_nameGenerated
--- PASS: TestAccELBV2LoadBalancer_nameGeneratedForZeroValue (133.67s)
=== CONT  TestAccELBV2LoadBalancer_NLB_privateIPv4Address
--- PASS: TestAccELBV2LoadBalancer_duplicateName (159.51s)
=== CONT  TestAccELBV2LoadBalancer_LoadBalancerType_gateway
--- PASS: TestAccELBV2LoadBalancer_networkLoadBalancerEIP (140.09s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogsPrefix
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerType_gateway (200.35s)
=== CONT  TestAccELBV2LoadBalancer_disappears
--- PASS: TestAccELBV2LoadBalancer_NLB_privateIPv4Address (220.47s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups
--- PASS: TestAccELBV2LoadBalancer_nameGenerated (225.13s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogsPrefix (320.89s)
=== CONT  TestAccELBV2LoadBalancer_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccELBV2LoadBalancer_disappears (216.32s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateDNSRecordClientRoutingPolicy (274.02s)
=== CONT  TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs
--- PASS: TestAccELBV2LoadBalancer_tags_DefaultTags_emptyProviderOnlyTag (228.69s)
=== CONT  TestAccELBV2LoadBalancer_NLB_basic
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogsPrefix (317.51s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix
--- PASS: TestAccELBV2LoadBalancer_NLB_basic (177.36s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_accessLogs (339.84s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs
--- PASS: TestAccELBV2LoadBalancer_NetworkLoadBalancer_updateSecurityGroups (646.82s)
=== CONT  TestAccELBV2LoadBalancer_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogsPrefix (202.15s)
=== CONT  TestAccELBV2LoadBalancer_ALB_outpost
    load_balancer_test.go:430: skipping since no Outposts found
--- SKIP: TestAccELBV2LoadBalancer_ALB_outpost (0.46s)
=== CONT  TestAccELBV2LoadBalancer_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_connectionLogs (253.04s)
=== CONT  TestAccELBV2LoadBalancer_ALB_basic
--- PASS: TestAccELBV2LoadBalancer_tags_DefaultTags_emptyResourceTag (105.23s)
=== CONT  TestAccELBV2LoadBalancer_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_accessLogs (218.92s)
=== CONT  TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing
--- PASS: TestAccELBV2LoadBalancer_tags_IgnoreTags_Overlap_ResourceTag (235.75s)
=== CONT  TestAccELBV2LoadBalancer_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccELBV2LoadBalancer_ALB_basic (225.83s)
=== CONT  TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup
--- PASS: TestAccELBV2LoadBalancer_tags_DefaultTags_updateToResourceOnly (150.98s)
--- PASS: TestAccELBV2LoadBalancer_LoadBalancerTypeGateway_enableCrossZoneLoadBalancing (154.12s)
--- PASS: TestAccELBV2LoadBalancer_ApplicationLoadBalancer_noSecurityGroup (82.52s)
--- PASS: TestAccELBV2LoadBalancer_tags_DefaultTags_nullOverlappingResourceTag (180.25s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	5120.755s
% make testacc TESTARGS='-run=TestAccELBV2ListenerDataSource_basic' PKG=elbv2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/elbv2/... -v -count 1 -parallel 20  -run=TestAccELBV2ListenerDataSource_basic -timeout 360m
2024/10/23 09:10:41 Initializing Terraform AWS Provider...
=== RUN   TestAccELBV2ListenerDataSource_basic
=== PAUSE TestAccELBV2ListenerDataSource_basic
=== CONT  TestAccELBV2ListenerDataSource_basic
--- PASS: TestAccELBV2ListenerDataSource_basic (207.08s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/elbv2	212.115s

@ewbankkit
Copy link
Contributor

@ddericco Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit b018305 into hashicorp:main Oct 23, 2024
47 checks passed
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 23, 2024
@ddericco ddericco deleted the f-aws_lb_listener-tcp_idle_timeout_nlb_gwlb branch October 23, 2024 14:53
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Oct 24, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@magreenbaum magreenbaum mentioned this pull request Oct 25, 2024
Merged
3 tasks
This was referenced Nov 4, 2024
Closed
Closed
Merged
@jrindy-iterable jrindy-iterable mentioned this pull request Nov 14, 2024
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. partner Contribution from a partner. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.73.0
3 participants
@ddericco @ewbankkit @justinretzolk