Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: aws_rds_integration lacks the DataFilter parameter #39762

Closed
davidsickmiller opened this issue Oct 17, 2024 · 6 comments · Fixed by #40816
Closed

[Enhancement]: aws_rds_integration lacks the DataFilter parameter #39762

davidsickmiller opened this issue Oct 17, 2024 · 6 comments · Fixed by #40816
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Milestone

Comments

@davidsickmiller
Copy link

Description

One of the Zero-ETL integration parameters is DataFilter. It allows databases and tables to included or excluded from the integration.

I believe the provider doesn't currently allow this parameter to be configured, and I am kindly requesting this additional feature.

Affected Resource(s) and/or Data Source(s)

aws_rds_integration

Potential Terraform Configuration

resource "aws_rds_integration" "example" {
  integration_name = "example"
  source_arn       = aws_rds_cluster.example.arn
  target_arn       = aws_redshift_cluster.example.arn
  kms_key_id       = ""
  tags             = {}
  data_filter      = "mydb.mytable, mydb.mytable2"
}

References

https://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateIntegration.html

Would you like to implement a fix?

No

@davidsickmiller davidsickmiller added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 17, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/rds Issues and PRs that pertain to the rds service. needs-triage Waiting for first response or review from a maintainer. labels Oct 17, 2024
@justinretzolk justinretzolk removed the needs-triage Waiting for first response or review from a maintainer. label Oct 18, 2024
@kty1965
Copy link

kty1965 commented Oct 21, 2024

I need it!

@matthewmrichter
Copy link

matthewmrichter commented Dec 11, 2024

I think I would put this more in the category of a bug than an enhancement. One can't use redshift serverless zero-etl without filters:

resource "aws_rds_integration" "this" {
  integration_name = "this-${local.environment}-${local.aws_region}"
  kms_key_id       = aws_kms_key.redshift.key_id
  source_arn       = data.terraform_remote_state.this.outputs.rds_cluster_arn
  target_arn       = aws_redshiftserverless_namespace.sources.arn
}

╷
│ Error: creating RDS Integration (this-staging-us-east-2)
│ 
│   with aws_rds_integration.this,
│   on zero-etl.tf line 78, in resource "aws_rds_integration" "this":
│   78: resource "aws_rds_integration" "this" {
│ 
│ operation error RDS: CreateIntegration, https response error StatusCode:
│ 400, RequestID: 1046dde1-b9ce-4d9e-bfa3-c49bec23da6f, api error
│ InvalidParameterCombination: Data filter argument is required to create an
│ integration with an Aurora PostgreSQL source DB cluster.
╵

@jar-b jar-b self-assigned this Jan 7, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 7, 2025
Copy link

github-actions bot commented Jan 9, 2025

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot added this to the v5.83.0 milestone Jan 9, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

github-actions bot commented Feb 9, 2025

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/rds Issues and PRs that pertain to the rds service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants