-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws_s3_object (et al.): Remove kms:DescribeKey
on default S3 KMS key
#39782
Conversation
…ket'." This reverts commit 0593401.
…and 'TestAccS3Object_basicUpgrade'.
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=s3 TESTS=TestAccS3Object_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/s3/... -v -count 1 -parallel 20 -run='TestAccS3Object_' -timeout 360m
=== CONT TestAccS3Object_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccS3Object_withContentCharacteristics (33.29s)
=== CONT TestAccS3Object_basic
--- PASS: TestAccS3Object_DirectoryBucket_DefaultTags_providerOnly (33.60s)
=== CONT TestAccS3Object_tags_AddOnUpdate
--- PASS: TestAccS3Object_objectBucketKeyEnabled (33.91s)
=== CONT TestAccS3Object_tags_EmptyTag_OnCreate
--- PASS: TestAccS3Object_disappears (35.13s)
=== CONT TestAccS3Object_checksumAlgorithm
--- PASS: TestAccS3Object_Disappears_bucket (43.00s)
=== CONT TestAccS3Object_defaultKMS
--- PASS: TestAccS3Object_source (46.28s)
=== CONT TestAccS3Object_optInRegion
object_test.go:1875: this AWS account must be the management account of an AWS Organization
--- SKIP: TestAccS3Object_optInRegion (0.38s)
=== CONT TestAccS3Object_DirectoryBucket_disappears
=== CONT TestAccS3Object_crossRegion
--- PASS: TestAccS3Object_content (47.60s)
--- PASS: TestAccS3Object_tags_DefaultTags_emptyProviderOnlyTag (55.26s)
=== CONT TestAccS3Object_directoryBucket
--- PASS: TestAccS3Object_tags_ComputedTag_OnCreate (55.52s)
=== CONT TestAccS3Object_prefix
--- PASS: TestAccS3Object_upgradeFromV4 (60.73s)
=== CONT TestAccS3Object_keyWithSlashesMigrated
--- PASS: TestAccS3Object_crossRegion (22.23s)
=== CONT TestAccS3Object_DirectoryBucket_kmsSSE
--- PASS: TestAccS3Object_updateSameFile (71.49s)
=== CONT TestAccS3Object_tags_DefaultTags_nullNonOverlappingResourceTag
--- PASS: TestAccS3Object_updates (73.62s)
=== CONT TestAccS3Object_tags_EmptyMap
--- PASS: TestAccS3Object_updatesWithVersioning (74.39s)
=== CONT TestAccS3Object_defaultBucketSSE
--- PASS: TestAccS3Object_basic (43.79s)
=== CONT TestAccS3Object_contentBase64
--- PASS: TestAccS3Object_DirectoryBucket_disappears (33.19s)
=== CONT TestAccS3Object_ignoreTags
--- PASS: TestAccS3Object_defaultKMS (36.84s)
=== CONT TestAccS3Object_sourceHashTrigger
--- PASS: TestAccS3Object_defaultKMSUpgrade (84.33s)
=== CONT TestAccS3Object_tags_DefaultTags_providerOnly
--- PASS: TestAccS3Object_tags_ComputedTag_OnUpdate_Add (90.11s)
=== CONT TestAccS3Object_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccS3Object_basicUpgrade (90.17s)
=== CONT TestAccS3Object_tags_DefaultTags_nonOverlapping
--- PASS: TestAccS3Object_prefix (39.21s)
=== CONT TestAccS3Object_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccS3Object_directoryBucket (41.24s)
=== CONT TestAccS3Object_bucketBucketKeyEnabled
--- PASS: TestAccS3Object_checksumAlgorithm (64.56s)
=== CONT TestAccS3Object_tags_null
--- PASS: TestAccS3Object_contentBase64 (28.86s)
=== CONT TestAccS3Object_tagsMultipleSlashes
--- PASS: TestAccS3Object_defaultBucketSSE (31.81s)
=== CONT TestAccS3Object_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccS3Object_keyWithSlashesMigrated (47.83s)
=== CONT TestAccS3Object_objectLockRetentionStartWithSet
--- PASS: TestAccS3Object_DirectoryBucket_kmsSSE (40.90s)
=== CONT TestAccS3Object_metadata
--- PASS: TestAccS3Object_tags_DefaultTags_nullNonOverlappingResourceTag (43.66s)
=== CONT TestAccS3Object_objectLockRetentionStartWithNone
--- PASS: TestAccS3Object_tags_AddOnUpdate (82.32s)
=== CONT TestAccS3Object_tagsLeadingMultipleSlashes
--- PASS: TestAccS3Object_tags_IgnoreTags_Overlap_ResourceTag (119.97s)
=== CONT TestAccS3Object_objectLockLegalHoldStartWithOn
--- PASS: TestAccS3Object_tags_EmptyTag_OnUpdate_Add (121.77s)
=== CONT TestAccS3Object_tagsLeadingSingleSlash
--- PASS: TestAccS3Object_tags_EmptyTag_OnCreate (88.76s)
=== CONT TestAccS3Object_objectLockLegalHoldStartWithNone
--- PASS: TestAccS3Object_bucketBucketKeyEnabled (32.54s)
=== CONT TestAccS3Object_storageClass
--- PASS: TestAccS3Object_tags_EmptyMap (57.71s)
=== CONT TestAccS3Object_tagsViaMultiRegionAccessPoint
--- PASS: TestAccS3Object_tags_DefaultTags_overlapping (137.64s)
=== CONT TestAccS3Object_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccS3Object_tags_DefaultTags_emptyResourceTag (44.02s)
=== CONT TestAccS3Object_tagsViaAccessPointAlias
--- PASS: TestAccS3Object_ignoreTags (60.07s)
=== CONT TestAccS3Object_tagsViaAccessPointARN
--- PASS: TestAccS3Object_sourceHashTrigger (60.69s)
=== CONT TestAccS3Object_etagEncryption
--- PASS: TestAccS3Object_tags_null (51.87s)
=== CONT TestAccS3Object_sse
--- PASS: TestAccS3Object_tags_DefaultTags_updateToResourceOnly (72.80s)
=== CONT TestAccS3Object_acl
--- PASS: TestAccS3Object_tags (163.16s)
=== CONT TestAccS3Object_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccS3Object_etagEncryption (30.31s)
=== CONT TestAccS3Object_kms
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithOn (54.28s)
=== CONT TestAccS3Object_updatesWithVersioningViaAccessPoint
--- PASS: TestAccS3Object_tags_DefaultTags_updateToProviderOnly (72.38s)
=== CONT TestAccS3Object_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccS3Object_sse (34.27s)
=== CONT TestAccS3Object_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccS3Object_metadata (75.33s)
--- PASS: TestAccS3Object_objectLockRetentionStartWithNone (77.97s)
--- PASS: TestAccS3Object_tagsViaAccessPointAlias (57.92s)
--- PASS: TestAccS3Object_tagsViaAccessPointARN (58.07s)
--- PASS: TestAccS3Object_objectLockLegalHoldStartWithNone (76.47s)
--- PASS: TestAccS3Object_tags_DefaultTags_nonOverlapping (111.05s)
--- PASS: TestAccS3Object_kms (30.73s)
--- PASS: TestAccS3Object_tags_EmptyTag_OnUpdate_Replace (64.86s)
--- PASS: TestAccS3Object_tagsMultipleSlashes (100.24s)
--- PASS: TestAccS3Object_objectLockRetentionStartWithSet (98.22s)
--- PASS: TestAccS3Object_tagsLeadingMultipleSlashes (95.11s)
--- PASS: TestAccS3Object_tags_DefaultTags_nullOverlappingResourceTag (32.56s)
--- PASS: TestAccS3Object_tagsLeadingSingleSlash (96.45s)
--- PASS: TestAccS3Object_updatesWithVersioningViaAccessPoint (45.22s)
--- PASS: TestAccS3Object_tags_DefaultTags_providerOnly (136.89s)
--- PASS: TestAccS3Object_storageClass (95.61s)
--- PASS: TestAccS3Object_tags_IgnoreTags_Overlap_DefaultTag (65.98s)
--- PASS: TestAccS3Object_acl (66.44s)
--- PASS: TestAccS3Object_tags_ComputedTag_OnUpdate_Replace (47.40s)
--- PASS: TestAccS3Object_tagsViaMultiRegionAccessPoint (338.68s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/s3 476.605s
This functionality has been released in v5.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Removes the KMS call to describe the default S3 KMS key -- least privilege.
The addition of
Computed
to thekms_key_id
attribute in #15234 removed the need for this functionality.Relations
Closes #3450.
Output from Acceptance Testing