Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_cognito_user_pool: fix crash when hashing nil schema #40195

Merged
merged 1 commit into from
Nov 20, 2024
Merged

r/aws_cognito_user_pool: fix crash when hashing nil schema #40195

merged 1 commit into from
Nov 20, 2024

Conversation

jar-b
Copy link
Member

@jar-b jar-b commented Nov 19, 2024

Description

This change prevents a crash triggered when the custom set hashing function resourceUserPoolSchemaHash is called with a nil value. Previously this would trigger a panic and crash provider execution.

Relations

Closes #40162
Closes #39992
Closes #39823

Output from Acceptance Testing

% make testacc PKG=cognitoidp TESTS=TestAccCognitoIDPUserPool_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPool_'  -timeout 360m
2024/11/19 15:23:16 Initializing Terraform AWS Provider...

--- PASS: TestAccCognitoIDPUserPool_basic (41.36s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy (42.16s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag (44.35s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate (46.86s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag (48.03s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag (48.16s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly
--- PASS: TestAccCognitoIDPUserPool_passwordHistorySize (67.67s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccCognitoIDPUserPool_withEmailVerificationMessage (67.68s)
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUser (67.68s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyMap
--- PASS: TestAccCognitoIDPUserPool_deletionProtection (67.71s)
=== CONT  TestAccCognitoIDPUserPool_tags_AddOnUpdate
--- PASS: TestAccCognitoIDPUserPool_withDevice (67.76s)
=== CONT  TestAccCognitoIDPUserPool_withUsername
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace (77.79s)
=== CONT  TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add (81.32s)
=== CONT  TestAccCognitoIDPUserPool_disappears
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag (46.82s)
=== CONT  TestAccCognitoIDPUserPool_update
--- PASS: TestAccCognitoIDPUserPool_recovery (88.40s)
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8
--- PASS: TestAccCognitoIDPUserPool_withAdvancedSecurityMode (92.09s)
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplate
--- PASS: TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag (97.74s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly (71.82s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesModified
--- PASS: TestAccCognitoIDPUserPool_MFA_sms (114.06s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesRemoved
--- PASS: TestAccCognitoIDPUserPool_disappears (32.77s)
=== CONT  TestAccCognitoIDPUserPool_SMS_externalID
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly (72.08s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributes
--- PASS: TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag (117.84s)
=== CONT  TestAccCognitoIDPUserPool_withPasswordPolicy
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyMap (57.11s)
=== CONT  TestAccCognitoIDPUserPool_addLambda
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping (129.60s)
=== CONT  TestAccCognitoIDPUserPool_withUsernameAttributes
--- PASS: TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings (54.47s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate (84.40s)
=== CONT  TestAccCognitoIDPUserPool_withAliasAttributes
--- PASS: TestAccCognitoIDPUserPool_withUsername (66.46s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_sms
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints (38.96s)
=== CONT  TestAccCognitoIDPUserPool_withEmail
--- PASS: TestAccCognitoIDPUserPool_tags_AddOnUpdate (75.00s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_email
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace (75.06s)
=== CONT  TestAccCognitoIDPUserPool_smsVerificationMessage
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesRemoved (36.79s)
=== CONT  TestAccCognitoIDPUserPool_withLambda
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesModified (38.52s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsCallerARN
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8 (64.20s)
=== CONT  TestAccCognitoIDPUserPool_tags_null
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplate (61.69s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
--- PASS: TestAccCognitoIDPUserPool_tags (160.84s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsRegion
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping (116.82s)
=== CONT  TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_withEmail (33.60s)
=== CONT  TestAccCognitoIDPUserPool_sms
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add (103.33s)
=== CONT  TestAccCognitoIDPUserPool_smsAuthenticationMessage
--- PASS: TestAccCognitoIDPUserPool_withPasswordPolicy (55.38s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_schemaAttributes (56.87s)
=== CONT  TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_update (92.14s)
--- PASS: TestAccCognitoIDPUserPool_withUsernameAttributes (52.64s)
--- PASS: TestAccCognitoIDPUserPool_withAliasAttributes (53.60s)
--- PASS: TestAccCognitoIDPUserPool_SMS_externalID (74.58s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly (141.06s)
--- PASS: TestAccCognitoIDPUserPool_smsVerificationMessage (49.63s)
--- PASS: TestAccCognitoIDPUserPool_tags_null (40.66s)
--- PASS: TestAccCognitoIDPUserPool_addLambda (72.62s)
--- PASS: TestAccCognitoIDPUserPool_SMS_snsRegion (36.64s)
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS (51.33s)
--- PASS: TestAccCognitoIDPUserPool_smsAuthenticationMessage (38.29s)
--- PASS: TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA (49.39s)
--- PASS: TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig (81.43s)
--- PASS: TestAccCognitoIDPUserPool_SMS_snsCallerARN (62.90s)
--- PASS: TestAccCognitoIDPUserPool_WithLambda_sms (85.18s)
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFA (47.63s)
--- PASS: TestAccCognitoIDPUserPool_sms (51.39s)
--- PASS: TestAccCognitoIDPUserPool_WithLambda_email (81.90s)
--- PASS: TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA (53.34s)
--- PASS: TestAccCognitoIDPUserPool_withLambda (77.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 234.872s

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/cognitoidp Issues and PRs that pertain to the cognitoidp service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Nov 19, 2024
@jar-b
r/aws_cognito_user_pool: fix crash when hashing nil schema
1d7399b 
This change prevents a crash triggered when the custom set hashing function `resourceUserPoolSchemaHash` is called with a `nil` value. Previously this would trigger a panic and crash provider execution.

```console
% make testacc PKG=cognitoidp TESTS=TestAccCognitoIDPUserPool_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPool_'  -timeout 360m
2024/11/19 15:23:16 Initializing Terraform AWS Provider...

--- PASS: TestAccCognitoIDPUserPool_basic (41.36s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy (42.16s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag (44.35s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate (46.86s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag (48.03s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag (48.16s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly
--- PASS: TestAccCognitoIDPUserPool_passwordHistorySize (67.67s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccCognitoIDPUserPool_withEmailVerificationMessage (67.68s)
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUser (67.68s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyMap
--- PASS: TestAccCognitoIDPUserPool_deletionProtection (67.71s)
=== CONT  TestAccCognitoIDPUserPool_tags_AddOnUpdate
--- PASS: TestAccCognitoIDPUserPool_withDevice (67.76s)
=== CONT  TestAccCognitoIDPUserPool_withUsername
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace (77.79s)
=== CONT  TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add (81.32s)
=== CONT  TestAccCognitoIDPUserPool_disappears
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag (46.82s)
=== CONT  TestAccCognitoIDPUserPool_update
--- PASS: TestAccCognitoIDPUserPool_recovery (88.40s)
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8
--- PASS: TestAccCognitoIDPUserPool_withAdvancedSecurityMode (92.09s)
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplate
--- PASS: TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag (97.74s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly (71.82s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesModified
--- PASS: TestAccCognitoIDPUserPool_MFA_sms (114.06s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesRemoved
--- PASS: TestAccCognitoIDPUserPool_disappears (32.77s)
=== CONT  TestAccCognitoIDPUserPool_SMS_externalID
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly (72.08s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributes
--- PASS: TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag (117.84s)
=== CONT  TestAccCognitoIDPUserPool_withPasswordPolicy
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyMap (57.11s)
=== CONT  TestAccCognitoIDPUserPool_addLambda
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping (129.60s)
=== CONT  TestAccCognitoIDPUserPool_withUsernameAttributes
--- PASS: TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings (54.47s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate (84.40s)
=== CONT  TestAccCognitoIDPUserPool_withAliasAttributes
--- PASS: TestAccCognitoIDPUserPool_withUsername (66.46s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_sms
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints (38.96s)
=== CONT  TestAccCognitoIDPUserPool_withEmail
--- PASS: TestAccCognitoIDPUserPool_tags_AddOnUpdate (75.00s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_email
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace (75.06s)
=== CONT  TestAccCognitoIDPUserPool_smsVerificationMessage
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesRemoved (36.79s)
=== CONT  TestAccCognitoIDPUserPool_withLambda
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesModified (38.52s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsCallerARN
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8 (64.20s)
=== CONT  TestAccCognitoIDPUserPool_tags_null
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplate (61.69s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
--- PASS: TestAccCognitoIDPUserPool_tags (160.84s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsRegion
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping (116.82s)
=== CONT  TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_withEmail (33.60s)
=== CONT  TestAccCognitoIDPUserPool_sms
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add (103.33s)
=== CONT  TestAccCognitoIDPUserPool_smsAuthenticationMessage
--- PASS: TestAccCognitoIDPUserPool_withPasswordPolicy (55.38s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_schemaAttributes (56.87s)
=== CONT  TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_update (92.14s)
--- PASS: TestAccCognitoIDPUserPool_withUsernameAttributes (52.64s)
--- PASS: TestAccCognitoIDPUserPool_withAliasAttributes (53.60s)
--- PASS: TestAccCognitoIDPUserPool_SMS_externalID (74.58s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly (141.06s)
--- PASS: TestAccCognitoIDPUserPool_smsVerificationMessage (49.63s)
--- PASS: TestAccCognitoIDPUserPool_tags_null (40.66s)
--- PASS: TestAccCognitoIDPUserPool_addLambda (72.62s)
--- PASS: TestAccCognitoIDPUserPool_SMS_snsRegion (36.64s)
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS (51.33s)
--- PASS: TestAccCognitoIDPUserPool_smsAuthenticationMessage (38.29s)
--- PASS: TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA (49.39s)
--- PASS: TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig (81.43s)
--- PASS: TestAccCognitoIDPUserPool_SMS_snsCallerARN (62.90s)
--- PASS: TestAccCognitoIDPUserPool_WithLambda_sms (85.18s)
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFA (47.63s)
--- PASS: TestAccCognitoIDPUserPool_sms (51.39s)
--- PASS: TestAccCognitoIDPUserPool_WithLambda_email (81.90s)
--- PASS: TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA (53.34s)
--- PASS: TestAccCognitoIDPUserPool_withLambda (77.53s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 234.872s
```
@jar-b jar-b force-pushed the b-cognito_user_pool-crash branch from dbf1109 to 1d7399b Compare November 19, 2024 20:35
@jar-b jar-b added crash Results from or addresses a Terraform crash or kernel panic. bug Addresses a defect in current functionality. labels Nov 19, 2024
@jar-b jar-b marked this pull request as ready for review November 19, 2024 20:38
@jar-b jar-b requested a review from a team as a code owner November 19, 2024 20:38
nam054
nam054 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@nam054 nam054 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

> make testacc PKG=cognitoidp TESTS=TestAccCognitoIDPUserPool_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/cognitoidp/... -v -count 1 -parallel 20 -run='TestAccCognitoIDPUserPool_'  -timeout 360m
2024/11/19 13:43:06 Initializing Terraform AWS Provider...
=== RUN   TestAccCognitoIDPUserPool_tags
=== PAUSE TestAccCognitoIDPUserPool_tags
=== RUN   TestAccCognitoIDPUserPool_tags_null
=== PAUSE TestAccCognitoIDPUserPool_tags_null
=== RUN   TestAccCognitoIDPUserPool_tags_EmptyMap
=== PAUSE TestAccCognitoIDPUserPool_tags_EmptyMap
=== RUN   TestAccCognitoIDPUserPool_tags_AddOnUpdate
=== PAUSE TestAccCognitoIDPUserPool_tags_AddOnUpdate
=== RUN   TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate
=== PAUSE TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate
=== RUN   TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add
=== PAUSE TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add
=== RUN   TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace
=== PAUSE TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag
=== RUN   TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag
=== PAUSE TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag
=== RUN   TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate
=== PAUSE TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate
=== RUN   TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add
=== PAUSE TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add
=== RUN   TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace
=== PAUSE TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace
=== RUN   TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccCognitoIDPUserPool_basic
=== PAUSE TestAccCognitoIDPUserPool_basic
=== RUN   TestAccCognitoIDPUserPool_deletionProtection
=== PAUSE TestAccCognitoIDPUserPool_deletionProtection
=== RUN   TestAccCognitoIDPUserPool_recovery
=== PAUSE TestAccCognitoIDPUserPool_recovery
=== RUN   TestAccCognitoIDPUserPool_withAdminCreateUser
=== PAUSE TestAccCognitoIDPUserPool_withAdminCreateUser
=== RUN   TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== PAUSE TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== RUN   TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== PAUSE TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== RUN   TestAccCognitoIDPUserPool_withDevice
=== PAUSE TestAccCognitoIDPUserPool_withDevice
=== RUN   TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== PAUSE TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== RUN   TestAccCognitoIDPUserPool_passwordHistorySize
=== PAUSE TestAccCognitoIDPUserPool_passwordHistorySize
=== RUN   TestAccCognitoIDPUserPool_MFA_sms
=== PAUSE TestAccCognitoIDPUserPool_MFA_sms
=== RUN   TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
=== PAUSE TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
=== RUN   TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
=== PAUSE TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
=== RUN   TestAccCognitoIDPUserPool_smsAuthenticationMessage
=== PAUSE TestAccCognitoIDPUserPool_smsAuthenticationMessage
=== RUN   TestAccCognitoIDPUserPool_sms
=== PAUSE TestAccCognitoIDPUserPool_sms
=== RUN   TestAccCognitoIDPUserPool_SMS_snsRegion
=== PAUSE TestAccCognitoIDPUserPool_SMS_snsRegion
=== RUN   TestAccCognitoIDPUserPool_SMS_externalID
=== PAUSE TestAccCognitoIDPUserPool_SMS_externalID
=== RUN   TestAccCognitoIDPUserPool_SMS_snsCallerARN
=== PAUSE TestAccCognitoIDPUserPool_SMS_snsCallerARN
=== RUN   TestAccCognitoIDPUserPool_smsVerificationMessage
=== PAUSE TestAccCognitoIDPUserPool_smsVerificationMessage
=== RUN   TestAccCognitoIDPUserPool_withEmail
=== PAUSE TestAccCognitoIDPUserPool_withEmail
=== RUN   TestAccCognitoIDPUserPool_withEmailSource
    user_pool_test.go:922: Environment variable TEST_AWS_SES_VERIFIED_EMAIL_ARN is not set, skipping test
--- SKIP: TestAccCognitoIDPUserPool_withEmailSource (0.00s)
=== RUN   TestAccCognitoIDPUserPool_withAliasAttributes
=== PAUSE TestAccCognitoIDPUserPool_withAliasAttributes
=== RUN   TestAccCognitoIDPUserPool_withUsernameAttributes
=== PAUSE TestAccCognitoIDPUserPool_withUsernameAttributes
=== RUN   TestAccCognitoIDPUserPool_withPasswordPolicy
=== PAUSE TestAccCognitoIDPUserPool_withPasswordPolicy
=== RUN   TestAccCognitoIDPUserPool_withUsername
=== PAUSE TestAccCognitoIDPUserPool_withUsername
=== RUN   TestAccCognitoIDPUserPool_withLambda
=== PAUSE TestAccCognitoIDPUserPool_withLambda
=== RUN   TestAccCognitoIDPUserPool_WithLambda_email
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_email
=== RUN   TestAccCognitoIDPUserPool_WithLambda_sms
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_sms
=== RUN   TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== PAUSE TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
=== RUN   TestAccCognitoIDPUserPool_addLambda
=== PAUSE TestAccCognitoIDPUserPool_addLambda
=== RUN   TestAccCognitoIDPUserPool_schemaAttributes
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributes
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesRemoved
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesRemoved
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesModified
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesModified
=== RUN   TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
=== PAUSE TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
=== RUN   TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== PAUSE TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== RUN   TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8
=== PAUSE TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8
=== RUN   TestAccCognitoIDPUserPool_update
=== PAUSE TestAccCognitoIDPUserPool_update
=== RUN   TestAccCognitoIDPUserPool_disappears
=== PAUSE TestAccCognitoIDPUserPool_disappears
=== RUN   TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== PAUSE TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== CONT  TestAccCognitoIDPUserPool_tags
=== CONT  TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag
=== CONT  TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag
=== CONT  TestAccCognitoIDPUserPool_withEmailVerificationMessage
=== CONT  TestAccCognitoIDPUserPool_withDevice
=== CONT  TestAccCognitoIDPUserPool_withAdvancedSecurityMode
=== CONT  TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy
=== CONT  TestAccCognitoIDPUserPool_withAdminCreateUser
=== CONT  TestAccCognitoIDPUserPool_recovery
=== CONT  TestAccCognitoIDPUserPool_deletionProtection
=== CONT  TestAccCognitoIDPUserPool_basic
=== CONT  TestAccCognitoIDPUserPool_MFA_sms
=== CONT  TestAccCognitoIDPUserPool_disappears
=== CONT  TestAccCognitoIDPUserPool_update
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8
=== CONT  TestAccCognitoIDPUserPool_withVerificationMessageTemplate
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesModified
=== CONT  TestAccCognitoIDPUserPool_passwordHistorySize
--- PASS: TestAccCognitoIDPUserPool_disappears (33.71s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributesRemoved
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesModified (38.54s)
=== CONT  TestAccCognitoIDPUserPool_schemaAttributes
--- PASS: TestAccCognitoIDPUserPool_basic (40.59s)
=== CONT  TestAccCognitoIDPUserPool_addLambda
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesStringAttributeConstraints (40.64s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUserAndPasswordPolicy (40.89s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_sms
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nullNonOverlappingResourceTag (42.43s)
=== CONT  TestAccCognitoIDPUserPool_WithLambda_email
--- PASS: TestAccCognitoIDPUserPool_withUserAttributeUpdateSettings (60.32s)
=== CONT  TestAccCognitoIDPUserPool_withLambda
--- PASS: TestAccCognitoIDPUserPool_withAdminCreateUser (63.29s)
=== CONT  TestAccCognitoIDPUserPool_withUsername
--- PASS: TestAccCognitoIDPUserPool_passwordHistorySize (64.26s)
=== CONT  TestAccCognitoIDPUserPool_withPasswordPolicy
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplateUTF8 (65.63s)
=== CONT  TestAccCognitoIDPUserPool_withUsernameAttributes
--- PASS: TestAccCognitoIDPUserPool_withVerificationMessageTemplate (67.15s)
=== CONT  TestAccCognitoIDPUserPool_withAliasAttributes
--- PASS: TestAccCognitoIDPUserPool_deletionProtection (67.16s)
=== CONT  TestAccCognitoIDPUserPool_withEmail
--- PASS: TestAccCognitoIDPUserPool_withDevice (67.24s)
=== CONT  TestAccCognitoIDPUserPool_smsVerificationMessage
--- PASS: TestAccCognitoIDPUserPool_withEmailVerificationMessage (67.29s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsCallerARN
--- PASS: TestAccCognitoIDPUserPool_schemaAttributesRemoved (34.23s)
=== CONT  TestAccCognitoIDPUserPool_SMS_externalID
--- PASS: TestAccCognitoIDPUserPool_withAdvancedSecurityMode (85.26s)
=== CONT  TestAccCognitoIDPUserPool_SMS_snsRegion
--- PASS: TestAccCognitoIDPUserPool_recovery (85.86s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping
--- PASS: TestAccCognitoIDPUserPool_schemaAttributes (56.90s)
=== CONT  TestAccCognitoIDPUserPool_sms
--- PASS: TestAccCognitoIDPUserPool_update (96.05s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag
--- PASS: TestAccCognitoIDPUserPool_withEmail (32.57s)
=== CONT  TestAccCognitoIDPUserPool_smsAuthenticationMessage
--- PASS: TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_ResourceTag (104.88s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag
--- PASS: TestAccCognitoIDPUserPool_MFA_sms (106.65s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS
--- PASS: TestAccCognitoIDPUserPool_withUsername (52.61s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag
--- PASS: TestAccCognitoIDPUserPool_withUsernameAttributes (51.98s)
=== CONT  TestAccCognitoIDPUserPool_MFA_softwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_withPasswordPolicy (54.40s)
=== CONT  TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_smsVerificationMessage (51.70s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly
--- PASS: TestAccCognitoIDPUserPool_addLambda (80.93s)
=== CONT  TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA
--- PASS: TestAccCognitoIDPUserPool_withAliasAttributes (55.27s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly
--- PASS: TestAccCognitoIDPUserPool_SMS_snsRegion (47.42s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nullOverlappingResourceTag (38.39s)
=== CONT  TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_emptyProviderOnlyTag (37.58s)
=== CONT  TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccCognitoIDPUserPool_tags (142.58s)
=== CONT  TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add
--- PASS: TestAccCognitoIDPUserPool_SMS_externalID (79.86s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate
--- PASS: TestAccCognitoIDPUserPool_SMS_snsCallerARN (81.69s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace
--- PASS: TestAccCognitoIDPUserPool_WithLambda_preGenerationTokenConfig (108.96s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add
--- PASS: TestAccCognitoIDPUserPool_WithLambda_email (113.15s)
=== CONT  TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly
--- PASS: TestAccCognitoIDPUserPool_smsAuthenticationMessage (58.45s)
=== CONT  TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_emptyResourceTag (42.67s)
=== CONT  TestAccCognitoIDPUserPool_tags_EmptyMap
--- PASS: TestAccCognitoIDPUserPool_WithLambda_sms (123.26s)
=== CONT  TestAccCognitoIDPUserPool_tags_AddOnUpdate
--- PASS: TestAccCognitoIDPUserPool_withLambda (108.75s)
=== CONT  TestAccCognitoIDPUserPool_tags_null
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFAToSMS (72.89s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_updateToResourceOnly (64.55s)
--- PASS: TestAccCognitoIDPUserPool_sms (92.12s)
--- PASS: TestAccCognitoIDPUserPool_MFA_smsToSoftwareTokenMFA (70.43s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_updateToProviderOnly (68.19s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_nonOverlapping (109.65s)
--- PASS: TestAccCognitoIDPUserPool_MFA_softwareTokenMFA (79.72s)
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnCreate (43.02s)
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Replace (68.40s)
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyMap (46.52s)
--- PASS: TestAccCognitoIDPUserPool_tags_ComputedTag_OnUpdate_Add (65.16s)
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Replace (59.24s)
--- PASS: TestAccCognitoIDPUserPool_MFA_smsAndSoftwareTokenMFA (87.57s)
--- PASS: TestAccCognitoIDPUserPool_tags_null (40.41s)
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnCreate (63.78s)
--- PASS: TestAccCognitoIDPUserPool_tags_IgnoreTags_Overlap_DefaultTag (71.33s)
--- PASS: TestAccCognitoIDPUserPool_tags_AddOnUpdate (50.89s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_overlapping (86.62s)
--- PASS: TestAccCognitoIDPUserPool_tags_EmptyTag_OnUpdate_Add (71.23s)
--- PASS: TestAccCognitoIDPUserPool_tags_DefaultTags_providerOnly (83.48s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cognitoidp 245.528s

@jar-b jar-b merged commit 5cada78 into main Nov 20, 2024
52 checks passed
@jar-b jar-b deleted the b-cognito_user_pool-crash branch November 20, 2024 14:18
@github-actions github-actions bot added this to the v5.77.0 milestone Nov 20, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Nov 20, 2024
Update CHANGELOG.md for #40195
78793f9
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.77.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 21, 2024
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nam054 nam054 nam054 approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. crash Results from or addresses a Terraform crash or kernel panic. service/cognitoidp Issues and PRs that pertain to the cognitoidp service.
Projects
None yet
Milestone
v5.77.0
2 participants
@jar-b @nam054