Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new resource aws_vpc_block_public_access_options #40233

Merged
merged 7 commits into from
Nov 27, 2024
Merged

Added new resource aws_vpc_block_public_access_options #40233

merged 7 commits into from
Nov 27, 2024

Conversation

madhavvishnubhatta
Copy link
Contributor

@madhavvishnubhatta madhavvishnubhatta commented Nov 21, 2024 •
edited
Loading

Description

New resource aws_vpc_block_public_access_options to support the feature https://aws.amazon.com/about-aws/whats-new/2024/11/block-public-access-amazon-virtual-private-cloud/

Relations

Relates #40200

References

https://aws.amazon.com/about-aws/whats-new/2024/11/block-public-access-amazon-virtual-private-cloud/
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_VpcBlockPublicAccessOptions.html

Output from Acceptance Testing

$ make testacc PKG=ec2 TESTS=TestAccVPCBlockPublicAccessOptions*
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccVPCBlockPublicAccessOptions*'  -timeout 360m
2024/11/21 10:47:01 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCBlockPublicAccessOptions_basic
--- PASS: TestAccVPCBlockPublicAccessOptions_basic (439.56s)
=== RUN   TestAccVPCBlockPublicAccessOptions_updates
--- PASS: TestAccVPCBlockPublicAccessOptions_updates (582.60s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/ec2        1022.291s
...

@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/vpc Issues and PRs that pertain to the vpc service. needs-triage Waiting for first response or review from a maintainer. partner Contribution from a partner. labels Nov 21, 2024
@github-actions github-actions bot added repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. github_actions Pull requests that update Github_actions code labels Nov 21, 2024
@madhavvishnubhatta madhavvishnubhatta marked this pull request as ready for review November 21, 2024 11:49
@madhavvishnubhatta madhavvishnubhatta mentioned this pull request Nov 21, 2024
Merged
@ewbankkit ewbankkit added new-resource Introduces a new resource. and removed needs-triage Waiting for first response or review from a maintainer. labels Nov 26, 2024
@ewbankkit ewbankkit self-assigned this Nov 26, 2024
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Nov 26, 2024
ewbankkit
ewbankkit approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccVPCBlockPublicAccessOptions_serial' PKG=ec2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCBlockPublicAccessOptions_serial -timeout 360m
2024/11/26 12:27:38 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCBlockPublicAccessOptions_serial
=== PAUSE TestAccVPCBlockPublicAccessOptions_serial
=== CONT  TestAccVPCBlockPublicAccessOptions_serial
=== RUN   TestAccVPCBlockPublicAccessOptions_serial/update
=== RUN   TestAccVPCBlockPublicAccessOptions_serial/basic
--- PASS: TestAccVPCBlockPublicAccessOptions_serial (1017.85s)
    --- PASS: TestAccVPCBlockPublicAccessOptions_serial/update (654.48s)
    --- PASS: TestAccVPCBlockPublicAccessOptions_serial/basic (363.37s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1023.514s

johnsonaj
johnsonaj approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

% make testacc TESTARGS='-run=TestAccVPCBlockPublicAccessOptions_serial' PKG=ec2

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccVPCBlockPublicAccessOptions_serial -timeout 360m
2024/11/27 08:10:26 Initializing Terraform AWS Provider...
=== RUN   TestAccVPCBlockPublicAccessOptions_serial
=== PAUSE TestAccVPCBlockPublicAccessOptions_serial
=== CONT  TestAccVPCBlockPublicAccessOptions_serial
=== RUN   TestAccVPCBlockPublicAccessOptions_serial/update
=== RUN   TestAccVPCBlockPublicAccessOptions_serial/basic
--- PASS: TestAccVPCBlockPublicAccessOptions_serial (1117.78s)
    --- PASS: TestAccVPCBlockPublicAccessOptions_serial/update (641.20s)
    --- PASS: TestAccVPCBlockPublicAccessOptions_serial/basic (476.58s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	1124.663s

@ewbankkit ewbankkit merged commit 7c46f31 into hashicorp:main Nov 27, 2024
44 checks passed
@github-actions github-actions bot added this to the v5.79.0 milestone Nov 27, 2024
@ewbankkit
Copy link
Contributor

@madhavvishnubhatta Thanks for the contribution 🎉 👏.

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Dec 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

This functionality has been released in v5.79.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnsonaj johnsonaj johnsonaj approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

@breathingdust breathingdust Awaiting requested review from breathingdust breathingdust is a code owner

@justinretzolk justinretzolk Awaiting requested review from justinretzolk justinretzolk is a code owner

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. generators Relates to code generators. github_actions Pull requests that update Github_actions code new-resource Introduces a new resource. partner Contribution from a partner. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. service/vpc Issues and PRs that pertain to the vpc service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.79.0
Development

Successfully merging this pull request may close these issues.
3 participants
@madhavvishnubhatta @ewbankkit @johnsonaj