Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ignored skip_requesting_account_id argument #40264

Merged
merged 3 commits into from
Nov 22, 2024
Merged

fix ignored skip_requesting_account_id argument #40264

merged 3 commits into from
Nov 22, 2024

Conversation

kilmajster
Copy link
Contributor

Description

Fix for ignored skip_requesting_account_id, many files are touched because tests were expecting this non-expected behavior 😕

Relations

Closes #37062

References

Output from Acceptance Testing

% go test ./internal/conns/... -v -count=1 -parallel 20 -timeout=0 -run=TestProxyConfig
=== RUN   TestProxyConfig
=== RUN   TestProxyConfig/http_proxy_config_https_proxy_envvar
2024/11/22 14:34:06 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/HTTP_PROXY_envvar_HTTPS_PROXY_envvar_NO_PROXY_envvar
2024/11/22 14:34:06 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/no_config
2024/11/22 14:34:06 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_config
2024/11/22 14:34:06 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_config_https_proxy_config_empty_string
2024/11/22 14:34:06 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/HTTPS_PROXY_envvar
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_config_HTTPS_PROXY_envvar
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_config_https_proxy_config
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/HTTP_PROXY_envvar
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/https_proxy_envvar
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_config_overrides_HTTP_PROXY_envvar
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/https_proxy_config_overrides_HTTPS_PROXY_envvar
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_empty_string
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/https_proxy_config
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/https_proxy_config_http_proxy_config_empty_string
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_config_NO_PROXY_envvar
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_config_no_proxy_envvar
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_config_https_proxy_config_no_proxy_config
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
=== RUN   TestProxyConfig/http_proxy_envvar
2024/11/22 14:34:07 Initializing Terraform AWS Provider...
--- PASS: TestProxyConfig (0.37s)
    --- PASS: TestProxyConfig/http_proxy_config_https_proxy_envvar (0.03s)
    --- PASS: TestProxyConfig/HTTP_PROXY_envvar_HTTPS_PROXY_envvar_NO_PROXY_envvar (0.02s)
    --- PASS: TestProxyConfig/no_config (0.02s)
    --- PASS: TestProxyConfig/http_proxy_config (0.02s)
    --- PASS: TestProxyConfig/http_proxy_config_https_proxy_config_empty_string (0.02s)
    --- PASS: TestProxyConfig/HTTPS_PROXY_envvar (0.02s)
    --- PASS: TestProxyConfig/http_proxy_config_HTTPS_PROXY_envvar (0.02s)
    --- PASS: TestProxyConfig/http_proxy_config_https_proxy_config (0.02s)
    --- PASS: TestProxyConfig/HTTP_PROXY_envvar (0.02s)
    --- PASS: TestProxyConfig/https_proxy_envvar (0.02s)
    --- PASS: TestProxyConfig/http_proxy_config_overrides_HTTP_PROXY_envvar (0.02s)
    --- PASS: TestProxyConfig/https_proxy_config_overrides_HTTPS_PROXY_envvar (0.02s)
    --- PASS: TestProxyConfig/http_proxy_empty_string (0.02s)
    --- PASS: TestProxyConfig/https_proxy_config (0.02s)
    --- PASS: TestProxyConfig/https_proxy_config_http_proxy_config_empty_string (0.02s)
    --- PASS: TestProxyConfig/http_proxy_config_NO_PROXY_envvar (0.02s)
    --- PASS: TestProxyConfig/http_proxy_config_no_proxy_envvar (0.02s)
    --- PASS: TestProxyConfig/http_proxy_config_https_proxy_config_no_proxy_config (0.02s)
    --- PASS: TestProxyConfig/http_proxy_envvar (0.02s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/conns      0.460s

@kilmajster kilmajster requested a review from a team as a code owner November 22, 2024 14:06
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecs Issues and PRs that pertain to the ecs service. service/emr Issues and PRs that pertain to the emr service. service/configservice Issues and PRs that pertain to the configservice service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/apigateway Issues and PRs that pertain to the apigateway service. service/dax Issues and PRs that pertain to the dax service. service/directconnect Issues and PRs that pertain to the directconnect service. service/codebuild Issues and PRs that pertain to the codebuild service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/acm Issues and PRs that pertain to the acm service. service/elb Issues and PRs that pertain to the elb service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/athena Issues and PRs that pertain to the athena service. service/codecommit Issues and PRs that pertain to the codecommit service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/efs Issues and PRs that pertain to the efs service. service/budgets Issues and PRs that pertain to the budgets service. service/appsync Issues and PRs that pertain to the appsync service. service/elasticache Issues and PRs that pertain to the elasticache service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/cloudformation Issues and PRs that pertain to the cloudformation service. labels Nov 22, 2024
@github-actions github-actions bot added service/cur Issues and PRs that pertain to the cur service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/controltower Issues and PRs that pertain to the controltower service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/bedrock Issues and PRs that pertain to the bedrock service. service/connectcases Issues and PRs that pertain to the connectcases service. service/appfabric Issues and PRs that pertain to the appfabric service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/datazone Issues and PRs that pertain to the datazone service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/chatbot Issues and PRs that pertain to the chatbot service. service/applicationsignals Issues and PRs that pertain to the applicationsignals service. service/codeconnections Issues and PRs that pertain to the codeconnections service. labels Nov 22, 2024
github-actions[bot]
github-actions bot reviewed Nov 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @kilmajster 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@ewbankkit ewbankkit self-assigned this Nov 22, 2024
ewbankkit
ewbankkit approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

YakDriver
YakDriver approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splendid 🎉

@ewbankkit
Copy link
Contributor

@kilmajster Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit d244ae5 into hashicorp:main Nov 22, 2024
35 checks passed
@github-actions github-actions bot added this to the v5.78.0 milestone Nov 22, 2024
@github-actions GitHub Actions
Copy link

This functionality has been released in v5.78.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@YakDriver YakDriver YakDriver approved these changes

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
client-connections Pertains to the AWS Client and service connections. generators Relates to code generators. provider Pertains to the provider itself, rather than any interaction with AWS. service/accessanalyzer Issues and PRs that pertain to the accessanalyzer service. service/account Issues and PRs that pertain to the account service. service/acm Issues and PRs that pertain to the acm service. service/acmpca Issues and PRs that pertain to the acmpca service. service/amp Issues and PRs that pertain to the amp service. service/amplify Issues and PRs that pertain to the amplify service. service/apigateway Issues and PRs that pertain to the apigateway service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/appautoscaling Issues and PRs that pertain to the appautoscaling service. service/appconfig Issues and PRs that pertain to the appconfig service. service/appfabric Issues and PRs that pertain to the appfabric service. service/appflow Issues and PRs that pertain to the appflow service. service/appintegrations Issues and PRs that pertain to the appintegrations service. service/applicationinsights Issues and PRs that pertain to the applicationinsights service. service/applicationsignals Issues and PRs that pertain to the applicationsignals service. service/appmesh Issues and PRs that pertain to the appmesh service. service/apprunner Issues and PRs that pertain to the apprunner service. service/appstream Issues and PRs that pertain to the appstream service. service/appsync Issues and PRs that pertain to the appsync service. service/athena Issues and PRs that pertain to the athena service. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/autoscalingplans Issues and PRs that pertain to the autoscalingplans service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/bcmdataexports Issues and PRs that pertain to the bcmdataexports service. service/bedrock Issues and PRs that pertain to the bedrock service. service/bedrockagent Issues and PRs that pertain to the bedrockagent service. service/budgets Issues and PRs that pertain to the budgets service. service/ce Issues and PRs that pertain to the ce service. service/chatbot Issues and PRs that pertain to the chatbot service. service/chime Issues and PRs that pertain to the chime service. service/chimesdkmediapipelines Issues and PRs that pertain to the chimesdkmediapipelines service. service/chimesdkvoice Issues and PRs that pertain to the chimesdkvoice service. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. service/cloud9 Issues and PRs that pertain to the cloud9 service. service/cloudcontrol Issues and PRs that pertain to the cloudcontrol service. service/cloudformation Issues and PRs that pertain to the cloudformation service. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/cloudhsmv2 Issues and PRs that pertain to the cloudhsmv2 service. service/cloudsearch Issues and PRs that pertain to the cloudsearch service. service/cloudtrail Issues and PRs that pertain to the cloudtrail service. service/cloudwatch Issues and PRs that pertain to the cloudwatch service. service/codeartifact Issues and PRs that pertain to the codeartifact service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codecommit Issues and PRs that pertain to the codecommit service. service/codeconnections Issues and PRs that pertain to the codeconnections service. service/codeguruprofiler Issues and PRs that pertain to the codeguruprofiler service. service/codegurureviewer Issues and PRs that pertain to the codegurureviewer service. service/codepipeline Issues and PRs that pertain to the codepipeline service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/codestarnotifications Issues and PRs that pertain to the codestarnotifications service. service/cognitoidentity Issues and PRs that pertain to the cognitoidentity service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/comprehend Issues and PRs that pertain to the comprehend service. service/computeoptimizer Issues and PRs that pertain to the computeoptimizer service. service/configservice Issues and PRs that pertain to the configservice service. service/connect Issues and PRs that pertain to the connect service. service/connectcases Issues and PRs that pertain to the connectcases service. service/controltower Issues and PRs that pertain to the controltower service. service/costoptimizationhub Issues and PRs that pertain to the costoptimizationhub service. service/cur Issues and PRs that pertain to the cur service. service/customerprofiles Issues and PRs that pertain to the customerprofiles service. service/databrew Issues and PRs that pertain to the databrew service. service/dataexchange Issues and PRs that pertain to the dataexchange service. service/datapipeline Issues and PRs that pertain to the datapipeline service. service/datasync Issues and PRs that pertain to the datasync service. service/datazone Issues and PRs that pertain to the datazone service. service/dax Issues and PRs that pertain to the dax service. service/deploy Issues and PRs that pertain to the deploy service. service/detective Issues and PRs that pertain to the detective service. service/devicefarm Issues and PRs that pertain to the devicefarm service. service/devopsguru Issues and PRs that pertain to the devopsguru service. service/directconnect Issues and PRs that pertain to the directconnect service. service/dlm Issues and PRs that pertain to the dlm service. service/dms Issues and PRs that pertain to the dms service. service/docdb Issues and PRs that pertain to the docdb service. service/docdbelastic Issues and PRs that pertain to the docdbelastic service. service/drs Issues and PRs that pertain to the drs service. service/ds Issues and PRs that pertain to the ds service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ecr Issues and PRs that pertain to the ecr service. service/ecrpublic Issues and PRs that pertain to the ecrpublic service. service/ecs Issues and PRs that pertain to the ecs service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticbeanstalk Issues and PRs that pertain to the elasticbeanstalk service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elastictranscoder Issues and PRs that pertain to the elastictranscoder service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/emr Issues and PRs that pertain to the emr service. service/emrcontainers Issues and PRs that pertain to the emrcontainers service. service/emrserverless Issues and PRs that pertain to the emrserverless service. service/events Issues and PRs that pertain to the events service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v5.78.0
Development

Successfully merging this pull request may close these issues.

[Bug]: AWS Provider seems to ignore "skip_requesting_account_id"
3 participants
@kilmajster @ewbankkit @YakDriver