-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Cross region endpoint service support #40346
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% AWS_THIRD_REGION=eu-west-1 make testacc TESTARGS='-run=TestAccVPCEndpointService_' PKG=ec2 ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/ec2/... -v -count 1 -parallel 3 -run=TestAccVPCEndpointService_ -timeout 360m
2024/12/02 12:16:33 Initializing Terraform AWS Provider...
=== RUN TestAccVPCEndpointService_basic
=== PAUSE TestAccVPCEndpointService_basic
=== RUN TestAccVPCEndpointService_disappears
=== PAUSE TestAccVPCEndpointService_disappears
=== RUN TestAccVPCEndpointService_tags
=== PAUSE TestAccVPCEndpointService_tags
=== RUN TestAccVPCEndpointService_networkLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_networkLoadBalancerARNs
=== RUN TestAccVPCEndpointService_supportedIPAddressTypes
=== PAUSE TestAccVPCEndpointService_supportedIPAddressTypes
=== RUN TestAccVPCEndpointService_allowedPrincipals
=== PAUSE TestAccVPCEndpointService_allowedPrincipals
=== RUN TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== PAUSE TestAccVPCEndpointService_gatewayLoadBalancerARNs
=== RUN TestAccVPCEndpointService_privateDNSName
=== PAUSE TestAccVPCEndpointService_privateDNSName
=== RUN TestAccVPCEndpointService_crossRegion
=== PAUSE TestAccVPCEndpointService_crossRegion
=== CONT TestAccVPCEndpointService_basic
=== CONT TestAccVPCEndpointService_allowedPrincipals
=== CONT TestAccVPCEndpointService_networkLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_basic (233.49s)
=== CONT TestAccVPCEndpointService_supportedIPAddressTypes
--- PASS: TestAccVPCEndpointService_allowedPrincipals (259.14s)
=== CONT TestAccVPCEndpointService_tags
--- PASS: TestAccVPCEndpointService_networkLoadBalancerARNs (414.54s)
=== CONT TestAccVPCEndpointService_disappears
--- PASS: TestAccVPCEndpointService_supportedIPAddressTypes (251.03s)
=== CONT TestAccVPCEndpointService_privateDNSName
--- PASS: TestAccVPCEndpointService_tags (257.83s)
=== CONT TestAccVPCEndpointService_crossRegion
--- PASS: TestAccVPCEndpointService_disappears (220.39s)
=== CONT TestAccVPCEndpointService_gatewayLoadBalancerARNs
--- PASS: TestAccVPCEndpointService_privateDNSName (250.44s)
--- PASS: TestAccVPCEndpointService_crossRegion (307.69s)
--- PASS: TestAccVPCEndpointService_gatewayLoadBalancerARNs (356.31s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 996.607s
This functionality has been released in v5.79.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
supplemented in #40522 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds cross region support to
aws_vpc_endpoint_service
.This doesn't add this to the datasource as the
ServiceDetail
used by that data source does not returnedSupportedRegions
asServiceConfiguration
does so requires a bit more work.Relations
Closes #40321.
References
Output from Acceptance Testing