-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SuppressEquivalentJsonDiffs on redrive_allow_policy for aws_sqs_queue_redrive_allow_policy #40604
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccSQSQueueRedriveAllowPolicy_\|TestAccSQSQueueDataSource_' PKG=sqs ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/sqs/... -v -count 1 -parallel 3 -run=TestAccSQSQueueRedriveAllowPolicy_\|TestAccSQSQueueDataSource_ -timeout 360m
2024/12/18 14:34:30 Initializing Terraform AWS Provider...
=== RUN TestAccSQSQueueDataSource_tags
=== PAUSE TestAccSQSQueueDataSource_tags
=== RUN TestAccSQSQueueDataSource_tags_NullMap
=== PAUSE TestAccSQSQueueDataSource_tags_NullMap
=== RUN TestAccSQSQueueDataSource_tags_EmptyMap
=== PAUSE TestAccSQSQueueDataSource_tags_EmptyMap
=== RUN TestAccSQSQueueDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccSQSQueueDataSource_tags_DefaultTags_nonOverlapping
=== RUN TestAccSQSQueueDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccSQSQueueDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN TestAccSQSQueueDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccSQSQueueDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN TestAccSQSQueueDataSource_basic
=== PAUSE TestAccSQSQueueDataSource_basic
=== RUN TestAccSQSQueueRedriveAllowPolicy_basic
=== PAUSE TestAccSQSQueueRedriveAllowPolicy_basic
=== RUN TestAccSQSQueueRedriveAllowPolicy_disappears
=== PAUSE TestAccSQSQueueRedriveAllowPolicy_disappears
=== RUN TestAccSQSQueueRedriveAllowPolicy_Disappears_queue
=== PAUSE TestAccSQSQueueRedriveAllowPolicy_Disappears_queue
=== RUN TestAccSQSQueueRedriveAllowPolicy_update
=== PAUSE TestAccSQSQueueRedriveAllowPolicy_update
=== RUN TestAccSQSQueueRedriveAllowPolicy_byQueue
=== PAUSE TestAccSQSQueueRedriveAllowPolicy_byQueue
=== CONT TestAccSQSQueueDataSource_tags
=== CONT TestAccSQSQueueDataSource_basic
=== CONT TestAccSQSQueueDataSource_tags_DefaultTags_nonOverlapping
--- PASS: TestAccSQSQueueDataSource_tags (41.01s)
=== CONT TestAccSQSQueueDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccSQSQueueDataSource_tags_DefaultTags_nonOverlapping (41.02s)
=== CONT TestAccSQSQueueDataSource_tags_IgnoreTags_Overlap_DefaultTag
--- PASS: TestAccSQSQueueDataSource_basic (41.42s)
=== CONT TestAccSQSQueueRedriveAllowPolicy_Disappears_queue
--- PASS: TestAccSQSQueueDataSource_tags_IgnoreTags_Overlap_DefaultTag (39.47s)
=== CONT TestAccSQSQueueRedriveAllowPolicy_byQueue
--- PASS: TestAccSQSQueueDataSource_tags_IgnoreTags_Overlap_ResourceTag (39.66s)
=== CONT TestAccSQSQueueRedriveAllowPolicy_update
--- PASS: TestAccSQSQueueRedriveAllowPolicy_Disappears_queue (133.18s)
=== CONT TestAccSQSQueueRedriveAllowPolicy_disappears
--- PASS: TestAccSQSQueueRedriveAllowPolicy_byQueue (118.37s)
=== CONT TestAccSQSQueueRedriveAllowPolicy_basic
--- PASS: TestAccSQSQueueRedriveAllowPolicy_update (151.87s)
=== CONT TestAccSQSQueueDataSource_tags_NullMap
--- PASS: TestAccSQSQueueDataSource_tags_NullMap (39.20s)
=== CONT TestAccSQSQueueDataSource_tags_EmptyMap
--- PASS: TestAccSQSQueueDataSource_tags_EmptyMap (39.32s)
--- PASS: TestAccSQSQueueRedriveAllowPolicy_basic (125.54s)
--- PASS: TestAccSQSQueueRedriveAllowPolicy_disappears (164.93s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/sqs 344.877s
@@ -68,16 +66,6 @@ func dataSourceQueueRead(ctx context.Context, d *schema.ResourceData, meta inter | |||
d.Set(names.AttrARN, attributesOutput) | |||
d.Set(names.AttrURL, queueURL) | |||
|
|||
if errs.IsUnsupportedOperationInPartitionError(meta.(*conns.AWSClient).Partition(ctx), err) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed as part of the change? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@t0yv0 Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.82.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
redrive_allow_policy field on aws_sqs_queue_redrive_allow_policy is made more robust to ignore non-semantic JSON whitespace changes for purposes of planning.
Relations
Closes #40119
References
Output from Acceptance Testing