[Bug]: aws_api_gateway_domain_name - wrong parameters for GetDomainName API call

[A-Shevchenko]

Terraform Core Version

1.10.3

AWS Provider Version

5.82.2

Affected Resource(s)

aws_api_gateway_domain_name

Expected Behavior

Resource created/updated without errors

Actual Behavior

Error: waiting for API Gateway Domain Name (DOMAIN_NAME/DOMAIN_NAME_ID) update: couldn't find resource

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

locals {
  domain_name = "DOMAIN_NAME"
  upper_level_domain_name="TOP_LEVEL_DOMAIN_NAME"
}

data "aws_acm_certificate" "wildcard" {
  domain = "*.${local.upper_level_domain_name}"
}

resource "aws_api_gateway_domain_name" "domain_name" {
  domain_name = local.domain_name
  endpoint_configuration {
    types = ["PRIVATE"]
  }
  certificate_arn = data.aws_acm_certificate.wildcard.arn
  policy = <<JSON
{
    "Version": "2012-10-17",
    "Statement": [
        {
            "Effect": "Allow",
            "Principal": "*",
            "Action": "execute-api:Invoke",
            "Resource": [
                "execute-api:/*"
            ]
        },
        {
            "Effect": "Deny",
            "Principal": "*",
            "Action": "execute-api:Invoke",
            "Resource": [
                "execute-api:/*"
            ],
            "Condition" : {
                "StringNotEquals": {
                    "aws:SourceVpce": "VPCE_ID"
                }
            }
        }
    ]
}
JSON
}

Steps to Reproduce

try to apply configuration above

Debug Output

No response

Panic Output

No response

Important Factoids

In debug logs I can see that request is made to the following URL:

http.url="https:
//apigateway.us-east-1.amazonaws.com/domainnames/DOMAIN_NAME%2FDOMAIN_NAME_ID?domainNameId=DOMAIN_NAME_ID"

However, it doesn't seem to be correct - DOMAIN_NAME_ID is present in both path and query string param.
According to API documentation - path should contain DOMAIN_NAME only, without %2FDOMAIN_NAME_ID

References

No response

Would you like to implement a fix?

None

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

• If you are interested in working on this issue, please leave a comment.
• If this would be your first contribution, please review the contribution guide.

[A-Shevchenko]

Found the problem:
https://github.com/hashicorp/terraform-provider-aws/blob/main/internal/service/apigateway/domain_name.go#L441
here: waitDomainNameUpdated(ctx, conn, d.Id(), domainNameID) - domainName should be used instead of d.Id() (as d.Id() is a composite value parsed into domainName and domainNameID above)
Will try to add tests for this and prepare PR in the next few days

[github-actions]

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

[github-actions]

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!