Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for grpc config in cloudfront #40762

Conversation

stijndehaes
Copy link
Contributor

Description

Relations

Closes #40492

References

N/A

Output from Acceptance Testing

% make testacc TESTS=TestAccCloudFrontDistribution_grpcConfig PKG=cloudfront                     
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run='TestAccCloudFrontDistribution_grpcConfig'  -timeout 360m
^@2025/01/03 16:46:16 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudFrontDistribution_grpcConfig
=== PAUSE TestAccCloudFrontDistribution_grpcConfig
=== CONT  TestAccCloudFrontDistribution_grpcConfig
--- PASS: TestAccCloudFrontDistribution_grpcConfig (297.57s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 302.170s
...

Copy link

github-actions bot commented Jan 3, 2025

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. needs-triage Waiting for first response or review from a maintainer. labels Jan 3, 2025
@stijndehaes stijndehaes force-pushed the f-aws_cloudfront_distribution-grpc_config branch from fdbcb6b to 4211069 Compare January 3, 2025 16:16
@stijndehaes stijndehaes force-pushed the f-aws_cloudfront_distribution-grpc_config branch from 4211069 to c06a0f2 Compare January 3, 2025 16:29
@stijndehaes stijndehaes marked this pull request as ready for review January 3, 2025 16:36
@stijndehaes stijndehaes requested a review from a team as a code owner January 3, 2025 16:36
@stijndehaes stijndehaes changed the title Added support for grpc config in cloudfront feat: added support for grpc config in cloudfront Jan 6, 2025
@github-actions github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 6, 2025
@ewbankkit ewbankkit added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jan 6, 2025
@ewbankkit ewbankkit self-assigned this Jan 6, 2025
@github-actions github-actions bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 6, 2025
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFrontDistribution_grpcConfig\|TestAccCloudFrontDistribution_basic' PKG=cloudfront
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudfront/... -v -count 1 -parallel 20  -run=TestAccCloudFrontDistribution_grpcConfig\|TestAccCloudFrontDistribution_basic -timeout 360m
2025/01/06 09:28:54 Initializing Terraform AWS Provider...
=== RUN   TestAccCloudFrontDistribution_basic
=== PAUSE TestAccCloudFrontDistribution_basic
=== RUN   TestAccCloudFrontDistribution_grpcConfig
=== PAUSE TestAccCloudFrontDistribution_grpcConfig
=== CONT  TestAccCloudFrontDistribution_basic
=== CONT  TestAccCloudFrontDistribution_grpcConfig
--- PASS: TestAccCloudFrontDistribution_grpcConfig (284.91s)
--- PASS: TestAccCloudFrontDistribution_basic (287.04s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	292.578s

Copy link
Contributor

@johnsonaj johnsonaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit
Copy link
Contributor

@stijndehaes Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit f43b69a into hashicorp:main Jan 6, 2025
41 of 42 checks passed
@github-actions github-actions bot added this to the v5.83.0 milestone Jan 6, 2025
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/cloudfront Issues and PRs that pertain to the cloudfront service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add support for Cloudfront gRPC requests
3 participants