-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added support for grpc config in cloudfront #40762
feat: added support for grpc config in cloudfront #40762
Conversation
Community NoteVoting for Prioritization
For Submitters
|
fdbcb6b
to
4211069
Compare
4211069
to
c06a0f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCloudFrontDistribution_grpcConfig\|TestAccCloudFrontDistribution_basic' PKG=cloudfront
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.3 test ./internal/service/cloudfront/... -v -count 1 -parallel 20 -run=TestAccCloudFrontDistribution_grpcConfig\|TestAccCloudFrontDistribution_basic -timeout 360m
2025/01/06 09:28:54 Initializing Terraform AWS Provider...
=== RUN TestAccCloudFrontDistribution_basic
=== PAUSE TestAccCloudFrontDistribution_basic
=== RUN TestAccCloudFrontDistribution_grpcConfig
=== PAUSE TestAccCloudFrontDistribution_grpcConfig
=== CONT TestAccCloudFrontDistribution_basic
=== CONT TestAccCloudFrontDistribution_grpcConfig
--- PASS: TestAccCloudFrontDistribution_grpcConfig (284.91s)
--- PASS: TestAccCloudFrontDistribution_basic (287.04s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 292.578s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@stijndehaes Thanks for the contribution 🎉 👏. |
This functionality has been released in v5.83.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Description
Relations
Closes #40492
References
N/A
Output from Acceptance Testing