Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Support zonal shift for ALBs #40837

Open
cdaniluk opened this issue Jan 8, 2025 · 2 comments
Open

[Enhancement]: Support zonal shift for ALBs #40837

cdaniluk opened this issue Jan 8, 2025 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.

Comments

@cdaniluk
Copy link

cdaniluk commented Jan 8, 2025

Description

aws_lb supports zonal shift for NLBs but not ALBs. Per ARC documentation, the same attribute is valid for ALBs and NLBs.

Suggest changing:

loadBalancerTypesSupported: []awstypes.LoadBalancerTypeEnum{awstypes.LoadBalancerTypeEnumNetwork},

to:

		loadBalancerTypesSupported: []awstypes.LoadBalancerTypeEnum{awstypes.LoadBalancerTypeEnumApplication, awstypes.LoadBalancerTypeEnumNetwork},

Tests would need to be updated as well. Happy to submit a PR if helpful.

Affected Resource(s) and/or Data Source(s)

  • aws_lb

Potential Terraform Configuration

No change to Terraform configuration or docs are required.

References

See:

https://docs.aws.amazon.com/r53recovery/latest/dg/arc-zonal-shift.resource-types.app-load-balancers.html#using-alb-zs
https://docs.aws.amazon.com/r53recovery/latest/dg/arc-zonal-shift.resource-types.network-load-balancers.html#using-nlb-zs

Would you like to implement a fix?

None

@cdaniluk cdaniluk added the enhancement Requests to existing resources that expand the functionality or scope. label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/elbv2 Issues and PRs that pertain to the elbv2 service. needs-triage Waiting for first response or review from a maintainer. labels Jan 8, 2025
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Jan 8, 2025
@ewbankkit
Copy link
Contributor

Relates #40271.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
Development

No branches or pull requests

2 participants