Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authenticate-oidc and authenticate-cognito for aws_lb_listener #4707

Closed
atsushi-ishibashi opened this issue May 31, 2018 · 4 comments · Fixed by #6094
Closed

Support authenticate-oidc and authenticate-cognito for aws_lb_listener #4707

atsushi-ishibashi opened this issue May 31, 2018 · 4 comments · Fixed by #6094
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Milestone

Comments

@atsushi-ishibashi
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

ELB Listener supports new actions to authenticate token.

New or Affected Resource(s)

  • aws_lb_listener

Potential Terraform Configuration

resource "aws_lb_listener" "front_end" {

  ...

  default_action {
    authenticate_cognito_config {
      ... // modify after research
    }
    order = 1
    type = "authenticate-cognito"
  }
  default_action {
    target_group_arn = "${aws_lb_target_group.front_end.arn}"
    type             = "forward"
  }
}

References

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels May 31, 2018
@bflad
Copy link
Contributor

bflad commented May 31, 2018

We should probably create a separate issue to support this in aws_lb_listener_rule as well. 😄

Edit: looks like #4711 was created for that purpose 🎉 slightly editing the issue titles to clarify

@bflad
Copy link
Contributor

bflad commented Oct 9, 2018

Thanks to @atsushi-ishibashi and @mikael-lindstrom, initial support for Cognito and OIDC authentication in aws_lb_listener and aws_lb_listener_rule has been merged in and will release with version 1.40.0 of the AWS provider, likely middle of this week. 🎉

@bflad
Copy link
Contributor

bflad commented Oct 10, 2018

This has been released in version 1.40.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service.
Projects
None yet
2 participants