Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_launch_template: Tag on create #9501

Closed
ewbankkit opened this issue Jul 25, 2019 · 3 comments · Fixed by #10759
Closed

r/aws_launch_template: Tag on create #9501

ewbankkit opened this issue Jul 25, 2019 · 3 comments · Fixed by #10759
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone
v2.35.0

Comments

@ewbankkit
Copy link
Contributor

ewbankkit commented Jul 25, 2019 •
edited
Loading

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Amazon EC2 now supports tagging launch templates on creation.

This will allow us to remove the not-preferred call to resourceAwsLaunchTemplateUpdate from resourceAwsLaunchTemplateCreate and replace with a call to resourceAwsLaunchTemplateRead.

New or Affected Resource(s)

Potential Terraform Configuration

n/a

References

Announcement.

Requires:
@ewbankkit ewbankkit added the enhancement Requests to existing resources that expand the functionality or scope. label Jul 25, 2019
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Jul 25, 2019
@bflad bflad added service/ec2 Issues and PRs that pertain to the ec2 service. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 26, 2019
@ewbankkit ewbankkit mentioned this issue Nov 5, 2019
Merged
@bflad bflad added this to the v2.35.0 milestone Nov 6, 2019
@bflad
Copy link
Contributor

bflad commented Nov 6, 2019

Support for this has been merged and will release with version 2.35.0 of the Terraform AWS Provider, tomorrow. Thanks to @ewbankkit for the implementation. 👍

@ghost
Copy link

ghost commented Nov 7, 2019

This has been released in version 2.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
v2.35.0
Development

Successfully merging a pull request may close this issue.

r/aws_launch_template: Tag on create ewbankkit/terraform-provider-aws
2 participants
@bflad @ewbankkit